Change leak acceptance level

This commit is contained in:
Thomas Nordquist
2019-04-27 10:31:16 +02:00
parent 6021df7150
commit e9e6ea618d

View File

@@ -84,12 +84,14 @@ async function waitForGarbageCollectorToDetermineLeak(browser: any, initialTreeO
let leak = false let leak = false
while (delta < 0) { while (delta < 0) {
if (lastTreeOccurances !== -1) { if (lastTreeOccurances !== -1) {
await sleep(120000, true) await sleep(10000, true)
} }
const heapDump = await getHeapDump(browser) const heapDump = await getHeapDump(browser)
const currentTreeOccurrances = await countInstancesOf(heapDump, ClassNameMapping.Tree) const currentTreeOccurrances = await countInstancesOf(heapDump, ClassNameMapping.Tree)
const currentNodeOccurrances = await countInstancesOf(heapDump, ClassNameMapping.TreeNode) const currentNodeOccurrances = await countInstancesOf(heapDump, ClassNameMapping.TreeNode)
if (initialTreeOccurrances !== currentTreeOccurrances || Math.abs(currentNodeOccurrances - initialNodeOccurrances) > 8) {
// Temporary "leaks" are expected due to React Fibers memoization
if (Math.abs(initialTreeOccurrances - currentTreeOccurrances) > 1 || Math.abs(currentNodeOccurrances - initialNodeOccurrances) > 8) {
console.error('Possible leak detected', initialTreeOccurrances, currentTreeOccurrances, initialNodeOccurrances, currentNodeOccurrances) console.error('Possible leak detected', initialTreeOccurrances, currentTreeOccurrances, initialNodeOccurrances, currentNodeOccurrances)
leak = true leak = true
} else { } else {