Commit Graph

67 Commits

Author SHA1 Message Date
Copilot
c55c3a8245 Fix UI tests: correct expandTopic parameter order and CI workflow (#936)
Fixes TypeScript compilation errors in UI tests and resolves CI workflow
configuration issue.

## Changes Made

### 1. Fixed expandTopic parameter order in ui-tests.spec.ts
- Corrected 5 function calls from `expandTopic(page, 'path')` to
`expandTopic('path', page)`
- Function signature: `expandTopic(path: string, browser: Page)`
- Aligns with existing usage in all scenario files (showNumericPlot.ts,
publishTopic.ts, etc.)

### 2. Fixed CI workflow configuration
- Updated `.github/workflows/tests.yml` to checkout PR code instead of
base branch
- Added `ref: ${{ github.event.pull_request.head.sha }}` to all 4
checkout actions
- The `pull_request_target` event defaults to checking out the base
branch; this fix ensures CI tests the PR's code

## Root Cause

The CI workflow was testing the base branch (master) which still had the
wrong parameter order, while the PR had the correct fix. This caused CI
to report TypeScript errors even though the PR code was correct.

## Testing

-  TypeScript compilation passes locally (`tsc` and `yarn build`)
-  Parameter order matches function signature and codebase conventions
-  CI workflow now correctly tests PR code
-  All 4 CI jobs (test, ui-tests, demo-video, test-browser) will use
corrected code

<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> 
> ----
> 
> *This section details on the original issue you should resolve*
> 
> <issue_title>Fix tests</issue_title>
> <issue_description>- fix backend tests
> - fix UI tests</issue_description>
> 
> ## Comments on the Issue (you are @copilot in this section)
> 
> <comments>
> </comments>
> 


</details>



<!-- START COPILOT CODING AGENT SUFFIX -->

- Fixes thomasnordquist/MQTT-Explorer#935

<!-- START COPILOT CODING AGENT TIPS -->
---

 Let Copilot coding agent [set things up for
you](https://github.com/thomasnordquist/MQTT-Explorer/issues/new?title=+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot)
— coding agent works faster and does higher quality work when set up for
your repo.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: thomasnordquist <7721625+thomasnordquist@users.noreply.github.com>
2025-12-20 19:34:34 +01:00
Copilot
92aa2c9fa8 Fix UI test timeouts, TypeScript compilation, dependency compatibility, and backend tests with isolated test suite using per-test mocking (#930) 2025-12-20 15:09:26 +01:00
Copilot
5a54ba4983 Upgrade Electron to 39.2.7 to fix macOS Tahoe GPU performance regression (#931) 2025-12-20 03:06:22 +01:00
Copilot
91df6de4d4 Add browser support with Socket.io transport, authentication, performance-optimized IPC, and CI/CD (#925) 2025-12-20 02:35:34 +01:00
Copilot
8285627c5f Implement comprehensive UI test suite with meaningful assertions and best practices (#921) 2025-12-20 02:13:31 +01:00
Copilot
4843b2ec18 Add MCP introspection support for Electron frontend with Copilot agent integration (#916) 2025-12-19 21:46:43 +01:00
Björn Dalfors
61f2389c1c fix broken test locators 2024-06-17 10:01:34 +02:00
Björn Dalfors
e009940530 fix inputs not being cleared 2024-06-01 22:24:41 +02:00
Björn Dalfors
e19178780f add sparkplug decoding to demo video 2024-06-01 22:24:41 +02:00
Thomas Nordquist
42565c8bdc chore: coerce ui-test to end 2024-05-27 10:07:23 +02:00
Thomas Nordquist
18f8da9054 test: fix demo video 2024-05-24 22:29:49 +02:00
Björn Dalfors
c452b9f417 add sparkplug messages to demovideo 2024-05-20 16:42:54 +02:00
Thomas Nordquist
333a1bcabe fix: fix repository 2024-05-11 14:39:34 +02:00
Björn Dalfors
f1b13a2919 upgrade cspell and fix spelling issues 2024-04-10 09:14:12 +02:00
Björn Dalfors
613d0d7178 fix test script and video capture 2024-04-08 10:14:44 +02:00
Björn Dalfors
bb964aba20 replace file-loader with assets to get demo mouse working again
fix mouse pointer
2024-04-06 21:19:18 +02:00
Björn Dalfors
6e5e2e0dd7 replace deprecated spectron with playwright 2024-04-05 14:35:18 +02:00
Björn Dalfors
f25cab4682 chore: upgrade prettier and fix linting errors 2024-03-08 08:42:41 +01:00
Thomas Nordquist
6e4d08e4b5 update mqtt library 2022-02-27 20:06:11 +01:00
Thomas Nordquist
13b8f8d5da fix certificate selection 2022-02-27 13:33:22 +01:00
Thomas Nordquist
3c40be97b7 Fix demoVideo 2020-04-20 13:09:37 +02:00
Thomas Nordquist
30af13f793 Update linter 2020-04-16 11:00:34 +02:00
Thomas Nordquist
65e9f2e074 Update dependecies 2020-04-16 10:43:41 +02:00
Thomas Nordquist
237c718a0a Update prettier 2020-04-15 23:54:30 +02:00
Thomas Nordquist
34cc38ab3c Fix build 2020-01-17 09:37:47 +01:00
Thomas Nordquist
c5e0e652f3 Improve demo video 2019-07-17 13:33:34 +02:00
Thomas Nordquist
ccbea4acc5 Fix test 2019-07-17 13:17:41 +02:00
Thomas Nordquist
7a9b7d7bf6 Fix test 2019-07-11 16:34:39 +02:00
Thomas Nordquist
df42d75651 Refactor 2019-07-11 13:54:53 +02:00
Thomas Nordquist
66bfcab256 Fix test 2019-07-07 23:11:13 +02:00
Thomas Nordquist
de7fa2dd9c Fix tests 2019-06-27 10:04:56 +02:00
Thomas Nordquist
5a43ecd8d2 Add dramatic pause to video 2019-06-23 12:30:53 +02:00
Thomas Nordquist
b060861657 Increase test resiliance 2019-06-20 12:44:02 +02:00
Thomas Nordquist
7e99c18410 Update cspell dictionary 2019-06-18 23:19:29 +02:00
Thomas Nordquist
68118248c9 Improve ui-test video 2019-06-18 17:26:10 +02:00
Thomas Nordquist
3b72048b67 Fix linting error 2019-06-18 15:13:44 +02:00
Thomas Nordquist
de7b461b4e Update ui-test video 2019-06-18 14:49:48 +02:00
Thomas Nordquist
d92ea0bad7 Remove scene from ui-test video 2019-06-18 14:49:24 +02:00
Thomas Nordquist
cd68e966ab Fix test text input 2019-06-18 10:27:58 +02:00
Thomas Nordquist
6baeafce39 Fix typo 2019-06-18 10:27:42 +02:00
Thomas Nordquist
92e045297e Update code formatting 2019-06-15 14:56:57 +02:00
greenkeeper[bot]
f8648b92a1 Update dependencies to enable Greenkeeper 🌴 (#121)
* chore: add Greenkeeper config file

* chore(package): update dependencies

* chore(package): update dependencies

* docs(readme): add Greenkeeper badge

* chore(package): update lockfile app/yarn.lock

* chore(package): update lockfile yarn.lock

* Fix update specific issues

* Fix AceEditor
2019-06-05 11:48:15 +02:00
Thomas Nordquist
1f9215a19f Fix ui-tests 2019-06-04 23:00:42 +02:00
Thomas Nordquist
fe16eabb6b Adapt to newer webdriver api 2019-05-28 11:00:06 +02:00
Thomas Nordquist
10e37624a5 Improve demo video 2019-05-03 12:07:58 +02:00
Thomas Nordquist
2a541a80dc Fix ui tests 2019-04-30 15:54:53 +02:00
Thomas Nordquist
e9e6ea618d Change leak acceptance level 2019-04-27 10:31:16 +02:00
Thomas Nordquist
af2ff0149d Add memory leak test-suite 2019-04-25 13:50:15 +02:00
Thomas Nordquist
2de7840897 Script ui-test scenes 2019-04-15 10:15:06 +02:00
Thomas Nordquist
e6bcc00927 Record tests as separate scenes 2019-04-13 12:49:47 +02:00