Compare commits

...

10 Commits

Author SHA1 Message Date
timotheereausanofi
4ae0645208 feat: Add publish pane hide feature and comprehensive security updates
Some checks failed
Docker Browser Build / build-and-test (push) Has been cancelled
Lint / lint (push) Has been cancelled
Security & Compliance Updates:
- Add MQTT_EXPLORER_HIDE_PUBLISH_PANE env var to hide publish pane in browser mode
- Fix critical XSS vulnerabilities in UpdateNotifier and CodeDiff components with DOMPurify
- Implement secure credential handling (memory-based instead of sessionStorage)
- Add comprehensive audit logging system for security events
- Fix GitHub API token exposure by using Authorization header
- Enable certificate validation for TLS connections by default
- Update dependencies to fix 26+ security vulnerabilities
- Add privacy compliance notices and GDPR disclosures
- Implement secure session management with auto-clearing credentials

Features:
- Conditional publish pane visibility in desktop and mobile views
- Privacy policy and data processing transparency
- Enhanced audit trail for compliance

Breaking Changes:
- Updated multiple dependencies for security
- Changed credential storage mechanism
- Added DOMPurify dependency for XSS protection

Fixes #security-audit-2026
2026-05-05 19:13:49 +02:00
Copilot
35f31973c4 Fix GitHub workflow: .env.llm-tests lost on checkout (#1041)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: thomasnordquist <7721625+thomasnordquist@users.noreply.github.com>
Co-authored-by: Thomas Nordquist <thomasnordquist@users.noreply.github.com>
2026-01-30 21:58:35 +01:00
dependabot[bot]
0cae66de69 chore(deps): bump brace-expansion from 1.1.11 to 1.1.12 (#1042)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-30 21:33:16 +01:00
dependabot[bot]
d2aa3c4fe0 chore(deps-dev): bump js-yaml from 3.14.1 to 3.14.2 (#1043)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2026-01-30 21:32:55 +01:00
Thomas Nordquist
4289b7f007 Remove duplicate checkout step in workflow
Removed duplicate checkout step in workflow.
2026-01-30 21:29:16 +01:00
Thomas Nordquist
00eb7d4aa5 Update secret persistence method in workflow
Persist OPENAI_API_KEY to .env.llm-tests instead of GITHUB_ENV.
2026-01-30 21:22:55 +01:00
Copilot
ed8a7f559e Add observability for LLM topic context inclusion (#1038)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: thomasnordquist <7721625+thomasnordquist@users.noreply.github.com>
Co-authored-by: Thomas Nordquist <thomasnordquist@users.noreply.github.com>
2026-01-30 20:53:29 +01:00
Thomas Nordquist
080a773dbd Persist secrets to agent environment
Add step to persist secrets to agent environment.
2026-01-30 20:13:42 +01:00
Thomas Nordquist
c8c12724f0 Add OPENAI_API_KEY to workflow environment variables 2026-01-27 22:27:41 +01:00
Copilot
c1ab90abe9 Fix AI Assistant visibility when API key is set via environment variables (#1037)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: thomasnordquist <7721625+thomasnordquist@users.noreply.github.com>
2026-01-27 13:09:05 +01:00
201 changed files with 42628 additions and 5285 deletions

View File

@@ -53,6 +53,31 @@
"noconflict", "noconflict",
"sparkplugb", "sparkplugb",
"protojson", "protojson",
"typesafe" "typesafe",
"visx",
"socketio",
"uuidv",
"hsts",
"frameguard",
"sameorigin",
"mqtts",
"infobars",
"KHTML",
"networkidle",
"testuser",
"wronguser",
"viewports",
"topicname",
"labelledby",
"dontAddToRecent",
"eclipseprojects",
"tasmota",
"Tasmota",
"automations",
"homeassistant",
"cmnd",
"parseable",
"sonoff",
"tele"
] ]
} }

18
.env.example Normal file
View File

@@ -0,0 +1,18 @@
# Example .env file for LLM tests
# Copy this to .env.llm-tests and fill in your API key
# Option 1: OpenAI (recommended for development)
export OPENAI_API_KEY=sk-your-openai-api-key-here
# Option 2: Google Gemini
# export GEMINI_API_KEY=your-gemini-api-key-here
# Option 3: Generic LLM API (specify provider)
# export LLM_API_KEY=your-api-key-here
# export LLM_PROVIDER=openai # or 'gemini'
# Enable LLM tests (required)
export RUN_LLM_TESTS=true
# Optional: Token limit for neighboring topics (default: 500)
# export LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=500

View File

@@ -7,6 +7,17 @@
3. **Evaluate after every session**: Consider whether the instructions need updates based on what you learned 3. **Evaluate after every session**: Consider whether the instructions need updates based on what you learned
4. **Concise and useful**: All information must be actionable, current, and concise 4. **Concise and useful**: All information must be actionable, current, and concise
## Code Formatting and Linting
**Before committing code, always run:**
- `yarn lint:prettier:fix` - Format all TypeScript files with Prettier
- `yarn lint:fix` - Fix ESLint and Prettier issues
**Check code quality:**
- `yarn lint` - Check Prettier, ESLint, and spell checking
- `yarn lint:prettier` - Check Prettier formatting only
- `yarn lint:eslint` - Check ESLint only
## Test Commands ## Test Commands
**Unit tests:** **Unit tests:**
@@ -14,6 +25,14 @@
- `yarn test:app` - Frontend tests only - `yarn test:app` - Frontend tests only
- `yarn test:backend` - Backend tests only - `yarn test:backend` - Backend tests only
**LLM integration tests:**
- Requires API key (OpenAI or Gemini)
- **Setup**: Run `./scripts/setup-llm-env.sh` to create `.env.llm-tests` from injected secrets
- **Usage**: `source .env.llm-tests && ./scripts/run-llm-tests.sh`
- **Note**: The `.env.llm-tests` file must be sourced to get the LLM access token before running tests
- Tests make real API calls and cost ~$0.01-$0.05 per run
- See `app/src/services/spec/README.md` for details
**Integration tests:** **Integration tests:**
- `yarn test:ui` - Browser tests (requires `yarn build` first) - `yarn test:ui` - Browser tests (requires `yarn build` first)
- `yarn test:demo-video` - UI recording (requires Xvfb, mosquitto, tmux, ffmpeg) - `yarn test:demo-video` - UI recording (requires Xvfb, mosquitto, tmux, ffmpeg)

View File

@@ -17,11 +17,20 @@ jobs:
env: env:
TESTS_MQTT_BROKER_HOST: localhost TESTS_MQTT_BROKER_HOST: localhost
TESTS_MQTT_BROKER_PORT: 1883 TESTS_MQTT_BROKER_PORT: 1883
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
steps: steps:
- name: Checkout code - name: Checkout code
uses: actions/checkout@v6 uses: actions/checkout@v6
- name: Persist Secrets to Agent Environment
run: |
echo "export OPENAI_API_KEY=${{ secrets.OPENAI_API_KEY }}" > .env.llm-tests
echo "export RUN_LLM_TESTS=true" >> .env.llm-tests
chmod 600 .env.llm-tests
echo "✅ Created .env.llm-tests file"
ls -la .env.llm-tests
- name: Install system dependencies - name: Install system dependencies
run: | run: |
sudo apt-get update sudo apt-get update

38
.github/workflows/lint.yml vendored Normal file
View File

@@ -0,0 +1,38 @@
name: Lint
on:
pull_request_target:
branches: [master, beta, release]
push:
branches: [master, beta, release]
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha || github.sha }}
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '24'
cache: 'yarn'
- name: Install Dependencies
run: yarn install --frozen-lockfile
- name: Run Prettier
run: yarn lint:prettier
- name: Run ESLint
run: yarn lint:eslint
continue-on-error: true # Allow failures for now due to existing issues
- name: Run Spellcheck
run: yarn lint:spellcheck

View File

@@ -20,8 +20,6 @@ jobs:
ref: ${{ github.event.pull_request.head.sha }} ref: ${{ github.event.pull_request.head.sha }}
- name: Install Packages - name: Install Packages
run: yarn install --frozen-lockfile run: yarn install --frozen-lockfile
- name: Lint
run: yarn lint:eslint
- name: Build - name: Build
run: yarn build run: yarn build
- name: Test - name: Test

5
.gitignore vendored
View File

@@ -25,6 +25,11 @@ app/.webpack-cache
# Temporary files # Temporary files
/tmp /tmp
# Environment files with secrets
.env
.env.*
!.env.example
# Demo video artifacts # Demo video artifacts
scenes.json scenes.json
scenes-mobile.json scenes-mobile.json

334
DEBUG_EXAMPLES.md Normal file
View File

@@ -0,0 +1,334 @@
# Debug Output Examples
This document shows examples of the enhanced debug output added to MQTT Explorer's AI Assistant.
## Frontend Debug View
Click the bug icon (🐛) in the AI Assistant header to toggle the debug view.
### Example Debug Output
```json
{
"systemMessage": {
"role": "system",
"content": "You are an expert AI assistant specializing in MQTT (Message Queuing Telemetry Transport) protocol and home/industrial automation systems.\n\n**Your Core Expertise:**\n- MQTT protocol: topics, QoS levels, retained messages, wildcards, last will and testament\n- IoT and smart home ecosystems: devices, sensors, actuators, and controllers\n- Home automation platforms: Home Assistant, openHAB, Node-RED, MQTT brokers, zigbee2mqtt, tasmota\n- Common MQTT topic patterns and naming conventions (e.g., zigbee2mqtt, tasmota, homie)\n- Data formats: JSON payloads, binary data, sensor readings, state messages\n- Time-series data analysis and pattern recognition\n- Troubleshooting connectivity, message delivery, and data quality issues\n\n**Your Communication Style:**\n- Keep your TEXT response CONCISE and practical (2-3 sentences maximum for the explanation)\n- Use clear technical language appropriate for users familiar with MQTT\n- When analyzing data, identify patterns, anomalies, or potential issues quickly\n- Suggest practical next steps or automations when relevant\n- Reference common MQTT ecosystems and standards when applicable\n- NOTE: Proposals and question suggestions are OUTSIDE the sentence limit - always include them when relevant\n...",
"note": "This is the system prompt that provides context to the LLM"
},
"messages": [
{
"index": 0,
"role": "user",
"content": "What does this topic do?",
"fullContent": "Context:\nTopic: home/livingroom/light\nValue: {\"state\":\"ON\",\"brightness\":255}\nRetained: true\n\nRelated Topics (3):\n home/livingroom/thermostat: 21.5\n home/livingroom/motion: false\n home/livingroom/light/set: \n\nMessages: 42\nSubtopics: 3\n\nUser Question: What does this topic do?",
"timestamp": "2026-01-30T13:20:15.123Z",
"proposals": 0,
"questionProposals": 0,
"apiDebug": {
"provider": "openai",
"model": "gpt-5-mini",
"timing": {
"duration_ms": 1234,
"timestamp": "2026-01-30T13:20:15.123Z"
},
"request": {
"url": "https://api.openai.com/v1/chat/completions",
"body": {
"model": "gpt-5-mini",
"messages": [
{
"role": "system",
"content": "You are an expert AI assistant..."
},
{
"role": "user",
"content": "Context:\nTopic: home/livingroom/light\n..."
}
],
"max_completion_tokens": 500
}
},
"response": {
"id": "chatcmpl-AbCdEfGh123456",
"model": "gpt-5-mini",
"created": 1738247815,
"choices": [
{
"index": 0,
"message": {
"role": "assistant",
"content": "This topic represents a smart light in your living room..."
},
"finish_reason": "stop"
}
],
"usage": {
"prompt_tokens": 156,
"completion_tokens": 98,
"total_tokens": 254
},
"system_fingerprint": "fp_abc123def456"
}
}
},
{
"index": 1,
"role": "assistant",
"content": "This topic represents a smart light in your living room...",
"fullContent": "This topic represents a smart light in your living room. It's currently ON at full brightness (255). The topic follows a typical Home Assistant or MQTT smart home pattern.\n\n```proposal\n{\n \"topic\": \"home/livingroom/light/set\",\n \"payload\": \"OFF\",\n \"qos\": 0,\n \"description\": \"Turn off the living room light\"\n}\n```",
"timestamp": "2026-01-30T13:20:16.357Z",
"proposals": 1,
"questionProposals": 2
}
],
"summary": {
"totalMessages": 2,
"messagesWithDebugInfo": 1,
"lastApiCall": "2026-01-30T13:20:15.123Z"
}
}
```
## Server Console Output
### Example Request Log
```
================================================================================
LLM REQUEST (OpenAI)
================================================================================
Provider: openai
Model: gpt-5-mini
Messages Count: 2
Full Request Body:
{
model: 'gpt-5-mini',
messages: [
{
role: 'system',
content: 'You are an expert AI assistant specializing in MQTT (Message Queuing Telemetry Transport) protocol and home/industrial automation systems.\n' +
'\n' +
'**Your Core Expertise:**\n' +
'- MQTT protocol: topics, QoS levels, retained messages, wildcards, last will and testament\n' +
'- IoT and smart home ecosystems: devices, sensors, actuators, and controllers\n' +
'- Home automation platforms: Home Assistant, openHAB, Node-RED, MQTT brokers, zigbee2mqtt, tasmota\n' +
'- Common MQTT topic patterns and naming conventions (e.g., zigbee2mqtt, tasmota, homie)\n' +
'- Data formats: JSON payloads, binary data, sensor readings, state messages\n' +
'- Time-series data analysis and pattern recognition\n' +
'- Troubleshooting connectivity, message delivery, and data quality issues\n' +
'\n' +
'**Your Communication Style:**\n' +
'- Keep your TEXT response CONCISE and practical (2-3 sentences maximum for the explanation)\n' +
'- Use clear technical language appropriate for users familiar with MQTT\n' +
'- When analyzing data, identify patterns, anomalies, or potential issues quickly\n' +
'- Suggest practical next steps or automations when relevant\n' +
'- Reference common MQTT ecosystems and standards when applicable\n' +
'- NOTE: Proposals and question suggestions are OUTSIDE the sentence limit - always include them when relevant\n' +
'...'
},
{
role: 'user',
content: 'Context:\n' +
'Topic: home/livingroom/light\n' +
'Value: {"state":"ON","brightness":255}\n' +
'Retained: true\n' +
'\n' +
'Related Topics (3):\n' +
' home/livingroom/thermostat: 21.5\n' +
' home/livingroom/motion: false\n' +
' home/livingroom/light/set: \n' +
'\n' +
'Messages: 42\n' +
'Subtopics: 3\n' +
'\n' +
'User Question: What does this topic do?'
}
],
max_completion_tokens: 500
}
System Message:
{
role: 'system',
content: 'You are an expert AI assistant specializing in MQTT (Message Queuing Telemetry Transport) protocol and home/industrial automation systems.\n' +
'\n' +
'**Your Core Expertise:**\n' +
'- MQTT protocol: topics, QoS levels, retained messages, wildcards, last will and testament\n' +
'...'
}
================================================================================
```
### Example Response Log
```
================================================================================
LLM RESPONSE (OpenAI)
================================================================================
Duration: 1234 ms
Full Response:
{
id: 'chatcmpl-AbCdEfGh123456',
object: 'chat.completion',
created: 1738247815,
model: 'gpt-5-mini',
choices: [
{
index: 0,
message: {
role: 'assistant',
content: 'This topic represents a smart light in your living room. It\'s currently ON at full brightness (255). The topic follows a typical Home Assistant or MQTT smart home pattern.\n' +
'\n' +
'```proposal\n' +
'{\n' +
' "topic": "home/livingroom/light/set",\n' +
' "payload": "OFF",\n' +
' "qos": 0,\n' +
' "description": "Turn off the living room light"\n' +
'}\n' +
'```\n' +
'\n' +
'```question-proposal\n' +
'{\n' +
' "question": "What other devices are in the living room?",\n' +
' "category": "analysis"\n' +
'}\n' +
'```\n' +
'\n' +
'```question-proposal\n' +
'{\n' +
' "question": "How can I dim the light to 50%?",\n' +
' "category": "control"\n' +
'}\n' +
'```'
},
logprobs: null,
finish_reason: 'stop'
}
],
usage: {
prompt_tokens: 156,
completion_tokens: 98,
total_tokens: 254
},
system_fingerprint: 'fp_abc123def456'
}
================================================================================
================================================================================
LLM RPC HANDLER - Returning response
================================================================================
Response length: 456
Has debugInfo: true
================================================================================
```
### Example Error Log
If an error occurs:
```
================================================================================
LLM RPC ERROR
================================================================================
Error message: Invalid API key configuration
Error stack: Error: Invalid API key configuration
at /home/runner/work/MQTT-Explorer/MQTT-Explorer/dist/src/server.js:642:15
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Full error: Error: Invalid API key configuration
at /home/runner/work/MQTT-Explorer/MQTT-Explorer/dist/src/server.js:642:15 {
status: 401,
type: 'invalid_request_error',
code: 'invalid_api_key'
}
================================================================================
```
## Browser Console Output
### Normal Flow
```javascript
LLM Service: Received result from backend: {
response: "This topic represents a smart light...",
debugInfo: {
provider: "openai",
model: "gpt-5-mini",
timing: { duration_ms: 1234, timestamp: "2026-01-30T13:20:15.123Z" },
request: { url: "...", body: {...} },
response: { id: "chatcmpl-...", usage: {...} }
}
}
LLM Service: Has response: true
LLM Service: Has debugInfo: true
LLM Service: Assistant message length: 456
LLM Service: Debug info: { provider: "openai", model: "gpt-5-mini", ... }
```
### Error Flow
```javascript
LLM Service: Received result from backend: undefined
LLM Service: Has response: false
LLM Service: Has debugInfo: false
LLM Service: Invalid result from backend: undefined
AI Assistant error: Error: No response from AI assistant
at LLMService.sendMessage (llmService.ts:440)
Error details: { message: "No response from AI assistant" }
```
## Key Features
### No Truncation
Notice how the system message and all content is shown in full, without any "..." truncation:
- **Before:** Objects were truncated at depth 2, arrays at 10 items
- **After:** Complete objects shown with `depth: null`, full arrays with `maxArrayLength: null`
### Color Coding
In the terminal, the output is color-coded:
- Strings: Green
- Numbers: Yellow
- Booleans: Yellow
- Null/Undefined: Gray
- Object keys: Cyan
### Visual Separators
Clear visual boundaries between sections:
- `===` lines separate major sections
- Consistent formatting makes scanning easier
- Duration and timing info highlighted
### Complete Context
Every debug output includes:
- **What**: The operation being performed
- **When**: Timestamp and duration
- **How**: Complete request parameters
- **Result**: Complete response data
- **Why** (if error): Full error with stack trace
## Usage Tips
1. **Finding Issues**: Look for the last successful log before error
2. **Performance**: Check `duration_ms` for slow requests
3. **Token Usage**: Monitor `usage.total_tokens` to track costs
4. **Content Issues**: Check `fullContent` to see what was actually sent
5. **System Prompt**: Review `systemMessage` to verify LLM instructions
## Production Considerations
While these logs are comprehensive, in production you may want to:
1. **Add log levels**: Use DEBUG level for detailed logs
2. **Reduce verbosity**: Only log errors in production
3. **Sampling**: Log only 1% of requests for monitoring
4. **Remove colors**: Disable ANSI colors for log aggregation tools
5. **PII filtering**: Redact sensitive data from logs
Current implementation is optimized for development and debugging.

View File

@@ -71,6 +71,39 @@ docker-compose up -d
| `UPGRADE_INSECURE_REQUESTS` | No | `false` | Set to `true` to enable CSP upgrade-insecure-requests directive. **Only use when deployed behind an HTTPS reverse proxy (nginx, Traefik, etc.) with valid SSL certificates.** This upgrades all HTTP requests to HTTPS and will break direct HTTP access. | | `UPGRADE_INSECURE_REQUESTS` | No | `false` | Set to `true` to enable CSP upgrade-insecure-requests directive. **Only use when deployed behind an HTTPS reverse proxy (nginx, Traefik, etc.) with valid SSL certificates.** This upgrades all HTTP requests to HTTPS and will break direct HTTP access. |
| `X_FRAME_OPTIONS` | No | `false` | Set to `true` to enable X-Frame-Options: SAMEORIGIN header to prevent clickjacking. **Disables iframe embedding when enabled.** | | `X_FRAME_OPTIONS` | No | `false` | Set to `true` to enable X-Frame-Options: SAMEORIGIN header to prevent clickjacking. **Disables iframe embedding when enabled.** |
### AI Assistant / LLM Configuration
| Variable | Required | Default | Description |
|----------|----------|---------|-------------|
| `LLM_PROVIDER` | No | `openai` | AI provider to use (`openai` or `gemini`) |
| `OPENAI_API_KEY` | No | - | OpenAI API key for AI Assistant (provider-specific) |
| `GEMINI_API_KEY` | No | - | Google Gemini API key for AI Assistant (provider-specific) |
| `LLM_API_KEY` | No | - | Generic API key for AI Assistant (works with either provider) |
| `LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT` | No | `500` | Token limit for neighboring topics context in AI queries (increased for better device relationship detection) |
**Architecture**: The backend proxies all LLM API requests via WebSocket RPC. API keys are **never** sent to the frontend - only an availability flag is transmitted. The frontend calls the backend via WebSocket RPC (`llm/chat` event), and the backend makes requests to OpenAI/Gemini on behalf of the client.
**Security**:
- ✅ API keys remain server-side only
- ✅ Keys never embedded in client bundles
- ✅ Keys never transmitted to frontend
- ✅ Backend controls all LLM access
- ✅ Communication via secure WebSocket RPC
**Note**: If no LLM environment variables are set, the AI Assistant feature will be completely hidden from users.
**Example with AI Assistant**:
```bash
docker run -d \
-p 3000:3000 \
-e MQTT_EXPLORER_USERNAME=admin \
-e MQTT_EXPLORER_PASSWORD=secret \
-e LLM_PROVIDER=openai \
-e OPENAI_API_KEY=sk-proj-xxxxxxxxxxxxxxxxxxxx \
-e LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=500 \
ghcr.io/thomasnordquist/mqtt-explorer:latest
```
### Authentication Modes ### Authentication Modes
**Standard Mode (Default):** **Standard Mode (Default):**

View File

@@ -22,13 +22,13 @@ export LLM_API_KEY=sk-proj-xxxxxxxxxxxxxxxxxxxx
```bash ```bash
# Configure token limit for neighboring topics context # Configure token limit for neighboring topics context
export LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=100 # Default: 100 tokens export LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=500 # Default: 500 tokens (increased for better device detection)
# Example: Increase token limit for more context # Example: Increase token limit for large home automation setups
export LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=1000
# Example: Decrease token limit to reduce API costs (may reduce proposal quality)
export LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=200 export LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=200
# Example: Decrease token limit to reduce API costs
export LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=50
``` ```
## Complete Example for Server Deployment ## Complete Example for Server Deployment
@@ -45,7 +45,7 @@ export MQTT_AUTO_CONNECT_PORT=1883
# LLM Configuration # LLM Configuration
export LLM_PROVIDER=gemini export LLM_PROVIDER=gemini
export GEMINI_API_KEY=AIzaxxxxxxxxxxxxxxxxxxxx export GEMINI_API_KEY=AIzaxxxxxxxxxxxxxxxxxxxx
export LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=100 export LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=500
# Start the server # Start the server
node dist/src/server.js node dist/src/server.js
@@ -63,7 +63,7 @@ RUN yarn install && yarn build:server
# Environment variables can be set at runtime # Environment variables can be set at runtime
ENV LLM_PROVIDER=openai ENV LLM_PROVIDER=openai
ENV LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=100 ENV LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=500
EXPOSE 3000 EXPOSE 3000
CMD ["node", "dist/src/server.js"] CMD ["node", "dist/src/server.js"]
@@ -74,7 +74,7 @@ CMD ["node", "dist/src/server.js"]
docker run -d \ docker run -d \
-e OPENAI_API_KEY=sk-proj-xxxxxxxxxxxxxxxxxxxx \ -e OPENAI_API_KEY=sk-proj-xxxxxxxxxxxxxxxxxxxx \
-e LLM_PROVIDER=openai \ -e LLM_PROVIDER=openai \
-e LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=100 \ -e LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=500 \
-e MQTT_AUTO_CONNECT_HOST=mqtt.example.com \ -e MQTT_AUTO_CONNECT_HOST=mqtt.example.com \
-p 3000:3000 \ -p 3000:3000 \
mqtt-explorer mqtt-explorer
@@ -82,63 +82,64 @@ docker run -d \
## Context Generation with Token Limits ## Context Generation with Token Limits
The `LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT` controls how many tokens are allocated for neighboring topics in the context. Here's what happens: The `LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT` controls how many tokens are allocated for neighboring topics in the context. The default has been increased from 100 to 500 tokens to provide better device relationship detection and enable multi-device automation proposals.
### With Default 100 Tokens ### With Default 500 Tokens (Recommended)
``` ```
Topic Path: sensors/living_room/temperature Topic Path: home/living_room/light
Value: 22.5 Value: {"state":"ON","brightness":75,"color_temp":350}
Status: Retained Status: Retained
Related Topics (5 shown): Related Topics (18 shown):
humidity: 65 home/living_room: {"scene":"evening"}
pressure: 1013.25 home/living_room/thermostat: {"temperature":22.5,"target":23,"mode":"heat"}
air_quality: {"pm25":12,"pm10":8,"co2":450,"voc":120} home/living_room/motion: true
motion: false home/living_room/humidity: 65
light_level: 450 home/living_room/light/set: (command topic)
home/living_room/light/availability: "online"
home/living_room/light/config: {"transition":0.5,"fade":true}
home/living_room/blinds: {"position":75,"state":"open"}
home/living_room/blinds/set: (command topic)
home/living_room/tv: {"power":"ON","input":"HDMI1"}
home/kitchen/light: {"state":"ON","brightness":100}
home/bedroom/light: {"state":"OFF"}
home/living_room/light/brightness/set: (command topic)
home/living_room/light/color/set: (command topic)
home/living_room/motion_sensor/battery: 95
home/living_room/motion_sensor/last_motion: "2026-01-27T19:45:30Z"
Message Count: 1 Message Count: 42
Subtopics: 0 Subtopics: 5
``` ```
### With 50 Tokens (Reduced) **Benefits:** AI can see full room context (multiple devices), detect controllable devices (set topics), understand device hierarchies (parent/child relationships), and propose coordinated multi-device actions like "turn off all living room devices" or "set evening scene".
### With 200 Tokens (Reduced - May Miss Context)
``` ```
Topic Path: sensors/living_room/temperature Topic Path: home/living_room/light
Value: 22.5 Value: {"state":"ON","brightness":75,"color_temp":350}
Status: Retained
Related Topics (3 shown):
humidity: 65
pressure: 1013.25
air_quality: {"pm25":12,"pm10":8...
Message Count: 1
Subtopics: 0
```
### With 200 Tokens (Increased)
```
Topic Path: sensors/living_room/temperature
Value: 22.5
Status: Retained Status: Retained
Related Topics (8 shown): Related Topics (8 shown):
humidity: 65 home/living_room: {"scene":"evening"}
pressure: 1013.25 home/living_room/thermostat: {"temperature":22.5,"target":23}
air_quality: {"pm25":12,"pm10":8,"co2":450,"voc":120} home/living_room/motion: true
motion: false home/living_room/light/set: (command topic)
light_level: 450 home/living_room/blinds: {"position":75}
battery: 85 home/kitchen/light: {"state":"ON","brightness":100}
signal_strength: -45
last_seen: 2026-01-26T23:45:00Z
Message Count: 1 Message Count: 42
Subtopics: 0 Subtopics: 5
``` ```
**Limitations:** Less context = fewer multi-device proposals, may miss related devices in same room.
### With 1000 Tokens (Maximum - For Large Setups)
Use for extensive home automation with many rooms and devices. Provides comprehensive context including grandchildren, cousins, and extended device relationships.
## Priority Order ## Priority Order
The AI Assistant checks configuration in this order: The AI Assistant checks configuration in this order:
@@ -182,12 +183,18 @@ node -e "console.log(process.env.OPENAI_API_KEY)"
### Token Limit Too Low ### Token Limit Too Low
If you're seeing truncated context: If you're seeing truncated context or poor multi-device proposals:
```bash ```bash
# Increase the token limit # Increase the token limit (recommended: 500-1000 for home automation)
export LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=200 export LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=1000
``` ```
**Note:** The default was increased from 100 to 500 tokens to better support:
- Multi-device detection and relationships
- Hierarchical topic structures (parent → children → grandchildren)
- Room-level automation proposals
- Complex home automation scenarios
### Want to Use UI Configuration ### Want to Use UI Configuration
Simply don't set the environment variables - the UI configuration will be used instead. Simply don't set the environment variables - the UI configuration will be used instead.

View File

@@ -30,18 +30,11 @@ The AI Assistant can help you:
### Setting Up Your API Key ### Setting Up Your API Key
#### Via UI (Browser/Electron) The AI Assistant uses a **backend proxy architecture** for security. API keys are configured server-side only and are never exposed to the frontend.
1. Click the ⚙️ settings icon in the AI Assistant panel #### For Server/Docker Deployments
2. Select your preferred provider (OpenAI or Gemini)
3. Enter your API key
4. Click "Save"
Your API key is stored locally in your browser's localStorage and is never sent to MQTT Explorer's servers. Configure the AI Assistant using environment variables:
#### Via Environment Variables (Server Mode)
For server deployments, you can configure the AI Assistant using environment variables:
```bash ```bash
# Provider selection (optional, defaults to 'openai') # Provider selection (optional, defaults to 'openai')
@@ -52,14 +45,26 @@ export OPENAI_API_KEY=sk-... # For OpenAI
export GEMINI_API_KEY=AIza... # For Gemini export GEMINI_API_KEY=AIza... # For Gemini
export LLM_API_KEY=... # Generic fallback for either provider export LLM_API_KEY=... # Generic fallback for either provider
# Token limit for neighboring topics context (optional, defaults to 100) # Token limit for neighboring topics context (optional, defaults to 500)
export LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=100 # Increased from 100 to 500 for better device relationship and hierarchy detection
export LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=500
# Start the server
node dist/src/server.js
``` ```
**Architecture**:
- Backend reads API keys from environment variables
- Backend proxies all LLM API requests via WebSocket RPC (`llm/chat` event)
- Frontend only receives an availability flag (no credentials)
- API keys never leave the server
- Communication happens over the existing WebSocket connection
**Environment Variable Priority:** **Environment Variable Priority:**
1. Provider-specific keys (`OPENAI_API_KEY`, `GEMINI_API_KEY`) are checked first 1. Provider-specific keys (`OPENAI_API_KEY`, `GEMINI_API_KEY`) are checked first
2. Generic `LLM_API_KEY` is used as fallback 2. Generic `LLM_API_KEY` is used as fallback
3. UI-configured keys in localStorage are used if no environment variables are set
**Note**: If no LLM environment variables are set, the AI Assistant feature will be completely hidden from all users.
### Getting API Keys ### Getting API Keys
@@ -68,7 +73,7 @@ export LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT=100
1. Visit [https://platform.openai.com/api-keys](https://platform.openai.com/api-keys) 1. Visit [https://platform.openai.com/api-keys](https://platform.openai.com/api-keys)
2. Sign up or log in to your OpenAI account 2. Sign up or log in to your OpenAI account
3. Create a new API key 3. Create a new API key
4. Copy the key and paste it into MQTT Explorer's configuration dialog or set `OPENAI_API_KEY` environment variable 4. Set `OPENAI_API_KEY` environment variable on your server
**Note**: Using the AI Assistant will consume OpenAI API credits based on your usage. Please review OpenAI's pricing at [https://openai.com/pricing](https://openai.com/pricing). **Note**: Using the AI Assistant will consume OpenAI API credits based on your usage. Please review OpenAI's pricing at [https://openai.com/pricing](https://openai.com/pricing).
@@ -114,11 +119,11 @@ The AI Assistant provides contextual suggestions based on the selected topic:
The AI Assistant automatically includes relevant context with your questions: The AI Assistant automatically includes relevant context with your questions:
- **Current Topic**: The selected topic path and its current value (with preview for large payloads) - **Current Topic**: The selected topic path and its current value (with preview for large payloads)
- **Neighboring Topics**: Related topics (siblings and children) with their values, limited to 100 tokens by default - **Neighboring Topics**: Related topics with hierarchical context (parent, siblings, children, grandchildren, cousins), limited to 500 tokens by default (increased from 100 for better device relationship detection)
- **Topic Metadata**: Message count, subtopic count, and retained status - **Topic Metadata**: Message count, subtopic count, and retained status
- **Smart Truncation**: Large values and topic lists are intelligently truncated to stay within token limits - **Smart Truncation**: Large values and topic lists are intelligently truncated to stay within token limits
The neighboring topics context can be adjusted using the `LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT` environment variable for server deployments. The neighboring topics context can be adjusted using the `LLM_NEIGHBORING_TOPICS_TOKEN_LIMIT` environment variable. We recommend 500-1000 tokens for production deployments to enable better multi-device and room-level automation proposals.
## Privacy & Security ## Privacy & Security
@@ -141,17 +146,31 @@ The neighboring topics context can be adjusted using the `LLM_NEIGHBORING_TOPICS
- **Frontend**: React component with Material-UI styling - **Frontend**: React component with Material-UI styling
- **Service Layer**: Singleton LLM service for API communication - **Service Layer**: Singleton LLM service for API communication
- **API Integration**: OpenAI Chat Completions API (GPT-3.5-turbo by default) - **API Integration**: OpenAI Chat Completions API (GPT-4o Mini by default)
- **Context Generation**: Automatic extraction of topic metadata for relevant queries - **Context Generation**: Automatic extraction of topic metadata for relevant queries
### Implementation
The AI Assistant uses:
- **OpenAI SDK**: Official `openai` package (v6.16.0) for reliable OpenAI API communication
- Automatic retry logic with exponential backoff
- Built-in timeout handling (30 seconds)
- TypeScript type safety
- Better error messages
- **Axios**: Direct HTTP calls for Gemini API (Google doesn't provide official Node.js SDK)
- **Model**: `gpt-5-mini` (latest OpenAI mini model, 400K context window)
- **Architecture**: Server-side proxy - API keys never sent to browser
### Configuration Options ### Configuration Options
The LLM service supports: The LLM service supports:
- **Custom API Endpoints**: Can be configured to use compatible APIs - **Custom API Endpoints**: Can be configured to use compatible APIs
- **Model Selection**: Defaults to `gpt-3.5-turbo` but can be customized - **Model Selection**: Defaults to `gpt-5-mini` (latest OpenAI mini model)
- **Conversation History**: Automatically manages context (keeps last 10 messages) - **Conversation History**: Automatically manages context (keeps last 10 messages)
- **Timeout Handling**: 30-second timeout for API requests - **Timeout Handling**: 30-second timeout for API requests with automatic retries
- **Debug Mode**: View complete API request and response data via debug button
## Troubleshooting ## Troubleshooting

87
LLM_TESTS_DEBUG.md Normal file
View File

@@ -0,0 +1,87 @@
# LLM Tests Debugging Summary
## GitHub Workflow Issue Fixed ✅
### Problem Identified
The `.github/workflows/copilot-setup-steps.yml` had a critical step ordering issue:
**Before (BROKEN):**
1. Create `.env.llm-tests` file
2. Checkout code ← **This overwrites the directory, losing the .env file!**
3. Run tests
**After (FIXED):**
1. Checkout code
2. Create `.env.llm-tests` file ← **Now persists correctly**
3. Run tests
### Changes Made
- Moved "Persist Secrets to Agent Environment" step AFTER "Checkout code"
- Added `export` prefix to environment variables for proper shell sourcing
- Added `RUN_LLM_TESTS=true` to enable tests automatically
- Added `chmod 600` for security
- Added verification logging to confirm file creation
## Environment Setup Verification
### API Key Sourcing ✅
The `.env.llm-tests` sourcing mechanism works correctly:
```bash
# Create .env file
echo 'export OPENAI_API_KEY=sk-your-key' > .env.llm-tests
echo 'export RUN_LLM_TESTS=true' >> .env.llm-tests
# Source and verify
source .env.llm-tests
echo $OPENAI_API_KEY # Shows the key
```
### Test Detection ✅
When the environment is properly sourced, tests correctly:
- Detect the API key presence
- Enable live test execution (not skipped)
- Show provider detection: "Running LLM integration tests with provider: openai"
### Current Limitation ⚠️
Tests fail in the jsdom environment with network errors:
```
Error: Cross origin null forbidden
Error: LLM API call failed: Network Error
```
This is expected because:
1. Tests run in a jsdom environment (not a real browser)
2. axios HTTP requests fail due to CORS restrictions in jsdom
3. Live API tests need a proper Node.js environment or network mocking
## Recommendations
### For Local Development
Run tests with a real API key in a Node environment:
```bash
source .env.llm-tests
cd app && yarn test
```
### For CI/CD
The workflow now correctly:
1. Checks out the repository first
2. Creates `.env.llm-tests` in the workspace
3. Makes the API key available to subsequent steps
Consider:
1. Running tests in a Node environment (not jsdom)
2. Using nock or msw to mock HTTP requests in tests
3. Running live tests only in scheduled jobs with proper network access
## Verified Working
-`.env.llm-tests` creation via workflow (step order fixed)
-`.env.llm-tests` creation via `setup-llm-env.sh`
- ✅ Environment variable sourcing
- ✅ Test detection of API keys
- ✅ Provider auto-detection (OpenAI/Gemini)
- ✅ Proper skip behavior when no API key
## Status
The infrastructure is now working correctly. The workflow step order has been fixed to ensure `.env.llm-tests` persists after checkout.

View File

@@ -122,6 +122,31 @@ yarn test:backend
yarn test yarn test
``` ```
### LLM Testing
The AI Assistant feature includes comprehensive tests to validate proposal quality and LLM integration.
**Offline tests** (default - no API key needed):
```bash
yarn test:app
```
**Live LLM integration tests** (requires API key):
```bash
# Set your API key
export OPENAI_API_KEY=sk-your-key-here
# Or use Gemini
export GEMINI_API_KEY=your-key-here
# Opt-in to live tests
export RUN_LLM_TESTS=true
# Run tests
yarn test:app
```
For detailed LLM testing documentation, see [app/src/services/spec/README.md](app/src/services/spec/README.md).
### Integration & UI Tests ### Integration & UI Tests
**UI test suite** - Independent, deterministic browser tests: **UI test suite** - Independent, deterministic browser tests:

201
TESTING_WITH_API.md Normal file
View File

@@ -0,0 +1,201 @@
# Quick Reference: Running LLM Tests with OpenAI API
## Prerequisites
✅ OpenAI API key added to GitHub Copilot environment
✅ Test infrastructure installed (100 offline + 11 live tests)
✅ Helper script available: `scripts/run-llm-tests.sh`
## Usage
### Option 1: Use Helper Script (Recommended)
```bash
# If secret is in environment
./scripts/run-llm-tests.sh
# Or provide explicitly
OPENAI_API_KEY=sk-your-key ./scripts/run-llm-tests.sh
```
### Option 2: Manual Execution
```bash
# Set environment variables
export OPENAI_API_KEY=sk-your-key
export RUN_LLM_TESTS=true
# Run tests
cd app && yarn test
```
### Option 3: Single Command
```bash
cd /home/runner/work/MQTT-Explorer/MQTT-Explorer && \
RUN_LLM_TESTS=true \
OPENAI_API_KEY=${OPENAI_API_KEY} \
yarn test:app
```
## Expected Results
### Without Live Tests (Default)
```
100 passing (2s)
11 pending
```
### With Live Tests Enabled
```
LLM Integration Tests (Live API)
Home Automation System Detection
✓ should detect zigbee2mqtt topics (2145ms)
✓ should detect Home Assistant topics (1892ms)
✓ should detect Tasmota topics (1756ms)
Proposal Quality Validation
✓ should propose multiple actions (2234ms)
✓ should provide clear descriptions (1678ms)
✓ should match system formats (1923ms)
Edge Cases
✓ should not propose for sensors (1567ms)
✓ should handle nested topics (1834ms)
✓ should handle special chars (1456ms)
Question Generation
✓ should generate relevant questions (2012ms)
✓ should generate analytical questions (1789ms)
111 passing (22s)
```
## Validation Points
Each live test validates:
**Topic Format**
- Matches system pattern (zigbee2mqtt, homeassistant, etc.)
- No wildcards
- Valid segments
**Payload Quality**
- Valid JSON (when appropriate)
- Correct format for target system
- No injection attempts
**QoS Value**
- Must be 0, 1, or 2
- Typically 0 for home automation
**Description**
- Actionable (uses imperative verbs)
- Clear and concise
- Under 100 characters
## Troubleshooting
### Secret Not Available
If you get "No API key found":
```bash
# Check environment
env | grep OPENAI_API_KEY
# If not set, the secret may need to be:
# 1. Refreshed in the Copilot environment
# 2. Made available to the runtime
# 3. Accessed through a different mechanism
```
### Tests Still Pending
If live tests don't run:
```bash
# Ensure flag is set
export RUN_LLM_TESTS=true
echo $RUN_LLM_TESTS # Should output: true
# Check for API key
[ -n "$OPENAI_API_KEY" ] && echo "Key is set" || echo "Key not found"
```
## What Gets Tested
### Home Automation Systems
**zigbee2mqtt:**
```typescript
// Expected proposal
{
topic: "zigbee2mqtt/light/set",
payload: '{"state": "ON"}',
qos: 0,
description: "Turn on the light"
}
```
**Home Assistant:**
```typescript
{
topic: "homeassistant/light/lamp/set",
payload: "ON",
qos: 0,
description: "Turn on the lamp"
}
```
**Tasmota:**
```typescript
{
topic: "cmnd/device/POWER",
payload: "ON",
qos: 0,
description: "Turn on the device"
}
```
### Question Generation
For a topic like `zigbee2mqtt/bedroom_light`:
```typescript
// Expected questions
[
"How can I turn this light on?",
"What brightness levels are supported?",
"Can I adjust the color?",
"How do I automate this light?"
]
```
## Cost Estimate
Per full test run:
- **API Calls:** ~11 requests
- **Tokens:** ~5,000-8,000 total
- **Cost:** ~$0.001-0.002 USD (GPT-4o Mini is ~10x cheaper than GPT-3.5 Turbo)
## Documentation
- **Test Strategy:** `app/src/services/spec/README.md`
- **Test Results:** `docs/LLM_TEST_RESULTS.md`
- **Helper Script:** `scripts/run-llm-tests.sh`
## Success Criteria
When tests pass, you'll have validated:
✅ AI can detect home automation systems correctly
✅ Generated proposals have valid MQTT topic format
✅ Payloads match system-specific requirements
✅ Descriptions are clear and actionable
✅ Questions are relevant and diverse
✅ No security issues (injection, size limits)
---
**Ready to test?** Run: `./scripts/run-llm-tests.sh`

11013
app/package-lock.json generated Normal file

File diff suppressed because it is too large Load Diff

View File

@@ -15,94 +15,95 @@
"author": "", "author": "",
"license": "CC-BY-SA-4.0", "license": "CC-BY-SA-4.0",
"dependencies": { "dependencies": {
"@emotion/react": "^11.14.0", "@emotion/react": "11.14.0",
"@emotion/styled": "^11.14.1", "@emotion/styled": "11.14.1",
"@mui/icons-material": "^7.3.6", "@mui/icons-material": "7.3.6",
"@mui/lab": "^7.0.1-beta.20", "@mui/lab": "7.0.1-beta.20",
"@mui/material": "^7.3.6", "@mui/material": "7.3.6",
"@mui/styles": "^6.4.8", "@mui/styles": "6.4.8",
"@react-spring/web": "^9.7.5", "@react-spring/web": "9.7.5",
"@types/react-transition-group": "^4.4.11", "@types/dompurify": "^3.0.5",
"@visx/axis": "^3.10.1", "@types/react-transition-group": "4.4.11",
"@visx/grid": "^3.5.0", "@visx/axis": "3.10.1",
"@visx/tooltip": "^3.3.0", "@visx/grid": "3.5.0",
"@visx/xychart": "^3.10.2", "@visx/tooltip": "3.3.0",
"ace-builds": "^1.4.11", "@visx/xychart": "3.10.2",
"axios": "^1.13.2", "ace-builds": "1.4.11",
"compare-versions": "^6.1.1", "axios": "^1.16.0",
"copy-text-to-clipboard": "^3.2.0", "compare-versions": "6.1.1",
"d3": "^7.9.0", "copy-text-to-clipboard": "3.2.0",
"d3-shape": "^3.2.0", "d3": "7.9.0",
"diff": "^8.0.3", "d3-shape": "3.2.0",
"dot-prop": "^5.3.0", "diff": "8.0.3",
"events": "^3.3.0", "dompurify": "^3.4.2",
"get-value": "^3.0.1", "dot-prop": "5.3.0",
"immutable": "^4.3.7", "events": "3.3.0",
"in-viewport": "^3.6.0", "get-value": "3.0.1",
"js-base64": "^3.7.8", "immutable": "^4.3.8",
"json-to-ast": "^2.1.0", "in-viewport": "3.6.0",
"lodash.debounce": "^4.0.8", "js-base64": "3.7.8",
"lodash.throttle": "^4.1.1", "json-to-ast": "2.1.0",
"moving-average": "^1.0.0", "lodash.debounce": "4.0.8",
"number-abbreviate": "^2.0.0", "lodash.throttle": "4.1.1",
"os-browserify": "^0.3.0", "moving-average": "1.0.0",
"parse-duration": "^0.1.1", "number-abbreviate": "2.0.0",
"path-browserify": "^1.0.1", "os-browserify": "0.3.0",
"prismjs": "^1.29.0", "parse-duration": "^2.1.6",
"react": "^19.2.3", "path-browserify": "1.0.1",
"react-ace": "^14.0.1", "prismjs": "^1.30.0",
"react-dom": "^19.2.3", "react": "19.2.3",
"react-redux": "^9.2.0", "react-ace": "14.0.1",
"react-resize-detector": "^11.0.1", "react-dom": "19.2.3",
"react-split-pane": "^0.1.92", "react-redux": "9.2.0",
"react-transition-group": "^4.4.5", "react-resize-detector": "11.0.1",
"redux": "^5.0.1", "react-split-pane": "0.1.92",
"redux-batched-actions": "^0.5.0", "react-transition-group": "4.4.5",
"redux-thunk": "^3.1.0", "redux": "5.0.1",
"sha1": "^1.1.1", "redux-batched-actions": "0.5.0",
"socket.io-client": "^4.8.1", "redux-thunk": "3.1.0",
"url": "^0.11.4", "sha1": "1.1.1",
"uuid": "^11.0.0" "socket.io-client": "4.8.1",
"url": "0.11.4",
"uuid": "^11.1.1"
}, },
"devDependencies": { "devDependencies": {
"@babel/runtime": "^7.28.4", "@babel/runtime": "7.28.4",
"@reduxjs/toolkit": "2.5.0", "@reduxjs/toolkit": "2.5.0",
"@testing-library/dom": "10.4.0", "@testing-library/dom": "10.4.0",
"@testing-library/react": "16.1.0", "@testing-library/react": "16.1.0",
"@testing-library/user-event": "14.5.2", "@testing-library/user-event": "14.5.2",
"@types/d3": "^7.4.3", "@types/d3": "7.4.3",
"@types/diff": "^7.0.0", "@types/diff": "7.0.0",
"@types/get-value": "^3.0.5", "@types/get-value": "3.0.5",
"@types/lodash.debounce": "^4.0.9", "@types/lodash.debounce": "4.0.9",
"@types/node": "^25.0.3", "@types/node": "25.0.3",
"@types/prismjs": "^1.26.5", "@types/prismjs": "1.26.5",
"@types/react": "^19.2.7", "@types/react": "19.2.7",
"@types/react-dom": "^19.2.3", "@types/react-dom": "19.2.3",
"@types/react-redux": "^7.1.34", "@types/react-redux": "7.1.34",
"@types/react-resize-detector": "^4.0.3", "@types/sha1": "1.1.1",
"@types/sha1": "^1.1.1", "@types/socket.io-client": "3.0.0",
"@types/socket.io-client": "^3.0.0", "@types/uuid": "11.0.0",
"@types/uuid": "^11.0.0", "@types/vis": "4.21.24",
"@types/vis": "^4.21.24", "chai": "4.5.0",
"chai": "^4.5.0", "cross-env": "7.0.3",
"cross-env": "^7.0.3", "css-loader": "7.1.2",
"css-loader": "^7.1.2", "file-loader": "6.2.0",
"file-loader": "^6.2.0", "html-webpack-plugin": "5.6.3",
"html-webpack-plugin": "^5.6.3",
"jsdom": "25.0.1", "jsdom": "25.0.1",
"jsdom-global": "3.0.2", "jsdom-global": "3.0.2",
"lodash": "^4.17.23", "lodash": "^4.18.1",
"mocha": "^10.8.2", "mocha": "^11.7.5",
"moment": "^2.30.1", "moment": "2.30.1",
"node-loader": "^2.0.0", "node-loader": "2.0.0",
"source-map-loader": "^5.0.0", "source-map-loader": "5.0.0",
"style-loader": "^4.0.0", "style-loader": "4.0.0",
"ts-loader": "^9.5.1", "ts-loader": "9.5.1",
"typescript": "^5.9.3", "typescript": "5.9.3",
"webpack": "^5.98.0", "webpack": "^5.106.2",
"webpack-bundle-analyzer": "^4.10.2", "webpack-bundle-analyzer": "4.10.2",
"webpack-cli": "^6.0.1", "webpack-cli": "6.0.1",
"webpack-dev-server": "^5.2.0" "webpack-dev-server": "^5.2.3"
}, },
"peerDependencies": { "peerDependencies": {
"electron": "^39" "electron": "^39"

View File

@@ -1,7 +1,7 @@
import { Dispatch } from 'redux'
import { Action, ActionTypes, ChartParameters } from '../reducers/Charts' import { Action, ActionTypes, ChartParameters } from '../reducers/Charts'
import { AppState } from '../reducers' import { AppState } from '../reducers'
import { default as persistentStorage, StorageIdentifier } from '../utils/PersistentStorage' import { default as persistentStorage, StorageIdentifier } from '../utils/PersistentStorage'
import { Dispatch } from 'redux'
import { showError, showNotification } from './Global' import { showError, showNotification } from './Global'
interface ConnectionViewState { interface ConnectionViewState {
@@ -16,7 +16,7 @@ const connectionViewStateIdentifier: StorageIdentifier<ConnectionViewStateDictio
} }
export const loadCharts = () => async (dispatch: Dispatch<any>, getState: () => AppState) => { export const loadCharts = () => async (dispatch: Dispatch<any>, getState: () => AppState) => {
const connectionId = getState().connection.connectionId const { connectionId } = getState().connection
if (!connectionId) { if (!connectionId) {
return return
} }
@@ -40,7 +40,7 @@ export const loadCharts = () => async (dispatch: Dispatch<any>, getState: () =>
} }
export const saveCharts = () => async (dispatch: Dispatch<any>, getState: () => AppState) => { export const saveCharts = () => async (dispatch: Dispatch<any>, getState: () => AppState) => {
const connectionId = getState().connection.connectionId const { connectionId } = getState().connection
if (!connectionId) { if (!connectionId) {
return return
} }
@@ -110,9 +110,7 @@ export const moveChartUp =
dispatch(saveCharts()) dispatch(saveCharts())
} }
export const setCharts = (charts: Array<ChartParameters>): Action => { export const setCharts = (charts: Array<ChartParameters>): Action => ({
return { charts,
charts, type: ActionTypes.CHARTS_SET,
type: ActionTypes.CHARTS_SET, })
}
}

View File

@@ -1,10 +1,10 @@
import * as q from '../../../backend/src/Model'
import * as url from 'url' import * as url from 'url'
import { DataSourceState, MqttOptions } from 'mqtt-explorer-backend/src/DataSource/DataSource'
import { Dispatch } from 'redux'
import * as q from '../../../backend/src/Model'
import { Action, ActionTypes } from '../reducers/Connection' import { Action, ActionTypes } from '../reducers/Connection'
import { ActionTypes as SettingsActionTypes } from '../reducers/Settings' import { ActionTypes as SettingsActionTypes } from '../reducers/Settings'
import { AppState } from '../reducers' import { AppState } from '../reducers'
import { DataSourceState, MqttOptions } from '../../../backend/src/DataSource'
import { Dispatch } from 'redux'
import { globalActions } from '.' import { globalActions } from '.'
import { resetStore as resetTreeStore, showTree } from './Tree' import { resetStore as resetTreeStore, showTree } from './Tree'
import { showError } from './Global' import { showError } from './Global'

View File

@@ -1,3 +1,7 @@
import { Dispatch } from 'redux'
import * as path from 'path'
import { Subscription } from 'mqtt-explorer-backend/src/DataSource/MqttSource'
import { makeOpenDialogRpc } from '../../../events/OpenDialogRequest'
import { AppState } from '../reducers' import { AppState } from '../reducers'
import { clearLegacyConnectionOptions, loadLegacyConnectionOptions } from '../model/LegacyConnectionSettings' import { clearLegacyConnectionOptions, loadLegacyConnectionOptions } from '../model/LegacyConnectionSettings'
import { import {
@@ -7,14 +11,10 @@ import {
CertificateParameters, CertificateParameters,
} from '../model/ConnectionOptions' } from '../model/ConnectionOptions'
import { default as persistentStorage, StorageIdentifier } from '../utils/PersistentStorage' import { default as persistentStorage, StorageIdentifier } from '../utils/PersistentStorage'
import { Dispatch } from 'redux'
import { showError } from './Global' import { showError } from './Global'
import * as path from 'path'
import { ActionTypes, Action } from '../reducers/ConnectionManager' import { ActionTypes, Action } from '../reducers/ConnectionManager'
import { Subscription } from '../../../backend/src/DataSource/MqttSource'
import { connectionsMigrator } from './migrations/Connection' import { connectionsMigrator } from './migrations/Connection'
import { rendererRpc, readFromFile } from '../eventBus' import { rendererRpc, readFromFile } from '../eventBus'
import { makeOpenDialogRpc } from '../../../events/OpenDialogRequest'
export interface ConnectionDictionary { export interface ConnectionDictionary {
[s: string]: ConnectionOptions [s: string]: ConnectionOptions

View File

@@ -1,5 +1,5 @@
import { ActionTypes, ConfirmationRequest } from '../reducers/Global'
import { Dispatch } from 'redux' import { Dispatch } from 'redux'
import { ActionTypes, ConfirmationRequest } from '../reducers/Global'
export const showError = (error?: string | unknown) => ({ export const showError = (error?: string | unknown) => ({
error, error,
@@ -27,8 +27,8 @@ export const toggleAboutDialogVisibility = () => (dispatch: Dispatch<any>) => {
}) })
} }
export const requestConfirmation = (title: string, inquiry: string) => (dispatch: Dispatch<any>) => { export const requestConfirmation = (title: string, inquiry: string) => (dispatch: Dispatch<any>) =>
return new Promise(resolve => { new Promise(resolve => {
const confirmationRequest = { const confirmationRequest = {
title, title,
inquiry, inquiry,
@@ -43,13 +43,11 @@ export const requestConfirmation = (title: string, inquiry: string) => (dispatch
type: ActionTypes.requestConfirmation, type: ActionTypes.requestConfirmation,
}) })
}) })
}
export const removeConfirmationRequest = (confirmationRequest: ConfirmationRequest) => (dispatch: Dispatch<any>) => { export const removeConfirmationRequest = (confirmationRequest: ConfirmationRequest) => (dispatch: Dispatch<any>) =>
return new Promise((resolve, reject) => { new Promise((resolve, reject) => {
dispatch({ dispatch({
confirmationRequest, confirmationRequest,
type: ActionTypes.removeConfirmationRequest, type: ActionTypes.removeConfirmationRequest,
}) })
}) })
}

View File

@@ -1,18 +1,16 @@
import { Dispatch } from 'redux'
import { makeOpenDialogRpc } from '../../../events/OpenDialogRequest'
import { Base64 } from 'js-base64'
import { Base64Message } from '../../../backend/src/Model/Base64Message'
import { Action, ActionTypes } from '../reducers/Publish' import { Action, ActionTypes } from '../reducers/Publish'
import { AppState } from '../reducers' import { AppState } from '../reducers'
import { Base64Message } from '../../../backend/src/Model/Base64Message'
import { Dispatch } from 'redux'
import { MqttMessage, makePublishEvent, rendererEvents, rendererRpc, readFromFile } from '../eventBus' import { MqttMessage, makePublishEvent, rendererEvents, rendererRpc, readFromFile } from '../eventBus'
import { makeOpenDialogRpc } from '../../../events/OpenDialogRequest'
import { showError } from './Global' import { showError } from './Global'
import { Base64 } from 'js-base64'
export const setTopic = (topic?: string): Action => { export const setTopic = (topic?: string): Action => ({
return { topic,
topic, type: ActionTypes.PUBLISH_SET_TOPIC,
type: ActionTypes.PUBLISH_SET_TOPIC, })
}
}
export const openFile = export const openFile =
(encoding: BufferEncoding = 'utf8') => (encoding: BufferEncoding = 'utf8') =>
@@ -58,26 +56,20 @@ async function getFileContent(encoding: BufferEncoding): Promise<FileParameters
} }
} }
export const setPayload = (payload?: string): Action => { export const setPayload = (payload?: string): Action => ({
return { payload,
payload, type: ActionTypes.PUBLISH_SET_PAYLOAD,
type: ActionTypes.PUBLISH_SET_PAYLOAD, })
}
}
export const setQoS = (qos: 0 | 1 | 2): Action => { export const setQoS = (qos: 0 | 1 | 2): Action => ({
return { qos,
qos, type: ActionTypes.PUBLISH_SET_QOS,
type: ActionTypes.PUBLISH_SET_QOS, })
}
}
export const setEditorMode = (editorMode: string): Action => { export const setEditorMode = (editorMode: string): Action => ({
return { editorMode,
editorMode, type: ActionTypes.PUBLISH_SET_EDITOR_MODE,
type: ActionTypes.PUBLISH_SET_EDITOR_MODE, })
}
}
export const publish = (connectionId: string) => (dispatch: Dispatch<Action>, getState: () => AppState) => { export const publish = (connectionId: string) => (dispatch: Dispatch<Action>, getState: () => AppState) => {
const state = getState() const state = getState()
@@ -97,8 +89,6 @@ export const publish = (connectionId: string) => (dispatch: Dispatch<Action>, ge
rendererEvents.emit(publishEvent, mqttMessage) rendererEvents.emit(publishEvent, mqttMessage)
} }
export const toggleRetain = (): Action => { export const toggleRetain = (): Action => ({
return { type: ActionTypes.PUBLISH_TOGGLE_RETAIN,
type: ActionTypes.PUBLISH_TOGGLE_RETAIN, })
}
}

View File

@@ -1,12 +1,12 @@
import { batchActions } from 'redux-batched-actions'
import { Dispatch } from 'redux'
import * as q from '../../../backend/src/Model' import * as q from '../../../backend/src/Model'
import { Base64Message } from '../../../backend/src/Model/Base64Message'
import { ActionTypes, SettingsStateModel, TopicOrder, ValueRendererDisplayMode } from '../reducers/Settings' import { ActionTypes, SettingsStateModel, TopicOrder, ValueRendererDisplayMode } from '../reducers/Settings'
import { AppState } from '../reducers' import { AppState } from '../reducers'
import { autoExpandLimitSet } from '../components/SettingsDrawer/Settings' import { autoExpandLimitSet } from '../components/SettingsDrawer/Settings'
import { Base64Message } from '../../../backend/src/Model/Base64Message'
import { batchActions } from 'redux-batched-actions'
import { default as persistentStorage, StorageIdentifier } from '../utils/PersistentStorage' import { default as persistentStorage, StorageIdentifier } from '../utils/PersistentStorage'
import { Dispatch } from 'redux' import { globalActions } from '.'
import { globalActions } from './'
import { showError } from './Global' import { showError } from './Global'
import { showTree } from './Tree' import { showTree } from './Tree'
import { TopicViewModel } from '../model/TopicViewModel' import { TopicViewModel } from '../model/TopicViewModel'

View File

@@ -1,7 +1,7 @@
import { Dispatch } from 'redux'
import * as q from '../../../backend/src/Model' import * as q from '../../../backend/src/Model'
import { ActionTypes } from '../reducers/Sidebar' import { ActionTypes } from '../reducers/Sidebar'
import { AppState } from '../reducers' import { AppState } from '../reducers'
import { Dispatch } from 'redux'
import { clearTopic } from './clearTopic' import { clearTopic } from './clearTopic'
export { clearTopic } from './clearTopic' export { clearTopic } from './clearTopic'

View File

@@ -1,13 +1,14 @@
import { AnyAction, Dispatch } from 'redux'
import { batchActions } from 'redux-batched-actions'
import debounce from 'lodash.debounce'
import * as q from '../../../backend/src/Model' import * as q from '../../../backend/src/Model'
import { ActionTypes } from '../reducers/Tree' import { ActionTypes } from '../reducers/Tree'
import { ActionTypes as SidebarActionTypes } from '../reducers/Sidebar' import { ActionTypes as SidebarActionTypes } from '../reducers/Sidebar'
import { AnyAction, Dispatch } from 'redux'
import { AppState } from '../reducers' import { AppState } from '../reducers'
import { batchActions } from 'redux-batched-actions' import { globalActions } from '.'
import { globalActions } from './'
import { setTopic } from './Publish' import { setTopic } from './Publish'
import { TopicViewModel } from '../model/TopicViewModel' import { TopicViewModel } from '../model/TopicViewModel'
import debounce from 'lodash.debounce'
export { clearTopic } from './clearTopic' export { clearTopic } from './clearTopic'
export { moveSelectionUpOrDownwards, moveInward, moveOutward } from './visibleTreeTraversal' export { moveSelectionUpOrDownwards, moveInward, moveOutward } from './visibleTreeTraversal'

View File

@@ -1,15 +1,11 @@
import { ActionTypes, GlobalAction } from '../reducers/Global' import { ActionTypes, GlobalAction } from '../reducers/Global'
export const showUpdateNotification = (show: boolean): GlobalAction => { export const showUpdateNotification = (show: boolean): GlobalAction => ({
return { type: ActionTypes.showUpdateNotification,
type: ActionTypes.showUpdateNotification, showUpdateNotification: show,
showUpdateNotification: show, })
}
}
export const showUpdateDetails = (show: boolean): GlobalAction => { export const showUpdateDetails = (show: boolean): GlobalAction => ({
return { type: ActionTypes.showUpdateDetails,
type: ActionTypes.showUpdateDetails, showUpdateDetails: show,
showUpdateDetails: show, })
}
}

View File

@@ -1,6 +1,6 @@
import { Dispatch } from 'redux'
import * as q from '../../../backend/src/Model' import * as q from '../../../backend/src/Model'
import { AppState } from '../reducers' import { AppState } from '../reducers'
import { Dispatch } from 'redux'
import { makePublishEvent, rendererEvents } from '../eventBus' import { makePublishEvent, rendererEvents } from '../eventBus'
import { moveSelectionUpOrDownwards } from './visibleTreeTraversal' import { moveSelectionUpOrDownwards } from './visibleTreeTraversal'
import { globalActions } from '.' import { globalActions } from '.'
@@ -45,7 +45,7 @@ export const clearTopic =
topic: path, topic: path,
payload: null, payload: null,
retain: true, retain: true,
qos: 0 as 0, qos: 0 as const,
messageId: undefined, messageId: undefined,
} }
// Rate limit deletion // Rate limit deletion

View File

@@ -21,7 +21,7 @@ export interface ConnectionOptionsV0 {
subscriptions: Array<string> subscriptions: Array<string>
} }
let migrations: Migration[] = [ const migrations: Migration[] = [
// iot.eclipse.org ha moved to mqtt.eclipse.org // iot.eclipse.org ha moved to mqtt.eclipse.org
{ {
from: undefined, from: undefined,
@@ -60,13 +60,11 @@ let migrations: Migration[] = [
// Added QoS level to subscription options // Added QoS level to subscription options
{ {
from: undefined, from: undefined,
apply: (connection: ConnectionOptionsV0): ConnectionOptions => { apply: (connection: ConnectionOptionsV0): ConnectionOptions => ({
return { ...connection,
...connection, configVersion: 1,
configVersion: 1, subscriptions: connection.subscriptions.map(topic => ({ topic, qos: 0 })),
subscriptions: connection.subscriptions.map(topic => ({ topic, qos: 0 })), }),
}
},
}, },
] ]
@@ -79,9 +77,9 @@ function isMigrationNecessary(connections: ConnectionDictionary): boolean {
} }
function applyMigrations(connections: ConnectionDictionary): ConnectionDictionary { function applyMigrations(connections: ConnectionDictionary): ConnectionDictionary {
let newConnectionDictionary: ConnectionDictionary = {} const newConnectionDictionary: ConnectionDictionary = {}
Object.keys(connections).forEach(key => { Object.keys(connections).forEach(key => {
let newConnection = connectionMigrator.applyMigrations(connections[key]) as any const newConnection = connectionMigrator.applyMigrations(connections[key]) as any
newConnectionDictionary[newConnection.id] = newConnection newConnectionDictionary[newConnection.id] = newConnection
}) })

View File

@@ -1,6 +1,6 @@
import { Dispatch } from 'redux'
import * as q from '../../../backend/src/Model' import * as q from '../../../backend/src/Model'
import { AppState } from '../reducers' import { AppState } from '../reducers'
import { Dispatch } from 'redux'
import { selectTopic } from './Tree' import { selectTopic } from './Tree'
import { SettingsState } from '../reducers/Settings' import { SettingsState } from '../reducers/Settings'
import { sortedNodes } from '../sortedNodes' import { sortedNodes } from '../sortedNodes'
@@ -69,9 +69,8 @@ function nextVisibleElementInTree(
): q.TreeNode<TopicViewModel> | undefined { ): q.TreeNode<TopicViewModel> | undefined {
if (direction === 'next') { if (direction === 'next') {
return findNextNodeDownward(settings, node) return findNextNodeDownward(settings, node)
} else {
return findNextNodeUpward(settings, node)
} }
return findNextNodeUpward(settings, node)
} }
/** Not very efficient but easy to implement, complexity should not be an issue here */ /** Not very efficient but easy to implement, complexity should not be an issue here */
@@ -92,9 +91,8 @@ function findNextNodeUpward(
const upwardNeighbor = neighborNodes[nodeIdx - 1] const upwardNeighbor = neighborNodes[nodeIdx - 1]
if (upwardNeighbor) { if (upwardNeighbor) {
return lastVisibleChild(settings, upwardNeighbor) return lastVisibleChild(settings, upwardNeighbor)
} else {
return findNextNodeUpward(settings, parent)
} }
return findNextNodeUpward(settings, parent)
} }
function lastVisibleChild(settings: SettingsState, treeNode: q.TreeNode<TopicViewModel>): q.TreeNode<TopicViewModel> { function lastVisibleChild(settings: SettingsState, treeNode: q.TreeNode<TopicViewModel>): q.TreeNode<TopicViewModel> {
@@ -132,7 +130,6 @@ function findNextNodeDownwardNeighbor(
const downwardNeighbor = neighborNodes[nodeIdx + 1] const downwardNeighbor = neighborNodes[nodeIdx + 1]
if (downwardNeighbor) { if (downwardNeighbor) {
return downwardNeighbor return downwardNeighbor
} else {
return findNextNodeDownwardNeighbor(settings, parent)
} }
return findNextNodeDownwardNeighbor(settings, parent)
} }

View File

@@ -1,13 +1,13 @@
// Auto-connect handler for browser mode // Auto-connect handler for browser mode
// This file is loaded early in the app initialization to handle server-initiated auto-connect // This file is loaded early in the app initialization to handle server-initiated auto-connect
import { store } from './store'
import * as q from '../../backend/src/Model' import * as q from '../../backend/src/Model'
import { DataSourceState } from 'mqtt-explorer-backend/src/DataSource/DataSource'
import { store } from './store'
import { TopicViewModel } from './model/TopicViewModel' import { TopicViewModel } from './model/TopicViewModel'
import { showTree } from './actions/Tree' import { showTree } from './actions/Tree'
import { connecting, connected } from './actions/Connection' import { connecting, connected } from './actions/Connection'
import { makeConnectionStateEvent, rendererEvents } from './eventBus' import { makeConnectionStateEvent, rendererEvents } from './eventBus'
import { DataSourceState } from '../../backend/src/DataSource'
// Listen for auto-connect-initiated event from server // Listen for auto-connect-initiated event from server
if (typeof window !== 'undefined') { if (typeof window !== 'undefined') {

View File

@@ -4,15 +4,33 @@ import io, { Socket } from 'socket.io-client'
import { SocketIOClientEventBus } from '../../events/EventSystem/SocketIOClientEventBus' import { SocketIOClientEventBus } from '../../events/EventSystem/SocketIOClientEventBus'
import { Rpc } from '../../events/EventSystem/Rpc' import { Rpc } from '../../events/EventSystem/Rpc'
// Get auth from sessionStorage or use empty (will show login dialog) // Use memory-based storage for credentials (more secure than sessionStorage)
let username = typeof sessionStorage !== 'undefined' ? sessionStorage.getItem('mqtt-explorer-username') || '' : '' // Credentials are cleared after successful authentication
let password = typeof sessionStorage !== 'undefined' ? sessionStorage.getItem('mqtt-explorer-password') || '' : '' let authCredentials = {
username: '',
password: ''
}
// Try to load credentials from sessionStorage only for initial load
if (typeof sessionStorage !== 'undefined') {
authCredentials.username = sessionStorage.getItem('mqtt-explorer-username') || ''
authCredentials.password = sessionStorage.getItem('mqtt-explorer-password') || ''
}
// Function to clear sensitive credentials from storage
function clearStoredCredentials() {
authCredentials = { username: '', password: '' }
if (typeof sessionStorage !== 'undefined') {
sessionStorage.removeItem('mqtt-explorer-username')
sessionStorage.removeItem('mqtt-explorer-password')
}
}
// Connect to the server (same origin in browser mode) // Connect to the server (same origin in browser mode)
const socket: Socket = io({ const socket: Socket = io({
auth: { auth: {
username, username: authCredentials.username,
password, password: authCredentials.password,
}, },
reconnection: true, reconnection: true,
reconnectionDelay: 1000, reconnectionDelay: 1000,
@@ -23,13 +41,15 @@ const socket: Socket = io({
}) })
// Handle connection errors // Handle connection errors
socket.on('connect_error', (error) => { socket.on('connect_error', error => {
console.error('Socket connection error:', error.message) console.error('Socket connection error:', error.message)
// Check if it's an authentication error // Check if it's an authentication error
if (error.message.includes('Invalid credentials') || if (
error.message.includes('Authentication required') || error.message.includes('Invalid credentials') ||
error.message.includes('Too many')) { error.message.includes('Authentication required') ||
error.message.includes('Too many')
) {
// Clear invalid credentials from sessionStorage // Clear invalid credentials from sessionStorage
if (typeof sessionStorage !== 'undefined') { if (typeof sessionStorage !== 'undefined') {
sessionStorage.removeItem('mqtt-explorer-username') sessionStorage.removeItem('mqtt-explorer-username')
@@ -38,25 +58,32 @@ socket.on('connect_error', (error) => {
// Dispatch custom event that BrowserAuthWrapper can listen to // Dispatch custom event that BrowserAuthWrapper can listen to
if (typeof window !== 'undefined') { if (typeof window !== 'undefined') {
window.dispatchEvent(new CustomEvent('mqtt-auth-error', { window.dispatchEvent(
detail: { message: error.message } new CustomEvent('mqtt-auth-error', {
})) detail: { message: error.message },
})
)
} }
} }
}) })
socket.on('disconnect', (reason) => { socket.on('disconnect', reason => {
console.log('Socket disconnected:', reason) console.log('Socket disconnected:', reason)
}) })
socket.on('connect', () => { socket.on('connect', () => {
console.log('Socket connected successfully') console.log('Socket connected successfully')
// Clear stored credentials after successful authentication for security
clearStoredCredentials()
// Dispatch custom event that BrowserAuthWrapper can listen to // Dispatch custom event that BrowserAuthWrapper can listen to
if (typeof window !== 'undefined') { if (typeof window !== 'undefined') {
window.dispatchEvent(new CustomEvent('mqtt-auth-success', { window.dispatchEvent(
detail: { message: 'Authentication successful' } new CustomEvent('mqtt-auth-success', {
})) detail: { message: 'Authentication successful' },
})
)
} }
}) })
@@ -66,9 +93,28 @@ socket.on('auth-status', (data: { authDisabled: boolean }) => {
// Dispatch custom event with auth status // Dispatch custom event with auth status
if (typeof window !== 'undefined') { if (typeof window !== 'undefined') {
window.dispatchEvent(new CustomEvent('mqtt-auth-status', { window.dispatchEvent(
detail: { authDisabled: data.authDisabled } new CustomEvent('mqtt-auth-status', {
})) detail: { authDisabled: data.authDisabled },
})
)
}
})
// Listen for ui-config from server (sent on connection)
socket.on('ui-config', (data: { hidePublishPane: boolean }) => {
console.log('UI config received from server:', data)
// Store in global for easy access
if (typeof window !== 'undefined') {
;(window as any).mqttExplorerUiConfig = data
// Dispatch custom event for components to listen
window.dispatchEvent(
new CustomEvent('mqtt-ui-config', {
detail: data,
})
)
} }
}) })
@@ -78,9 +124,11 @@ socket.on('auto-connect-config', (config: any) => {
// Dispatch custom event with auto-connect config // Dispatch custom event with auto-connect config
if (typeof window !== 'undefined') { if (typeof window !== 'undefined') {
window.dispatchEvent(new CustomEvent('mqtt-auto-connect-config', { window.dispatchEvent(
detail: config new CustomEvent('mqtt-auto-connect-config', {
})) detail: config,
})
)
} }
}) })
@@ -90,9 +138,28 @@ socket.on('auto-connect-initiated', (data: { connectionId: string }) => {
// Dispatch custom event to trigger connection flow // Dispatch custom event to trigger connection flow
if (typeof window !== 'undefined') { if (typeof window !== 'undefined') {
window.dispatchEvent(new CustomEvent('mqtt-auto-connect-initiated', { window.dispatchEvent(
detail: data new CustomEvent('mqtt-auto-connect-initiated', {
})) detail: data,
})
)
}
})
// Listen for LLM availability from server (new architecture)
socket.on('llm-available', (data: { available: boolean }) => {
console.log('LLM availability received from server:', data.available)
// Store availability flag in window object
if (typeof window !== 'undefined') {
window.__llmAvailable = data.available
// Dispatch custom event for components to react
window.dispatchEvent(
new CustomEvent('llm-availability-changed', {
detail: { available: data.available },
})
)
} }
}) })

View File

@@ -52,8 +52,8 @@ describe('AboutDialog License Compliance', () => {
if (!hasAuthor) { if (!hasAuthor) {
throw new Error( throw new Error(
'LICENSE VIOLATION: Author attribution "Thomas Nordquist" is missing. ' + 'LICENSE VIOLATION: Author attribution "Thomas Nordquist" is missing. ' +
'This violates the CC-BY-ND-4.0 Attribution (BY) requirement. ' + 'This violates the CC-BY-ND-4.0 Attribution (BY) requirement. ' +
'The author must be properly credited in the About dialog.' 'The author must be properly credited in the About dialog.'
) )
} }
@@ -67,8 +67,8 @@ describe('AboutDialog License Compliance', () => {
if (!hasLicense) { if (!hasLicense) {
throw new Error( throw new Error(
'LICENSE VIOLATION: License notice "CC-BY-ND-4.0" is missing. ' + 'LICENSE VIOLATION: License notice "CC-BY-ND-4.0" is missing. ' +
'This violates CC-BY-ND-4.0 license notice requirements. ' + 'This violates CC-BY-ND-4.0 license notice requirements. ' +
'The license identifier must be displayed in the About dialog.' 'The license identifier must be displayed in the About dialog.'
) )
} }
@@ -82,8 +82,8 @@ describe('AboutDialog License Compliance', () => {
if (!hasLicenseNotice) { if (!hasLicenseNotice) {
throw new Error( throw new Error(
'LICENSE VIOLATION: LICENSE NOTICE comment is missing from source code. ' + 'LICENSE VIOLATION: LICENSE NOTICE comment is missing from source code. ' +
'This violates CC-BY-ND-4.0 source code attribution requirements. ' + 'This violates CC-BY-ND-4.0 source code attribution requirements. ' +
'The LICENSE NOTICE comment must be retained in the component source.' 'The LICENSE NOTICE comment must be retained in the component source.'
) )
} }

View File

@@ -11,8 +11,8 @@ import {
Box, Box,
Divider, Divider,
} from '@mui/material' } from '@mui/material'
import { rendererRpc, getAppVersion } from '../../../events'
import FavoriteIcon from '@mui/icons-material/Favorite' import FavoriteIcon from '@mui/icons-material/Favorite'
import { rendererRpc, getAppVersion } from '../eventBus'
// Fallback version if RPC call fails (e.g., in browser mode during initialization) // Fallback version if RPC call fails (e.g., in browser mode during initialization)
const FALLBACK_VERSION = '0.4.0-beta.5' const FALLBACK_VERSION = '0.4.0-beta.5'
@@ -71,12 +71,31 @@ export function AboutDialog(props: AboutDialogProps) {
<Divider sx={{ my: 2 }} /> <Divider sx={{ my: 2 }} />
<Box sx={{ display: 'flex', alignItems: 'center', gap: 2, mb: 2 }} data-testid="about-author"> <Typography variant="h6" gutterBottom>
<Avatar Privacy & Security
src="https://github.com/thomasnordquist.png" </Typography>
alt="Thomas Nordquist" <Typography variant="body2" gutterBottom sx={{ mb: 1 }}>
sx={{ width: 56, height: 56 }} <strong>Data Collection:</strong> MQTT Explorer does not collect or transmit personal data to external servers, except when using optional LLM features.
/> </Typography>
<Typography variant="body2" gutterBottom sx={{ mb: 1 }}>
<strong>LLM Integration:</strong> When enabled, topic names and message content may be sent to OpenAI or Google Gemini APIs for AI assistance. This data is processed according to their respective privacy policies.
</Typography>
<Typography variant="body2" gutterBottom sx={{ mb: 2 }}>
<strong>Local Storage:</strong> Connection settings and credentials are stored locally in your browser. Authentication credentials are cleared after successful login for security.
</Typography>
<Divider sx={{ my: 2 }} />
<Box
sx={{
display: 'flex',
alignItems: 'center',
gap: 2,
mb: 2,
}}
data-testid="about-author"
>
<Avatar src="https://github.com/thomasnordquist.png" alt="Thomas Nordquist" sx={{ width: 56, height: 56 }} />
<Box> <Box>
<Typography variant="subtitle1" sx={{ fontWeight: 500 }}> <Typography variant="subtitle1" sx={{ fontWeight: 500 }}>
Thomas Nordquist Thomas Nordquist

View File

@@ -1,19 +1,19 @@
import CssBaseline from '@mui/material/CssBaseline'
import React from 'react'
import { bindActionCreators } from 'redux'
import { connect } from 'react-redux'
import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles'
import ConfirmationDialog from './ConfirmationDialog' import ConfirmationDialog from './ConfirmationDialog'
import ConnectionSetup from './ConnectionSetup/ConnectionSetup' import ConnectionSetup from './ConnectionSetup/ConnectionSetup'
import CssBaseline from '@mui/material/CssBaseline'
import ErrorBoundary from './ErrorBoundary' import ErrorBoundary from './ErrorBoundary'
import Notification from './Layout/Notification' import Notification from './Layout/Notification'
import React from 'react'
import TitleBar from './Layout/TitleBar' import TitleBar from './Layout/TitleBar'
import UpdateNotifier from './UpdateNotifier' import UpdateNotifier from './UpdateNotifier'
import { AboutDialog } from './AboutDialog' import { AboutDialog } from './AboutDialog'
import { AppState } from '../reducers' import { AppState } from '../reducers'
import { bindActionCreators } from 'redux'
import { ConfirmationRequest } from '../reducers/Global' import { ConfirmationRequest } from '../reducers/Global'
import { connect } from 'react-redux'
import { globalActions, settingsActions } from '../actions' import { globalActions, settingsActions } from '../actions'
import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles'
;(window as any).global = window ;(window as any).global = window
const Settings = React.lazy(() => import('./SettingsDrawer/Settings')) const Settings = React.lazy(() => import('./SettingsDrawer/Settings'))
@@ -82,7 +82,7 @@ class App extends React.PureComponent<Props, {}> {
onClose={() => this.props.actions.toggleAboutDialogVisibility()} onClose={() => this.props.actions.toggleAboutDialogVisibility()}
/> />
{this.renderNotification()} {this.renderNotification()}
<React.Suspense fallback={<div></div>}> <React.Suspense fallback={<div />}>
<Settings {...anyProps} /> <Settings {...anyProps} />
</React.Suspense> </React.Suspense>
<div className={centerContent}> <div className={centerContent}>
@@ -90,7 +90,7 @@ class App extends React.PureComponent<Props, {}> {
<TitleBar /> <TitleBar />
</div> </div>
<div className={settingsVisible ? contentShift : content}> <div className={settingsVisible ? contentShift : content}>
<React.Suspense fallback={<div></div>}> <React.Suspense fallback={<div />}>
<ContentView <ContentView
heightProperty={heightProperty} heightProperty={heightProperty}
connectionId={this.props.connectionId} connectionId={this.props.connectionId}
@@ -121,12 +121,12 @@ const styles = (theme: Theme) => {
paneDefaults: { paneDefaults: {
backgroundColor: theme.palette.background.default, backgroundColor: theme.palette.background.default,
color: theme.palette.text.primary, color: theme.palette.text.primary,
display: 'block' as 'block', display: 'block' as const,
height: 'calc(100vh - 64px)', height: 'calc(100vh - 64px)',
}, },
centerContent: { centerContent: {
width: '100vw', width: '100vw',
overflow: 'hidden' as 'hidden', overflow: 'hidden' as const,
}, },
content: { content: {
...contentBaseStyle, ...contentBaseStyle,
@@ -148,24 +148,20 @@ const styles = (theme: Theme) => {
} }
} }
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: bindActionCreators(globalActions, dispatch),
actions: bindActionCreators(globalActions, dispatch), settingsActions: bindActionCreators(settingsActions, dispatch),
settingsActions: bindActionCreators(settingsActions, dispatch), })
}
}
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => ({
return { settingsVisible: state.globalState.get('settingsVisible'),
settingsVisible: state.globalState.get('settingsVisible'), connectionId: state.connection.connectionId,
connectionId: state.connection.connectionId, error: state.globalState.get('error'),
error: state.globalState.get('error'), notification: state.globalState.get('notification'),
notification: state.globalState.get('notification'), highlightTopicUpdates: state.settings.get('highlightTopicUpdates'),
highlightTopicUpdates: state.settings.get('highlightTopicUpdates'), launching: state.globalState.get('launching'),
launching: state.globalState.get('launching'), confirmationRequests: state.globalState.get('confirmationRequests'),
confirmationRequests: state.globalState.get('confirmationRequests'), aboutDialogVisible: state.globalState.get('aboutDialogVisible'),
aboutDialogVisible: state.globalState.get('aboutDialogVisible'), })
}
}
export default withStyles(styles)(connect(mapStateToProps, mapDispatchToProps)(App)) export default withStyles(styles)(connect(mapStateToProps, mapDispatchToProps)(App))

View File

@@ -11,7 +11,7 @@ describe('Chart X-Axis Domain Investigation', () => {
{ x: now - 3000, y: 21 }, { x: now - 3000, y: 21 },
{ x: now - 2000, y: 22 }, { x: now - 2000, y: 22 },
{ x: now - 1000, y: 23 }, { x: now - 1000, y: 23 },
{ x: now, y: 24 } { x: now, y: 24 },
] ]
const { container } = renderWithProviders(<Chart data={data} />) const { container } = renderWithProviders(<Chart data={data} />)
@@ -33,7 +33,9 @@ describe('Chart X-Axis Domain Investigation', () => {
console.log('\n========== X-AXIS DOMAIN INVESTIGATION ==========') console.log('\n========== X-AXIS DOMAIN INVESTIGATION ==========')
console.log('Data X values (timestamps):') console.log('Data X values (timestamps):')
data.forEach((d, i) => console.log(` Point ${i}: ${d.x} (${new Date(d.x).toISOString()})`)) data.forEach((d, i) => console.log(` Point ${i}: ${d.x} (${new Date(d.x).toISOString()})`))
console.log(`\nData X range: ${data[data.length - 1].x - data[0].x}ms (${(data[data.length - 1].x - data[0].x) / 1000}s)`) console.log(
`\nData X range: ${data[data.length - 1].x - data[0].x}ms (${(data[data.length - 1].x - data[0].x) / 1000}s)`
)
console.log('\nRendered circle CX positions:') console.log('\nRendered circle CX positions:')
cxValues.forEach((cx, i) => console.log(` Circle ${i}: cx=${cx.toFixed(2)}px`)) cxValues.forEach((cx, i) => console.log(` Circle ${i}: cx=${cx.toFixed(2)}px`))
@@ -51,7 +53,7 @@ describe('Chart X-Axis Domain Investigation', () => {
spacings.push(cxValues[i] - cxValues[i - 1]) spacings.push(cxValues[i] - cxValues[i - 1])
} }
console.log('\nSpacing between consecutive points:') console.log('\nSpacing between consecutive points:')
spacings.forEach((s, i) => console.log(` ${i} to ${i+1}: ${s.toFixed(2)}px`)) spacings.forEach((s, i) => console.log(` ${i} to ${i + 1}: ${s.toFixed(2)}px`))
const avgSpacing = spacings.reduce((a, b) => a + b, 0) / spacings.length const avgSpacing = spacings.reduce((a, b) => a + b, 0) / spacings.length
console.log(`Average spacing: ${avgSpacing.toFixed(2)}px`) console.log(`Average spacing: ${avgSpacing.toFixed(2)}px`)
@@ -63,15 +65,16 @@ describe('Chart X-Axis Domain Investigation', () => {
// 2. Points should be in ascending order (left to right) // 2. Points should be in ascending order (left to right)
for (let i = 1; i < cxValues.length; i++) { for (let i = 1; i < cxValues.length; i++) {
expect(cxValues[i]).to.be.greaterThan(cxValues[i - 1], expect(cxValues[i]).to.be.greaterThan(
`Point ${i} (cx=${cxValues[i]}) should be to the right of point ${i-1} (cx=${cxValues[i-1]})`) cxValues[i - 1],
`Point ${i} (cx=${cxValues[i]}) should be to the right of point ${i - 1} (cx=${cxValues[i - 1]})`
)
} }
// 3. Spacing should be relatively uniform (since data points are equally spaced in time) // 3. Spacing should be relatively uniform (since data points are equally spaced in time)
const spacingVariance = spacings.map(s => Math.abs(s - avgSpacing)) const spacingVariance = spacings.map(s => Math.abs(s - avgSpacing))
const maxVariance = Math.max(...spacingVariance) const maxVariance = Math.max(...spacingVariance)
expect(maxVariance).to.be.lessThan(avgSpacing * 0.5, expect(maxVariance).to.be.lessThan(avgSpacing * 0.5, 'Spacing between points should be relatively uniform')
'Spacing between points should be relatively uniform')
}) })
it('should handle points bunched at far right correctly', () => { it('should handle points bunched at far right correctly', () => {
@@ -82,7 +85,7 @@ describe('Chart X-Axis Domain Investigation', () => {
{ x: largeTimestamp + 1000, y: 21 }, { x: largeTimestamp + 1000, y: 21 },
{ x: largeTimestamp + 2000, y: 22 }, { x: largeTimestamp + 2000, y: 22 },
{ x: largeTimestamp + 3000, y: 23 }, { x: largeTimestamp + 3000, y: 23 },
{ x: largeTimestamp + 4000, y: 24 } { x: largeTimestamp + 4000, y: 24 },
] ]
const { container } = renderWithProviders(<Chart data={data} />) const { container } = renderWithProviders(<Chart data={data} />)
@@ -97,8 +100,14 @@ describe('Chart X-Axis Domain Investigation', () => {
}) })
console.log('\n========== LARGE TIMESTAMP TEST ==========') console.log('\n========== LARGE TIMESTAMP TEST ==========')
console.log('Data X values:', data.map(d => d.x)) console.log(
console.log('Rendered CX values:', cxValues.map(v => v.toFixed(2))) 'Data X values:',
data.map(d => d.x)
)
console.log(
'Rendered CX values:',
cxValues.map(v => v.toFixed(2))
)
const minCx = Math.min(...cxValues) const minCx = Math.min(...cxValues)
const maxCx = Math.max(...cxValues) const maxCx = Math.max(...cxValues)
@@ -106,7 +115,6 @@ describe('Chart X-Axis Domain Investigation', () => {
console.log('==========================================\n') console.log('==========================================\n')
// Points should still be spread out even with large timestamps // Points should still be spread out even with large timestamps
expect(maxCx - minCx).to.be.greaterThan(50, expect(maxCx - minCx).to.be.greaterThan(50, 'Points with large timestamps should still be spread across the chart')
'Points with large timestamps should still be spread across the chart')
}) })
}) })

View File

@@ -92,7 +92,7 @@ describe('Chart Component', () => {
const { container } = renderWithProviders(<Chart data={data} />, { withTheme: true }) const { container } = renderWithProviders(<Chart data={data} />, { withTheme: true })
const circles = container.querySelectorAll('circle') const circles = container.querySelectorAll('circle')
circles.forEach((circle) => { circles.forEach(circle => {
const cx = parseFloat(circle.getAttribute('cx') || '0') const cx = parseFloat(circle.getAttribute('cx') || '0')
const cy = parseFloat(circle.getAttribute('cy') || '0') const cy = parseFloat(circle.getAttribute('cy') || '0')
@@ -139,13 +139,12 @@ describe('Chart Component', () => {
describe('Curve Interpolation', () => { describe('Curve Interpolation', () => {
const curveTypes: PlotCurveTypes[] = ['curve', 'linear', 'cubic_basis_spline', 'step_after', 'step_before'] const curveTypes: PlotCurveTypes[] = ['curve', 'linear', 'cubic_basis_spline', 'step_after', 'step_before']
curveTypes.forEach((interpolation) => { curveTypes.forEach(interpolation => {
it(`should render with ${interpolation} interpolation`, () => { it(`should render with ${interpolation} interpolation`, () => {
const data = createMockChartData(5) const data = createMockChartData(5)
const { container } = renderWithProviders( const { container } = renderWithProviders(<Chart data={data} interpolation={interpolation} />, {
<Chart data={data} interpolation={interpolation} />, withTheme: true,
{ withTheme: true } })
)
expect(container.querySelector('svg')).to.exist expect(container.querySelector('svg')).to.exist
const paths = container.querySelectorAll('path') const paths = container.querySelectorAll('path')
@@ -158,10 +157,7 @@ describe('Chart Component', () => {
it('should apply custom color', () => { it('should apply custom color', () => {
const data = createMockChartData(5) const data = createMockChartData(5)
const customColor = '#ff0000' const customColor = '#ff0000'
const { container } = renderWithProviders( const { container } = renderWithProviders(<Chart data={data} color={customColor} />, { withTheme: true })
<Chart data={data} color={customColor} />,
{ withTheme: true }
)
// Check if custom color is applied to line or glyphs // Check if custom color is applied to line or glyphs
const svg = container.querySelector('svg') const svg = container.querySelector('svg')
@@ -180,10 +176,7 @@ describe('Chart Component', () => {
it('should render with custom Y range', () => { it('should render with custom Y range', () => {
const data = createMockChartData(5) const data = createMockChartData(5)
const range: [number, number] = [0, 100] const range: [number, number] = [0, 100]
const { container } = renderWithProviders( const { container } = renderWithProviders(<Chart data={data} range={range} />, { withTheme: true })
<Chart data={data} range={range} />,
{ withTheme: true }
)
expect(container.querySelector('svg')).to.exist expect(container.querySelector('svg')).to.exist
}) })
@@ -191,10 +184,9 @@ describe('Chart Component', () => {
it('should render with custom time range', () => { it('should render with custom time range', () => {
const data = createMockChartData(5) const data = createMockChartData(5)
const timeRangeStart = 60000 // 1 minute const timeRangeStart = 60000 // 1 minute
const { container } = renderWithProviders( const { container } = renderWithProviders(<Chart data={data} timeRangeStart={timeRangeStart} />, {
<Chart data={data} timeRangeStart={timeRangeStart} />, withTheme: true,
{ withTheme: true } })
)
expect(container.querySelector('svg')).to.exist expect(container.querySelector('svg')).to.exist
}) })
@@ -202,10 +194,7 @@ describe('Chart Component', () => {
it('should render with partial Y range (only min)', () => { it('should render with partial Y range (only min)', () => {
const data = createMockChartData(5) const data = createMockChartData(5)
const range: [number?, number?] = [0, undefined] const range: [number?, number?] = [0, undefined]
const { container } = renderWithProviders( const { container } = renderWithProviders(<Chart data={data} range={range} />, { withTheme: true })
<Chart data={data} range={range} />,
{ withTheme: true }
)
expect(container.querySelector('svg')).to.exist expect(container.querySelector('svg')).to.exist
}) })
@@ -213,10 +202,7 @@ describe('Chart Component', () => {
it('should render with partial Y range (only max)', () => { it('should render with partial Y range (only max)', () => {
const data = createMockChartData(5) const data = createMockChartData(5)
const range: [number?, number?] = [undefined, 100] const range: [number?, number?] = [undefined, 100]
const { container } = renderWithProviders( const { container } = renderWithProviders(<Chart data={data} range={range} />, { withTheme: true })
<Chart data={data} range={range} />,
{ withTheme: true }
)
expect(container.querySelector('svg')).to.exist expect(container.querySelector('svg')).to.exist
}) })
@@ -250,7 +236,7 @@ describe('Chart Component', () => {
// At least one text element should contain time format (e.g., contains ":") // At least one text element should contain time format (e.g., contains ":")
let hasTimeFormat = false let hasTimeFormat = false
texts.forEach((text) => { texts.forEach(text => {
if (text.textContent && text.textContent.includes(':')) { if (text.textContent && text.textContent.includes(':')) {
hasTimeFormat = true hasTimeFormat = true
} }
@@ -392,10 +378,7 @@ describe('Chart Component', () => {
}) })
it('should handle rapid data updates', () => { it('should handle rapid data updates', () => {
const { rerender, container } = renderWithProviders( const { rerender, container } = renderWithProviders(<Chart data={createMockChartData(5)} />, { withTheme: true })
<Chart data={createMockChartData(5)} />,
{ withTheme: true }
)
// Simulate rapid updates // Simulate rapid updates
for (let i = 0; i < 10; i++) { for (let i = 0; i < 10; i++) {
@@ -410,10 +393,7 @@ describe('Chart Component', () => {
it('should dynamically update when data points are added', () => { it('should dynamically update when data points are added', () => {
// Start with 3 data points // Start with 3 data points
const initialData = createMockChartData(3) const initialData = createMockChartData(3)
const { rerender, container } = renderWithProviders( const { rerender, container } = renderWithProviders(<Chart data={initialData} />, { withTheme: true })
<Chart data={initialData} />,
{ withTheme: true }
)
// Verify initial state: should have 3 data points // Verify initial state: should have 3 data points
const initialCircles = container.querySelectorAll('circle') const initialCircles = container.querySelectorAll('circle')
@@ -471,10 +451,7 @@ describe('Chart Component', () => {
it('should handle data point removal', () => { it('should handle data point removal', () => {
// Start with 5 data points // Start with 5 data points
const initialData = createMockChartData(5) const initialData = createMockChartData(5)
const { rerender, container } = renderWithProviders( const { rerender, container } = renderWithProviders(<Chart data={initialData} />, { withTheme: true })
<Chart data={initialData} />,
{ withTheme: true }
)
// Verify initial state // Verify initial state
let circles = container.querySelectorAll('circle') let circles = container.querySelectorAll('circle')
@@ -491,10 +468,7 @@ describe('Chart Component', () => {
it('should maintain chart structure during data updates', () => { it('should maintain chart structure during data updates', () => {
const initialData = createMockChartData(3) const initialData = createMockChartData(3)
const { rerender, container } = renderWithProviders( const { rerender, container } = renderWithProviders(<Chart data={initialData} />, { withTheme: true })
<Chart data={initialData} />,
{ withTheme: true }
)
// Verify chart structure exists initially // Verify chart structure exists initially
expect(container.querySelector('svg')).to.exist expect(container.querySelector('svg')).to.exist

View File

@@ -1,16 +1,17 @@
import React, { memo, useCallback, useMemo } from 'react'
import { useResizeDetector } from 'react-resize-detector'
import { emphasize, useTheme } from '@mui/material/styles'
import { XYChart, Axis, Grid, LineSeries, GlyphSeries } from '@visx/xychart'
import DateFormatter from '../helper/DateFormatter' import DateFormatter from '../helper/DateFormatter'
import NoData from './NoData' import NoData from './NoData'
import NumberFormatter from '../helper/NumberFormatter' import NumberFormatter from '../helper/NumberFormatter'
import React, { memo, useCallback, useMemo } from 'react'
import TooltipComponent from './TooltipComponent' import TooltipComponent from './TooltipComponent'
import { useResizeDetector } from 'react-resize-detector'
import { emphasize, useTheme } from '@mui/material/styles'
import { mapCurveType } from './mapCurveType' import { mapCurveType } from './mapCurveType'
import { PlotCurveTypes } from '../../reducers/Charts' import { PlotCurveTypes } from '../../reducers/Charts'
import { Point, Tooltip } from './Model' import { Point, Tooltip } from './Model'
import { useCustomXDomain } from './effects/useCustomXDomain' import { useCustomXDomain } from './effects/useCustomXDomain'
import { useCustomYDomain } from './effects/useCustomYDomain' import { useCustomYDomain } from './effects/useCustomYDomain'
import { XYChart, Axis, Grid, LineSeries, GlyphSeries } from '@visx/xychart'
const abbreviate = require('number-abbreviate') const abbreviate = require('number-abbreviate')
export interface Props { export interface Props {
@@ -32,7 +33,7 @@ export default memo((props: Props) => {
const hintFormatter = React.useCallback( const hintFormatter = React.useCallback(
(point: any) => [ (point: any) => [
{ title: <b>Time</b>, value: <DateFormatter timeFirst={true} date={new Date(point.x)} /> }, { title: <b>Time</b>, value: <DateFormatter timeFirst date={new Date(point.x)} /> },
{ title: <b>Value</b>, value: <NumberFormatter value={point.y} /> }, { title: <b>Value</b>, value: <NumberFormatter value={point.y} /> },
{ title: <b>Raw</b>, value: <span>{point.y}</span> }, { title: <b>Raw</b>, value: <span>{point.y}</span> },
], ],
@@ -55,8 +56,7 @@ export default memo((props: Props) => {
[hintFormatter] [hintFormatter]
) )
const paletteColor = const paletteColor = theme.palette.mode === 'light' ? theme.palette.secondary.dark : theme.palette.primary.light
theme.palette.mode === 'light' ? theme.palette.secondary.dark : theme.palette.primary.light
const color = props.color ? props.color : paletteColor const color = props.color ? props.color : paletteColor
const highlightSelectedPoint = useCallback( const highlightSelectedPoint = useCallback(
@@ -80,7 +80,7 @@ export default memo((props: Props) => {
const xDomain = useCustomXDomain(props) const xDomain = useCustomXDomain(props)
const yDomain = useCustomYDomain(props) const yDomain = useCustomYDomain(props)
const data = props.data const { data } = props
const hasData = data.length > 0 const hasData = data.length > 0
const dummyDomain: [number, number] = [-1, 1] const dummyDomain: [number, number] = [-1, 1]
const dummyData = [{ x: -2, y: -2 }] const dummyData = [{ x: -2, y: -2 }]
@@ -101,12 +101,17 @@ export default memo((props: Props) => {
<XYChart <XYChart
width={width || 300} width={width || 300}
height={CHART_HEIGHT} height={CHART_HEIGHT}
margin={{ top: 10, right: 10, bottom: 30, left: 50 }} margin={{
top: 10,
right: 10,
bottom: 30,
left: 50,
}}
xScale={{ type: 'time', domain: xDomain || dummyDomain }} xScale={{ type: 'time', domain: xDomain || dummyDomain }}
yScale={{ type: 'linear', domain: hasData ? yDomain : dummyDomain }} yScale={{ type: 'linear', domain: hasData ? yDomain : dummyDomain }}
onPointerOut={onMouseLeave} onPointerOut={onMouseLeave}
> >
<Grid rows={true} columns={false} stroke={theme.palette.divider} strokeOpacity={0.3} /> <Grid rows columns={false} stroke={theme.palette.divider} strokeOpacity={0.3} />
<Axis <Axis
orientation="left" orientation="left"
numTicks={5} numTicks={5}
@@ -131,7 +136,7 @@ export default memo((props: Props) => {
stroke={color} stroke={color}
strokeWidth={2} strokeWidth={2}
curve={mapCurveType(props.interpolation)} curve={mapCurveType(props.interpolation)}
onPointerMove={(datum) => { onPointerMove={datum => {
if (datum && datum.datum) { if (datum && datum.datum) {
const point = datum.datum as Point const point = datum.datum as Point
showTooltip(point) showTooltip(point)
@@ -143,17 +148,10 @@ export default memo((props: Props) => {
data={hasData ? data : dummyData} data={hasData ? data : dummyData}
xAccessor={accessors.xAccessor} xAccessor={accessors.xAccessor}
yAccessor={accessors.yAccessor} yAccessor={accessors.yAccessor}
renderGlyph={(glyphProps) => { renderGlyph={glyphProps => {
const point = glyphProps.datum as Point const point = glyphProps.datum as Point
const pointColor = highlightSelectedPoint(point) const pointColor = highlightSelectedPoint(point)
return ( return <circle cx={glyphProps.x} cy={glyphProps.y} r={3} fill={pointColor} />
<circle
cx={glyphProps.x}
cy={glyphProps.y}
r={3}
fill={pointColor}
/>
)
}} }}
/> />
</XYChart> </XYChart>

View File

@@ -8,9 +8,9 @@ function TooltipComponent(props: { tooltip?: Tooltip }) {
const { tooltip } = props const { tooltip } = props
return ( return (
<Popper <Popper
style={Boolean(tooltip) ? { transition: 'all 0.1s ease-out' } : undefined} style={tooltip ? { transition: 'all 0.1s ease-out' } : undefined}
open={Boolean(tooltip)} open={Boolean(tooltip)}
transition={true} transition
placement="top" placement="top"
anchorEl={tooltip && tooltip.element} anchorEl={tooltip && tooltip.element}
> >
@@ -27,9 +27,7 @@ function TooltipComponent(props: { tooltip?: Tooltip }) {
padding: '4px', padding: '4px',
marginTop: '-12px', marginTop: '-12px',
backgroundColor: fade( backgroundColor: fade(
theme.palette.mode === 'light' theme.palette.mode === 'light' ? theme.palette.background.paper : theme.palette.background.default,
? theme.palette.background.paper
: theme.palette.background.default,
0.7 0.7
), ),
}} }}

View File

@@ -13,12 +13,11 @@ export function useCustomXDomain(props: Props): [number, number] | undefined {
if (props.timeRangeStart) { if (props.timeRangeStart) {
// Custom time range mode // Custom time range mode
return [Date.now() - props.timeRangeStart, lastDataDate] return [Date.now() - props.timeRangeStart, lastDataDate]
} else {
// Auto-calculate from data (like react-vis did)
const xValues = props.data.map(d => d.x)
const minX = Math.min(...xValues)
const maxX = Math.max(...xValues)
return [minX, maxX]
} }
// Auto-calculate from data (like react-vis did)
const xValues = props.data.map(d => d.x)
const minX = Math.min(...xValues)
const maxX = Math.max(...xValues)
return [minX, maxX]
}, [props.data, props.timeRangeStart]) }, [props.data, props.timeRangeStart])
} }

View File

@@ -1,5 +1,5 @@
import { Props } from '../Chart'
import { useMemo } from 'react' import { useMemo } from 'react'
import { Props } from '../Chart'
import { Point } from '../Model' import { Point } from '../Model'
function defaultFor(a: number | undefined, b: number) { function defaultFor(a: number | undefined, b: number) {
@@ -8,7 +8,7 @@ function defaultFor(a: number | undefined, b: number) {
export function useCustomYDomain(props: Props) { export function useCustomYDomain(props: Props) {
return useMemo(() => { return useMemo(() => {
const data = props.data const { data } = props
const calculatedDomain = domainForData(data) const calculatedDomain = domainForData(data)
const yDomain: [number, number] = props.range const yDomain: [number, number] = props.range
? [defaultFor(props.range[0], calculatedDomain[0]), defaultFor(props.range[1], calculatedDomain[1])] ? [defaultFor(props.range[0], calculatedDomain[0]), defaultFor(props.range[1], calculatedDomain[1])]

View File

@@ -1,5 +1,5 @@
import { PlotCurveTypes } from '../../reducers/Charts'
import * as d3Shape from 'd3-shape' import * as d3Shape from 'd3-shape'
import { PlotCurveTypes } from '../../reducers/Charts'
export function mapCurveType(type: PlotCurveTypes | undefined) { export function mapCurveType(type: PlotCurveTypes | undefined) {
switch (type) { switch (type) {

View File

@@ -1,9 +1,9 @@
import React, { memo } from 'react' import React, { memo } from 'react'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { chartActions } from '../../../actions'
import { ChartParameters } from '../../../reducers/Charts'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { Menu, MenuItem } from '@mui/material' import { Menu, MenuItem } from '@mui/material'
import { chartActions } from '../../../actions'
import { ChartParameters } from '../../../reducers/Charts'
import { colors as createColors } from './colors' import { colors as createColors } from './colors'
function chartParametersForColor(chart: ChartParameters, color?: string) { function chartParametersForColor(chart: ChartParameters, color?: string) {
@@ -30,17 +30,24 @@ function ColorSettings(props: {
[props.chart] [props.chart]
) )
const menuItems = React.useMemo(() => { const menuItems = React.useMemo(
return colors.map(color => ( () =>
<MenuItem colors.map(color => (
style={{ minWidth: '8em', minHeight: '36px', backgroundColor: color, textAlign: 'center' }} <MenuItem
key={color} style={{
onClick={() => setColor(color)} minWidth: '8em',
> minHeight: '36px',
{props.chart.color === color ? 'X' : ''} backgroundColor: color,
</MenuItem> textAlign: 'center',
)) }}
}, [colors, props.chart]) key={color}
onClick={() => setColor(color)}
>
{props.chart.color === color ? 'X' : ''}
</MenuItem>
)),
[colors, props.chart]
)
return ( return (
<Menu anchorEl={props.anchorEl} open={props.open} onClose={props.close}> <Menu anchorEl={props.anchorEl} open={props.open} onClose={props.close}>
@@ -57,12 +64,10 @@ function ColorSettings(props: {
) )
} }
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { chart: bindActionCreators(chartActions, dispatch),
chart: bindActionCreators(chartActions, dispatch), },
}, })
}
}
export default connect(undefined, mapDispatchToProps)(memo(ColorSettings)) export default connect(undefined, mapDispatchToProps)(memo(ColorSettings))

View File

@@ -1,10 +1,10 @@
import * as React from 'react' import * as React from 'react'
import { AppState } from '../../../reducers'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { chartActions } from '../../../actions'
import { ChartParameters, PlotCurveTypes } from '../../../reducers/Charts'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { Menu, MenuItem, Typography } from '@mui/material' import { Menu, MenuItem, Typography } from '@mui/material'
import { AppState } from '../../../reducers'
import { chartActions } from '../../../actions'
import { ChartParameters, PlotCurveTypes } from '../../../reducers/Charts'
function chartParametersForAction(chart: ChartParameters, action: string) { function chartParametersForAction(chart: ChartParameters, action: string) {
return { return {
@@ -37,18 +37,20 @@ function InterpolationSettings(props: {
return callbacks return callbacks
}, [curves]) }, [curves])
const menuItems = React.useMemo(() => { const menuItems = React.useMemo(
return curves.map(curve => ( () =>
<MenuItem curves.map(curve => (
key={curve} <MenuItem
onClick={callbacks[curve]} key={curve}
selected={props.chart.interpolation === curve} onClick={callbacks[curve]}
data-menu-item={curve.replace(/_/g, ' ')} selected={props.chart.interpolation === curve}
> data-menu-item={curve.replace(/_/g, ' ')}
<Typography variant="inherit">{curve.replace(/_/g, ' ')}</Typography> >
</MenuItem> <Typography variant="inherit">{curve.replace(/_/g, ' ')}</Typography>
)) </MenuItem>
}, [curves, props.chart]) )),
[curves, props.chart]
)
return ( return (
<Menu anchorEl={props.anchorEl} open={props.open} onClose={props.close}> <Menu anchorEl={props.anchorEl} open={props.open} onClose={props.close}>
@@ -57,12 +59,10 @@ function InterpolationSettings(props: {
) )
} }
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { chart: bindActionCreators(chartActions, dispatch),
chart: bindActionCreators(chartActions, dispatch), },
}, })
}
}
export default connect(undefined, mapDispatchToProps)(InterpolationSettings) export default connect(undefined, mapDispatchToProps)(InterpolationSettings)

View File

@@ -1,10 +1,10 @@
import * as React from 'react' import * as React from 'react'
import ArrowUpward from '@mui/icons-material/ArrowUpward' import ArrowUpward from '@mui/icons-material/ArrowUpward'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { chartActions } from '../../../actions'
import { ChartParameters } from '../../../reducers/Charts'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { MenuItem, Typography, ListItemIcon } from '@mui/material' import { MenuItem, Typography, ListItemIcon } from '@mui/material'
import { chartActions } from '../../../actions'
import { ChartParameters } from '../../../reducers/Charts'
function MoveUp(props: { actions: { chart: typeof chartActions }; chart: ChartParameters; close: () => void }) { function MoveUp(props: { actions: { chart: typeof chartActions }; chart: ChartParameters; close: () => void }) {
const moveUp = React.useCallback(() => { const moveUp = React.useCallback(() => {
@@ -25,12 +25,10 @@ function MoveUp(props: { actions: { chart: typeof chartActions }; chart: ChartPa
) )
} }
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { chart: bindActionCreators(chartActions, dispatch),
chart: bindActionCreators(chartActions, dispatch), },
}, })
}
}
export default connect(undefined, mapDispatchToProps)(MoveUp) export default connect(undefined, mapDispatchToProps)(MoveUp)

View File

@@ -1,8 +1,8 @@
import React, { useCallback, useState, ChangeEvent, MouseEvent, useRef, useEffect, useMemo } from 'react' import React, { useCallback, useState, ChangeEvent, MouseEvent, useRef, useEffect, useMemo } from 'react'
import { ChartParameters } from '../../../reducers/Charts'
import { Menu, TextField, Typography } from '@mui/material' import { Menu, TextField, Typography } from '@mui/material'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { ChartParameters } from '../../../reducers/Charts'
import { chartActions } from '../../../actions' import { chartActions } from '../../../actions'
import { KeyCodes } from '../../../utils/KeyCodes' import { KeyCodes } from '../../../utils/KeyCodes'
@@ -50,7 +50,7 @@ function RangeSettings(props: Props) {
() => ( () => (
<Menu <Menu
style={{ textAlign: 'center' }} style={{ textAlign: 'center' }}
keepMounted={true} keepMounted
anchorEl={props.anchorEl} anchorEl={props.anchorEl}
open={props.open} open={props.open}
onClose={props.onClose} onClose={props.onClose}
@@ -62,7 +62,7 @@ function RangeSettings(props: Props) {
inputProps={{ inputProps={{
ref: rangeFromRef, ref: rangeFromRef,
}} }}
autoFocus={true} autoFocus
style={{ marginTop: '0' }} style={{ marginTop: '0' }}
label="from" label="from"
value={rangeFrom} value={rangeFrom}
@@ -87,13 +87,11 @@ function RangeSettings(props: Props) {
) )
} }
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { chart: bindActionCreators(chartActions, dispatch),
chart: bindActionCreators(chartActions, dispatch), },
}, })
}
}
export default connect(undefined, mapDispatchToProps)(RangeSettings) export default connect(undefined, mapDispatchToProps)(RangeSettings)

View File

@@ -1,7 +1,7 @@
import * as React from 'react' import * as React from 'react'
import MoreVertIcon from '@mui/icons-material/Settings'
import ChartSettings from '.' import ChartSettings from '.'
import CustomIconButton from '../../helper/CustomIconButton' import CustomIconButton from '../../helper/CustomIconButton'
import MoreVertIcon from '@mui/icons-material/Settings'
import { ChartParameters } from '../../../reducers/Charts' import { ChartParameters } from '../../../reducers/Charts'
export function SettingsButton(props: { export function SettingsButton(props: {

View File

@@ -1,8 +1,8 @@
import React, { memo } from 'react' import React, { memo } from 'react'
import { ChartParameters } from '../../../reducers/Charts'
import { Menu, MenuItem, TextField, Typography } from '@mui/material' import { Menu, MenuItem, TextField, Typography } from '@mui/material'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { ChartParameters } from '../../../reducers/Charts'
import { chartActions } from '../../../actions' import { chartActions } from '../../../actions'
function Size(props: { function Size(props: {
@@ -39,12 +39,10 @@ function Size(props: {
) )
} }
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { chart: bindActionCreators(chartActions, dispatch),
chart: bindActionCreators(chartActions, dispatch), },
}, })
}
}
export default connect(undefined, mapDispatchToProps)(memo(Size)) export default connect(undefined, mapDispatchToProps)(memo(Size))

View File

@@ -1,9 +1,10 @@
import React, { ChangeEvent, MouseEvent, useCallback, useEffect, useMemo, useRef, useState } from 'react' import React, { ChangeEvent, MouseEvent, useCallback, useEffect, useMemo, useRef, useState } from 'react'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { Button, Menu, TextField, Typography } from '@mui/material' import { Button, Menu, TextField, Typography } from '@mui/material'
import { connect } from 'react-redux'
import { chartActions } from '../../../actions' import { chartActions } from '../../../actions'
import { ChartParameters } from '../../../reducers/Charts' import { ChartParameters } from '../../../reducers/Charts'
import { connect } from 'react-redux'
const parseDuration = require('parse-duration') const parseDuration = require('parse-duration')
interface Props { interface Props {
@@ -51,25 +52,23 @@ function TimeRangeSettings(props: Props) {
return ( return (
<Menu <Menu
style={{ textAlign: 'center' }} style={{ textAlign: 'center' }}
keepMounted={true} keepMounted
anchorEl={props.anchorEl} anchorEl={props.anchorEl}
open={props.open} open={props.open}
onClose={props.onClose} onClose={props.onClose}
> >
<Typography>Chart data within a time interval</Typography> <Typography>Chart data within a time interval</Typography>
<div style={{ padding: '0 16px', width: '275px', textAlign: 'center' }}> <div style={{ padding: '0 16px', width: '275px', textAlign: 'center' }}>
{ranges.map(r => { {ranges.map(r => (
return ( <Button
<Button style={{ margin: '4px', textTransform: 'none' }}
style={{ margin: '4px', textTransform: 'none' }} variant="contained"
variant="contained" key={r}
key={r} onClick={createRangeHandler(r)}
onClick={createRangeHandler(r)} >
> {r}
{r} </Button>
</Button> ))}
)
})}
</div> </div>
<Typography style={{ fontSize: '0.75em' }}> <Typography style={{ fontSize: '0.75em' }}>
<i>Limited to 500 data points</i> <i>Limited to 500 data points</i>
@@ -88,12 +87,10 @@ function TimeRangeSettings(props: Props) {
}, [value, props.open]) }, [value, props.open])
} }
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { chart: bindActionCreators(chartActions, dispatch),
chart: bindActionCreators(chartActions, dispatch), },
}, })
}
}
export default connect(undefined, mapDispatchToProps)(TimeRangeSettings) export default connect(undefined, mapDispatchToProps)(TimeRangeSettings)

View File

@@ -22,7 +22,7 @@ export function colors() {
function colorCompare(colorA: string, colorB: string) { function colorCompare(colorA: string, colorB: string) {
const a = colorToInt(colorA) const a = colorToInt(colorA)
const b = colorToInt(colorB) const b = colorToInt(colorB)
return Math.sqrt(Math.pow(a[0] - b[0], 2) + Math.pow(a[1] - b[1], 2) + Math.pow(a[2] - b[2], 2)) return Math.sqrt((a[0] - b[0]) ** 2 + (a[1] - b[1]) ** 2 + (a[2] - b[2]) ** 2)
} }
const colors: Array<string> = [ const colors: Array<string> = [
brown, brown,

View File

@@ -1,17 +1,17 @@
import BarChart from '@mui/icons-material/BarChart' import BarChart from '@mui/icons-material/BarChart'
import Clear from '@mui/icons-material/Refresh' import Clear from '@mui/icons-material/Refresh'
import ColorLens from '@mui/icons-material/ColorLens' import ColorLens from '@mui/icons-material/ColorLens'
import MultilineChart from '@mui/icons-material/MultilineChart'
import React, { memo } from 'react'
import Sort from '@mui/icons-material/Sort'
import { Menu, MenuItem, ListItemIcon, Typography } from '@mui/material'
import ColorSettings from './ColorSettings' import ColorSettings from './ColorSettings'
import InterpolationSettings from './InterpolationSettings' import InterpolationSettings from './InterpolationSettings'
import MoveUp from './MoveUp' import MoveUp from './MoveUp'
import MultilineChart from '@mui/icons-material/MultilineChart'
import RangeSettings from './RangeSettings' import RangeSettings from './RangeSettings'
import React, { memo } from 'react'
import Size from './Size' import Size from './Size'
import Sort from '@mui/icons-material/Sort'
import TimeRangeSettings from './TimeRangeSettings' import TimeRangeSettings from './TimeRangeSettings'
import { ChartParameters } from '../../../reducers/Charts' import { ChartParameters } from '../../../reducers/Charts'
import { Menu, MenuItem, ListItemIcon, Typography } from '@mui/material'
function ChartSettings(props: { function ChartSettings(props: {
open: boolean open: boolean
@@ -25,7 +25,7 @@ function ChartSettings(props: {
const [interpolationVisible, setInterpolationVisible] = React.useState(false) const [interpolationVisible, setInterpolationVisible] = React.useState(false)
const [sizeVisible, setSizeVisible] = React.useState(false) const [sizeVisible, setSizeVisible] = React.useState(false)
const [colorVisible, setColorVisible] = React.useState(false) const [colorVisible, setColorVisible] = React.useState(false)
const open = props.open const { open } = props
const toggleRange = React.useCallback(() => { const toggleRange = React.useCallback(() => {
if (open) { if (open) {

View File

@@ -1,8 +1,8 @@
import * as React from 'react' import * as React from 'react'
import { ChartParameters } from '../../reducers/Charts'
import { Typography } from '@mui/material' import { Typography } from '@mui/material'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import { ChartParameters } from '../../reducers/Charts'
function ChartTitle(props: { parameters: ChartParameters; classes: any }) { function ChartTitle(props: { parameters: ChartParameters; classes: any }) {
const { classes, parameters } = props const { classes, parameters } = props
@@ -13,7 +13,7 @@ function ChartTitle(props: { parameters: ChartParameters; classes: any }) {
</Typography> </Typography>
<br /> <br />
<Typography variant="caption" className={classes.topic}> <Typography variant="caption" className={classes.topic}>
{parameters.dotPath ? parameters.topic : <span dangerouslySetInnerHTML={{ __html: '&nbsp;' }}></span>} {parameters.dotPath ? parameters.topic : <span dangerouslySetInnerHTML={{ __html: '&nbsp;' }} />}
</Typography> </Typography>
</div> </div>
) )
@@ -21,10 +21,10 @@ function ChartTitle(props: { parameters: ChartParameters; classes: any }) {
const styles = (theme: Theme) => ({ const styles = (theme: Theme) => ({
topic: { topic: {
wordBreak: 'break-all' as 'break-all', wordBreak: 'break-all' as const,
whiteSpace: 'nowrap' as 'nowrap', whiteSpace: 'nowrap' as const,
overflow: 'hidden' as 'hidden', overflow: 'hidden' as const,
textOverflow: 'ellipsis' as 'ellipsis', textOverflow: 'ellipsis' as const,
}, },
}) })

View File

@@ -1,5 +1,5 @@
import * as q from '../../../../backend/src/Model'
import React from 'react' import React from 'react'
import * as q from '../../../../backend/src/Model'
import TopicChart from './TopicChart' import TopicChart from './TopicChart'
import { ChartParameters } from '../../reducers/Charts' import { ChartParameters } from '../../reducers/Charts'
import { usePollingToFetchTreeNode } from '../helper/usePollingToFetchTreeNode' import { usePollingToFetchTreeNode } from '../helper/usePollingToFetchTreeNode'

View File

@@ -1,13 +1,14 @@
import React, { useState, useCallback, memo, useRef } from 'react'
import { bindActionCreators } from 'redux'
import { connect } from 'react-redux'
import { Paper } from '@mui/material'
import * as q from '../../../../backend/src/Model' import * as q from '../../../../backend/src/Model'
import ChartTitle from './ChartTitle' import ChartTitle from './ChartTitle'
import React, { useState, useCallback, memo, useRef } from 'react'
import TopicPlot from '../TopicPlot' import TopicPlot from '../TopicPlot'
import { bindActionCreators } from 'redux'
import { ChartActions } from './ChartActions' import { ChartActions } from './ChartActions'
import { chartActions } from '../../actions' import { chartActions } from '../../actions'
import { ChartParameters } from '../../reducers/Charts' import { ChartParameters } from '../../reducers/Charts'
import { connect } from 'react-redux'
import { Paper } from '@mui/material'
const throttle = require('lodash.throttle') const throttle = require('lodash.throttle')
class ClearableMessageBuffer extends q.RingBuffer<q.Message> { class ClearableMessageBuffer extends q.RingBuffer<q.Message> {
@@ -126,12 +127,10 @@ function TopicChart(props: Props) {
) )
} }
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { chart: bindActionCreators(chartActions, dispatch),
chart: bindActionCreators(chartActions, dispatch), },
}, })
}
}
export default connect(undefined, mapDispatchToProps)(memo(TopicChart)) export default connect(undefined, mapDispatchToProps)(memo(TopicChart))

View File

@@ -1,16 +1,17 @@
import * as q from '../../../../backend/src/Model'
import * as React from 'react' import * as React from 'react'
import ShowChart from '@mui/icons-material/ShowChart' import ShowChart from '@mui/icons-material/ShowChart'
import { AppState } from '../../reducers'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { chartActions } from '../../actions'
import { ChartParameters } from '../../reducers/Charts'
import { ChartWithTreeNode } from './ChartWithTreeNode'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { Grid, Typography } from '@mui/material' import { Grid, Typography } from '@mui/material'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import { List } from 'immutable' import { List } from 'immutable'
import * as q from '../../../../backend/src/Model'
import { AppState } from '../../reducers'
import { ChartWithTreeNode } from './ChartWithTreeNode'
import { ChartParameters } from '../../reducers/Charts'
import { chartActions } from '../../actions'
const { TransitionGroup, CSSTransition } = require('react-transition-group/esm') const { TransitionGroup, CSSTransition } = require('react-transition-group/esm')
interface Props { interface Props {
@@ -26,11 +27,11 @@ interface Props {
function spacingForChartCount(count: number): 4 | 6 | 12 { function spacingForChartCount(count: number): 4 | 6 | 12 {
if (count >= 5) { if (count >= 5) {
return 4 return 4
} else if (count >= 2) {
return 6
} else {
return 12
} }
if (count >= 2) {
return 6
}
return 12
} }
function mapWidth(width: 'big' | 'medium' | 'small' | undefined, calculatedSpacing: 4 | 6 | 12): 4 | 6 | 12 { function mapWidth(width: 'big' | 'medium' | 'small' | undefined, calculatedSpacing: 4 | 6 | 12): 4 | 6 | 12 {
@@ -46,7 +47,6 @@ function mapWidth(width: 'big' | 'medium' | 'small' | undefined, calculatedSpaci
} }
} }
// Helper function to generate unique keys for charts // Helper function to generate unique keys for charts
const getChartKey = (chart: ChartParameters) => `${chart.topic}-${chart.dotPath || ''}` const getChartKey = (chart: ChartParameters) => `${chart.topic}-${chart.dotPath || ''}`
@@ -94,12 +94,7 @@ function ChartPanel(props: Props) {
const nodeRef = nodeRefsMap.current.get(key)! const nodeRef = nodeRefsMap.current.get(key)!
return ( return (
<CSSTransition <CSSTransition key={key} timeout={{ enter: 500, exit: 500 }} classNames="example" nodeRef={nodeRef}>
key={key}
timeout={{ enter: 500, exit: 500 }}
classNames="example"
nodeRef={nodeRef}
>
<Grid item xs={mapWidth(chartParameters.width, spacing)} ref={nodeRef}> <Grid item xs={mapWidth(chartParameters.width, spacing)} ref={nodeRef}>
<ChartWithTreeNode tree={props.tree} parameters={chartParameters} /> <ChartWithTreeNode tree={props.tree} parameters={chartParameters} />
</Grid> </Grid>
@@ -131,21 +126,17 @@ function NoCharts() {
) )
} }
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => ({
return { charts: state.charts.get('charts'),
charts: state.charts.get('charts'), connectionId: state.connection.connectionId,
connectionId: state.connection.connectionId, tree: state.connection.tree,
tree: state.connection.tree, })
}
}
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { chart: bindActionCreators(chartActions, dispatch),
chart: bindActionCreators(chartActions, dispatch), },
}, })
}
}
const styles = (theme: Theme) => ({ const styles = (theme: Theme) => ({
container: { container: {

View File

@@ -1,6 +1,6 @@
import React, { useRef, useCallback, memo } from 'react' import React, { useRef, useCallback, memo } from 'react'
import { ConfirmationRequest } from '../reducers/Global'
import { Dialog, DialogTitle, DialogContent, DialogContentText, DialogActions, Button } from '@mui/material' import { Dialog, DialogTitle, DialogContent, DialogContentText, DialogActions, Button } from '@mui/material'
import { ConfirmationRequest } from '../reducers/Global'
import { KeyCodes } from '../utils/KeyCodes' import { KeyCodes } from '../utils/KeyCodes'
function ConfirmationDialog(props: { confirmationRequests: Array<ConfirmationRequest> }) { function ConfirmationDialog(props: { confirmationRequests: Array<ConfirmationRequest> }) {
@@ -34,7 +34,7 @@ function ConfirmationDialog(props: { confirmationRequests: Array<ConfirmationReq
return ( return (
<Dialog <Dialog
open={true} open
onClose={reject} onClose={reject}
aria-labelledby="alert-dialog-title" aria-labelledby="alert-dialog-title"
aria-describedby="alert-dialog-description" aria-describedby="alert-dialog-description"

View File

@@ -5,14 +5,15 @@ import Lock from '@mui/icons-material/Lock'
import Undo from '@mui/icons-material/Undo' import Undo from '@mui/icons-material/Undo'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { connectionManagerActions } from '../../actions'
import { ConnectionOptions } from '../../model/ConnectionOptions'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { Button, Grid, TextField, Tooltip } from '@mui/material' import { Button, Grid, TextField, Tooltip } from '@mui/material'
import { QoS } from 'mqtt-explorer-backend/src/DataSource/MqttSource'
import { connectionManagerActions } from '../../actions'
import { QosSelect } from '../QosSelect' import { QosSelect } from '../QosSelect'
import { QoS } from '../../../../backend/src/DataSource/MqttSource' import { ConnectionOptions } from '../../model/ConnectionOptions'
import Subscriptions from './Subscriptions' import Subscriptions from './Subscriptions'
const SubscriptionsAny = Subscriptions as any const SubscriptionsAny = Subscriptions as any
interface Props { interface Props {
@@ -21,7 +22,7 @@ interface Props {
managerActions: typeof connectionManagerActions managerActions: typeof connectionManagerActions
} }
const ConnectionSettings = memo(function ConnectionSettings(props: Props) { const ConnectionSettings = memo((props: Props) => {
const [qos, setQos] = useState<QoS>(0) const [qos, setQos] = useState<QoS>(0)
const [topic, setTopic] = useState('') const [topic, setTopic] = useState('')
const { classes } = props const { classes } = props
@@ -42,9 +43,9 @@ const ConnectionSettings = memo(function ConnectionSettings(props: Props) {
return ( return (
<div> <div>
<form className={classes.container} noValidate={true} autoComplete="off"> <form className={classes.container} noValidate autoComplete="off">
<Grid container={true} spacing={3}> <Grid container spacing={3}>
<Grid item={true} xs={8} className={classes.gridPadding}> <Grid item xs={8} className={classes.gridPadding}>
<TextField <TextField
className={`${classes.fullWidth} advanced-connection-settings-topic-input`} className={`${classes.fullWidth} advanced-connection-settings-topic-input`}
label="Topic" label="Topic"
@@ -54,12 +55,12 @@ const ConnectionSettings = memo(function ConnectionSettings(props: Props) {
onChange={updateSubscription} onChange={updateSubscription}
/> />
</Grid> </Grid>
<Grid item={true} xs={2} className={classes.gridPadding}> <Grid item xs={2} className={classes.gridPadding}>
<div className={classes.qos}> <div className={classes.qos}>
<QosSelect label="QoS" selected={qos} onChange={setQos} /> <QosSelect label="QoS" selected={qos} onChange={setQos} />
</div> </div>
</Grid> </Grid>
<Grid item={true} xs={2} className={classes.gridPadding}> <Grid item xs={2} className={classes.gridPadding}>
<Button <Button
className={classes.button} className={classes.button}
color="secondary" color="secondary"
@@ -70,10 +71,10 @@ const ConnectionSettings = memo(function ConnectionSettings(props: Props) {
<Add /> Add <Add /> Add
</Button> </Button>
</Grid> </Grid>
<Grid item={true} xs={12} style={{ padding: 0 }}> <Grid item xs={12} style={{ padding: 0 }}>
<SubscriptionsAny connection={props.connection} /> <SubscriptionsAny connection={props.connection} />
</Grid> </Grid>
<Grid item={true} xs={7} className={classes.gridPadding}> <Grid item xs={7} className={classes.gridPadding}>
<TextField <TextField
className={classes.fullWidth} className={classes.fullWidth}
label="MQTT Client ID" label="MQTT Client ID"
@@ -82,7 +83,7 @@ const ConnectionSettings = memo(function ConnectionSettings(props: Props) {
onChange={handleChange('clientId')} onChange={handleChange('clientId')}
/> />
</Grid> </Grid>
<Grid item={true} xs={3} className={classes.gridPadding}> <Grid item xs={3} className={classes.gridPadding}>
<div> <div>
<Tooltip title="Manage tls connection certificates" placement="top"> <Tooltip title="Manage tls connection certificates" placement="top">
<Button <Button
@@ -95,7 +96,7 @@ const ConnectionSettings = memo(function ConnectionSettings(props: Props) {
</Tooltip> </Tooltip>
</div> </div>
</Grid> </Grid>
<Grid item={true} xs={2} className={classes.gridPadding}> <Grid item xs={2} className={classes.gridPadding}>
<Button <Button
variant="contained" variant="contained"
className={classes.button} className={classes.button}
@@ -111,11 +112,9 @@ const ConnectionSettings = memo(function ConnectionSettings(props: Props) {
) )
}) })
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { managerActions: bindActionCreators(connectionManagerActions, dispatch),
managerActions: bindActionCreators(connectionManagerActions, dispatch), })
}
}
const styles = (theme: Theme) => ({ const styles = (theme: Theme) => ({
fullWidth: { fullWidth: {
@@ -126,7 +125,7 @@ const styles = (theme: Theme) => ({
}, },
button: { button: {
marginTop: theme.spacing(3), marginTop: theme.spacing(3),
float: 'right' as 'right', float: 'right' as const,
}, },
qos: { qos: {
marginTop: theme.spacing(1), marginTop: theme.spacing(1),

View File

@@ -1,15 +1,15 @@
import * as React from 'react' import * as React from 'react'
import ClearAdornment from '../helper/ClearAdornment'
import Lock from '@mui/icons-material/Lock' import Lock from '@mui/icons-material/Lock'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { Button, Theme, Tooltip, Typography } from '@mui/material' import { Button, Theme, Tooltip, Typography } from '@mui/material'
import { connect } from 'react-redux'
import { withStyles } from '@mui/styles'
import { RpcEvents } from '../../../../events/EventsV2'
import { CertificateParameters, ConnectionOptions } from '../../model/ConnectionOptions' import { CertificateParameters, ConnectionOptions } from '../../model/ConnectionOptions'
import { CertificateTypes } from '../../actions/ConnectionManager' import { CertificateTypes } from '../../actions/ConnectionManager'
import { connect } from 'react-redux'
import { connectionManagerActions } from '../../actions' import { connectionManagerActions } from '../../actions'
import { withStyles } from '@mui/styles' import ClearAdornment from '../helper/ClearAdornment'
import { rendererRpc } from '../../eventBus' import { rendererRpc } from '../../eventBus'
import { RpcEvents } from '../../../../events/EventsV2'
function BrowserCertificateFileSelection(props: { function BrowserCertificateFileSelection(props: {
certificateType: CertificateTypes certificateType: CertificateTypes
@@ -114,21 +114,19 @@ function ClearCertificate(props: { classes: any; certificate?: CertificateParame
) )
} }
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { connectionManager: bindActionCreators(connectionManagerActions, dispatch),
connectionManager: bindActionCreators(connectionManagerActions, dispatch), },
}, })
}
}
const styles = (theme: Theme) => ({ const styles = (theme: Theme) => ({
certificateName: { certificateName: {
width: '100%', width: '100%',
height: 'calc(1em + 4px)', height: 'calc(1em + 4px)',
overflow: 'hidden' as 'hidden', overflow: 'hidden' as const,
whiteSpace: 'nowrap' as 'nowrap', whiteSpace: 'nowrap' as const,
textOverflow: 'ellipsis' as 'ellipsis', textOverflow: 'ellipsis' as const,
color: theme.palette.text.secondary, color: theme.palette.text.secondary,
}, },
button: { button: {

View File

@@ -1,13 +1,13 @@
import * as React from 'react' import * as React from 'react'
import ClearAdornment from '../helper/ClearAdornment'
import Lock from '@mui/icons-material/Lock' import Lock from '@mui/icons-material/Lock'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { Button, Theme, Tooltip, Typography } from '@mui/material' import { Button, Theme, Tooltip, Typography } from '@mui/material'
import { connect } from 'react-redux'
import { withStyles } from '@mui/styles'
import { CertificateParameters, ConnectionOptions } from '../../model/ConnectionOptions' import { CertificateParameters, ConnectionOptions } from '../../model/ConnectionOptions'
import { CertificateTypes } from '../../actions/ConnectionManager' import { CertificateTypes } from '../../actions/ConnectionManager'
import { connect } from 'react-redux'
import { connectionManagerActions } from '../../actions' import { connectionManagerActions } from '../../actions'
import { withStyles } from '@mui/styles' import ClearAdornment from '../helper/ClearAdornment'
function CertificateFileSelection(props: { function CertificateFileSelection(props: {
certificateType: CertificateTypes certificateType: CertificateTypes
@@ -56,21 +56,19 @@ function ClearCertificate(props: { classes: any; certificate?: CertificateParame
) )
} }
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { connectionManager: bindActionCreators(connectionManagerActions, dispatch),
connectionManager: bindActionCreators(connectionManagerActions, dispatch), },
}, })
}
}
const styles = (theme: Theme) => ({ const styles = (theme: Theme) => ({
certificateName: { certificateName: {
width: '100%', width: '100%',
height: 'calc(1em + 4px)', height: 'calc(1em + 4px)',
overflow: 'hidden' as 'hidden', overflow: 'hidden' as const,
whiteSpace: 'nowrap' as 'nowrap', whiteSpace: 'nowrap' as const,
textOverflow: 'ellipsis' as 'ellipsis', textOverflow: 'ellipsis' as const,
color: theme.palette.text.secondary, color: theme.palette.text.secondary,
}, },
button: { button: {

View File

@@ -1,14 +1,14 @@
import * as React from 'react' import * as React from 'react'
import CertificateFileSelection from './CertificateFileSelection'
import BrowserCertificateFileSelection from './BrowserCertificateFileSelection'
import Undo from '@mui/icons-material/Undo' import Undo from '@mui/icons-material/Undo'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { Button, Grid } from '@mui/material' import { Button, Grid } from '@mui/material'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { connectionManagerActions } from '../../actions'
import { ConnectionOptions } from '../../model/ConnectionOptions'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { connectionManagerActions } from '../../actions'
import { ConnectionOptions } from '../../model/ConnectionOptions'
import BrowserCertificateFileSelection from './BrowserCertificateFileSelection'
import CertificateFileSelection from './CertificateFileSelection'
import { isBrowserMode } from '../../utils/browserMode' import { isBrowserMode } from '../../utils/browserMode'
// Use browser or desktop file selection based on mode // Use browser or desktop file selection based on mode
@@ -48,9 +48,9 @@ class Certificates extends React.PureComponent<Props, State> {
const { classes } = this.props const { classes } = this.props
return ( return (
<div> <div>
<form noValidate={true} autoComplete="off"> <form noValidate autoComplete="off">
<Grid container={true} spacing={3}> <Grid container spacing={3}>
<Grid item={true} xs={12} className={classes.gridPadding}> <Grid item xs={12} className={classes.gridPadding}>
<CertSelector <CertSelector
connection={this.props.connection} connection={this.props.connection}
certificate={this.props.connection.selfSignedCertificate} certificate={this.props.connection.selfSignedCertificate}
@@ -58,7 +58,7 @@ class Certificates extends React.PureComponent<Props, State> {
certificateType="selfSignedCertificate" certificateType="selfSignedCertificate"
/> />
</Grid> </Grid>
<Grid item={true} xs={12} className={classes.gridPadding}> <Grid item xs={12} className={classes.gridPadding}>
<CertSelector <CertSelector
connection={this.props.connection} connection={this.props.connection}
certificate={this.props.connection.clientCertificate} certificate={this.props.connection.clientCertificate}
@@ -66,7 +66,7 @@ class Certificates extends React.PureComponent<Props, State> {
certificateType="clientCertificate" certificateType="clientCertificate"
/> />
</Grid> </Grid>
<Grid item={true} xs={12} className={classes.gridPadding}> <Grid item xs={12} className={classes.gridPadding}>
<CertSelector <CertSelector
connection={this.props.connection} connection={this.props.connection}
certificate={this.props.connection.clientKey} certificate={this.props.connection.clientKey}
@@ -74,7 +74,7 @@ class Certificates extends React.PureComponent<Props, State> {
certificateType="clientKey" certificateType="clientKey"
/> />
</Grid> </Grid>
<Grid item={true} xs={2} className={classes.gridPadding}> <Grid item xs={2} className={classes.gridPadding}>
<br /> <br />
<Button <Button
variant="contained" variant="contained"
@@ -91,11 +91,9 @@ class Certificates extends React.PureComponent<Props, State> {
} }
} }
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { managerActions: bindActionCreators(connectionManagerActions, dispatch),
managerActions: bindActionCreators(connectionManagerActions, dispatch), })
}
}
const styles = (theme: Theme) => ({ const styles = (theme: Theme) => ({
fullWidth: { fullWidth: {

View File

@@ -1,7 +1,7 @@
import ConnectionHealthIndicator from '../helper/ConnectionHealthIndicator'
import PowerSettingsNew from '@mui/icons-material/PowerSettingsNew' import PowerSettingsNew from '@mui/icons-material/PowerSettingsNew'
import React from 'react' import React from 'react'
import { Button } from '@mui/material' import { Button } from '@mui/material'
import ConnectionHealthIndicator from '../helper/ConnectionHealthIndicator'
function ConnectButton(props: { connecting: boolean; classes: any; toggle: () => void }) { function ConnectButton(props: { connecting: boolean; classes: any; toggle: () => void }) {
const { classes, toggle, connecting } = props const { classes, toggle, connecting } = props

View File

@@ -1,29 +1,21 @@
import ConnectButton from './ConnectButton'
import React, { useCallback, useState } from 'react' import React, { useCallback, useState } from 'react'
import Save from '@mui/icons-material/Save' import Save from '@mui/icons-material/Save'
import Delete from '@mui/icons-material/Delete' import Delete from '@mui/icons-material/Delete'
import Settings from '@mui/icons-material/Settings' import Settings from '@mui/icons-material/Settings'
import Visibility from '@mui/icons-material/Visibility' import Visibility from '@mui/icons-material/Visibility'
import VisibilityOff from '@mui/icons-material/VisibilityOff' import VisibilityOff from '@mui/icons-material/VisibilityOff'
import { AppState } from '../../reducers'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles'
import { Button, Grid, IconButton, InputAdornment, MenuItem, TextField, Tooltip } from '@mui/material'
import { AppState } from '../../reducers'
import { connectionActions, connectionManagerActions, globalActions } from '../../actions' import { connectionActions, connectionManagerActions, globalActions } from '../../actions'
import { ConnectionOptions, toMqttConnection } from '../../model/ConnectionOptions' import { ConnectionOptions, toMqttConnection } from '../../model/ConnectionOptions'
import { KeyCodes } from '../../utils/KeyCodes' import { KeyCodes } from '../../utils/KeyCodes'
import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles'
import { ToggleSwitch } from './ToggleSwitch' import { ToggleSwitch } from './ToggleSwitch'
import { useGlobalKeyEventHandler } from '../../effects/useGlobalKeyEventHandler' import { useGlobalKeyEventHandler } from '../../effects/useGlobalKeyEventHandler'
import { import ConnectButton from './ConnectButton'
Button,
Grid,
IconButton,
InputAdornment,
MenuItem,
TextField,
Tooltip,
} from '@mui/material'
interface Props { interface Props {
connection: ConnectionOptions connection: ConnectionOptions
@@ -80,7 +72,7 @@ function ConnectionSettings(props: Props) {
function renderBasePathInput() { function renderBasePathInput() {
return ( return (
<Grid item={true} xs={4}> <Grid item xs={4}>
<TextField <TextField
label="Basepath" label="Basepath"
className={props.classes.textField} className={props.classes.textField}
@@ -111,21 +103,23 @@ function ConnectionSettings(props: Props) {
const protocolItems = protocols.map((value: string) => ( const protocolItems = protocols.map((value: string) => (
<MenuItem key={value} value={value}> <MenuItem key={value} value={value}>
{value}:// {value === 'mqtt' ? '(Standard)' : '(WebSocket)'} {value}
://
{value === 'mqtt' ? '(Standard)' : '(WebSocket)'}
</MenuItem> </MenuItem>
)) ))
return ( return (
<Tooltip title="Use 'mqtt' for standard connections or 'ws' for WebSocket connections" arrow> <Tooltip title="Use 'mqtt' for standard connections or 'ws' for WebSocket connections" arrow>
<TextField <TextField
select={true} select
label="Protocol" label="Protocol"
className={classes.textField} className={classes.textField}
value={connection.protocol} value={connection.protocol}
onChange={updateProtocol} onChange={updateProtocol}
margin="dense" margin="dense"
inputProps={{ inputProps={{
'aria-label': 'MQTT protocol' 'aria-label': 'MQTT protocol',
}} }}
> >
{protocolItems} {protocolItems}
@@ -135,7 +129,7 @@ function ConnectionSettings(props: Props) {
} }
const updateProtocol = (event: React.ChangeEvent<HTMLInputElement>) => { const updateProtocol = (event: React.ChangeEvent<HTMLInputElement>) => {
const value = event.target.value const { value } = event.target
updateConnection('protocol', value) updateConnection('protocol', value)
if (event.target.value === 'mqtt') { if (event.target.value === 'mqtt') {
updateConnection('basePath', undefined) updateConnection('basePath', undefined)
@@ -159,9 +153,9 @@ function ConnectionSettings(props: Props) {
function PasswordVisibilityButton(props: { showPassword: boolean; toggle: () => void }) { function PasswordVisibilityButton(props: { showPassword: boolean; toggle: () => void }) {
return ( return (
<InputAdornment position="end"> <InputAdornment position="end">
<Tooltip title={props.showPassword ? "Hide password" : "Show password"} arrow> <Tooltip title={props.showPassword ? 'Hide password' : 'Show password'} arrow>
<IconButton <IconButton
aria-label={props.showPassword ? "Hide password" : "Show password"} aria-label={props.showPassword ? 'Hide password' : 'Show password'}
onClick={props.toggle} onClick={props.toggle}
edge="end" edge="end"
> >
@@ -176,11 +170,11 @@ function ConnectionSettings(props: Props) {
return ( return (
<div style={{ height: '100%', display: 'flex', flexDirection: 'column' }}> <div style={{ height: '100%', display: 'flex', flexDirection: 'column' }}>
<form className={classes.container} noValidate={true} autoComplete="off" style={{ flex: 1, overflow: 'auto' }}> <form className={classes.container} noValidate autoComplete="off" style={{ flex: 1, overflow: 'auto' }}>
<Grid container={true} spacing={2}> <Grid container spacing={2}>
<Grid item={true} xs={5}> <Grid item xs={5}>
<TextField <TextField
autoFocus={true} autoFocus
label="Name" label="Name"
className={classes.textField} className={classes.textField}
value={connection.name} value={connection.name}
@@ -188,11 +182,11 @@ function ConnectionSettings(props: Props) {
margin="dense" margin="dense"
placeholder="My MQTT Connection" placeholder="My MQTT Connection"
inputProps={{ inputProps={{
'aria-label': 'Connection name' 'aria-label': 'Connection name',
}} }}
/> />
</Grid> </Grid>
<Grid item={true} xs={4}> <Grid item xs={4}>
<ToggleSwitch <ToggleSwitch
label="Validate certificate" label="Validate certificate"
classes={classes} classes={classes}
@@ -200,13 +194,13 @@ function ConnectionSettings(props: Props) {
toggle={toggleCertValidation} toggle={toggleCertValidation}
/> />
</Grid> </Grid>
<Grid item={true} xs={3}> <Grid item xs={3}>
<ToggleSwitch label="Encryption (tls)" classes={classes} value={connection.encryption} toggle={toggleTls} /> <ToggleSwitch label="Encryption (tls)" classes={classes} value={connection.encryption} toggle={toggleTls} />
</Grid> </Grid>
<Grid item={true} xs={2}> <Grid item xs={2}>
{renderProtocols()} {renderProtocols()}
</Grid> </Grid>
<Grid item={true} xs={7}> <Grid item xs={7}>
<TextField <TextField
label="Host" label="Host"
className={classes.textField} className={classes.textField}
@@ -216,11 +210,11 @@ function ConnectionSettings(props: Props) {
placeholder="broker.example.com" placeholder="broker.example.com"
inputProps={{ inputProps={{
'data-testid': 'host-input', 'data-testid': 'host-input',
'aria-label': 'MQTT broker host' 'aria-label': 'MQTT broker host',
}} }}
/> />
</Grid> </Grid>
<Grid item={true} xs={3}> <Grid item xs={3}>
<TextField <TextField
label="Port" label="Port"
className={classes.textField} className={classes.textField}
@@ -232,12 +226,12 @@ function ConnectionSettings(props: Props) {
inputProps={{ inputProps={{
'aria-label': 'MQTT broker port', 'aria-label': 'MQTT broker port',
min: 1, min: 1,
max: 65535 max: 65535,
}} }}
/> />
</Grid> </Grid>
{requiresBasePath() ? renderBasePathInput() : null} {requiresBasePath() ? renderBasePathInput() : null}
<Grid item={true} xs={requiresBasePath() ? 4 : 6}> <Grid item xs={requiresBasePath() ? 4 : 6}>
<TextField <TextField
label="Username" label="Username"
className={classes.textField} className={classes.textField}
@@ -247,11 +241,11 @@ function ConnectionSettings(props: Props) {
placeholder="Optional" placeholder="Optional"
inputProps={{ inputProps={{
'aria-label': 'MQTT username', 'aria-label': 'MQTT username',
'autoComplete': 'username' autoComplete: 'username',
}} }}
/> />
</Grid> </Grid>
<Grid item={true} xs={requiresBasePath() ? 4 : 6}> <Grid item xs={requiresBasePath() ? 4 : 6}>
<TextField <TextField
label="Password" label="Password"
className={classes.textField} className={classes.textField}
@@ -261,17 +255,25 @@ function ConnectionSettings(props: Props) {
margin="dense" margin="dense"
placeholder="Optional" placeholder="Optional"
InputProps={{ InputProps={{
endAdornment: <PasswordVisibilityButton showPassword={showPassword} toggle={handleClickShowPassword} /> endAdornment: <PasswordVisibilityButton showPassword={showPassword} toggle={handleClickShowPassword} />,
}} }}
inputProps={{ inputProps={{
'aria-label': 'MQTT password', 'aria-label': 'MQTT password',
'autoComplete': 'current-password' autoComplete: 'current-password',
}} }}
/> />
</Grid> </Grid>
</Grid> </Grid>
</form> </form>
<div style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center', paddingTop: '16px', borderTop: '1px solid rgba(0, 0, 0, 0.12)' }}> <div
style={{
display: 'flex',
justifyContent: 'space-between',
alignItems: 'center',
paddingTop: '16px',
borderTop: '1px solid rgba(0, 0, 0, 0.12)',
}}
>
<div> <div>
<Tooltip title="Delete this connection permanently" arrow> <Tooltip title="Delete this connection permanently" arrow>
<Button <Button
@@ -315,20 +317,16 @@ function ConnectionSettings(props: Props) {
) )
} }
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => ({
return { connected: state.connection.connected,
connected: state.connection.connected, connecting: state.connection.connecting,
connecting: state.connection.connecting, })
}
}
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: bindActionCreators(connectionActions, dispatch),
actions: bindActionCreators(connectionActions, dispatch), managerActions: bindActionCreators(connectionManagerActions, dispatch),
managerActions: bindActionCreators(connectionManagerActions, dispatch), globalActions: bindActionCreators(globalActions, dispatch),
globalActions: bindActionCreators(globalActions, dispatch), })
}
}
const styles = (theme: Theme) => ({ const styles = (theme: Theme) => ({
textField: { textField: {

View File

@@ -1,19 +1,20 @@
import * as React from 'react' import * as React from 'react'
import ConnectionSettings from './ConnectionSettings'
const ConnectionSettingsAny = ConnectionSettings as any
import ProfileList from './ProfileList'
import MobileConnectionSelector from './MobileConnectionSelector'
import { AppState } from '../../reducers'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { connectionManagerActions } from '../../actions'
import { ConnectionOptions, toMqttConnection } from '../../model/ConnectionOptions'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { Modal, Paper, Toolbar, Typography, Collapse } from '@mui/material' import { Modal, Paper, Toolbar, Typography, Collapse } from '@mui/material'
import ConnectionSettings from './ConnectionSettings'
import ProfileList from './ProfileList'
import MobileConnectionSelector from './MobileConnectionSelector'
import { AppState } from '../../reducers'
import { connectionManagerActions } from '../../actions'
import { ConnectionOptions, toMqttConnection } from '../../model/ConnectionOptions'
import AdvancedConnectionSettings from './AdvancedConnectionSettings' import AdvancedConnectionSettings from './AdvancedConnectionSettings'
const AdvancedConnectionSettingsAny = AdvancedConnectionSettings as any
import Certificates from './Certificates' import Certificates from './Certificates'
const ConnectionSettingsAny = ConnectionSettings as any
const AdvancedConnectionSettingsAny = AdvancedConnectionSettings as any
const CertificatesAny = Certificates as any const CertificatesAny = Certificates as any
interface Props { interface Props {
@@ -60,7 +61,7 @@ class ConnectionSetup extends React.PureComponent<Props, {}> {
const mqttConnection = connection && toMqttConnection(connection) const mqttConnection = connection && toMqttConnection(connection)
return ( return (
<div> <div>
<Modal open={visible} disableAutoFocus={true}> <Modal open={visible} disableAutoFocus>
<Paper className={classes.root}> <Paper className={classes.root}>
<div className={classes.left}> <div className={classes.left}>
<ProfileList /> <ProfileList />
@@ -90,7 +91,7 @@ const connectionHeight = '440px'
const styles = (theme: Theme) => ({ const styles = (theme: Theme) => ({
title: { title: {
color: theme.palette.text.primary, color: theme.palette.text.primary,
whiteSpace: 'nowrap' as 'nowrap', whiteSpace: 'nowrap' as const,
}, },
toolbarContent: { toolbarContent: {
width: '100%', width: '100%',
@@ -103,7 +104,7 @@ const styles = (theme: Theme) => ({
flex: 1, flex: 1,
// Hide on mobile - connection selector will take its place // Hide on mobile - connection selector will take its place
[theme.breakpoints.down('md')]: { [theme.breakpoints.down('md')]: {
display: 'none' as 'none', display: 'none' as const,
}, },
}, },
root: { root: {
@@ -111,29 +112,29 @@ const styles = (theme: Theme) => ({
minWidth: '800px', minWidth: '800px',
maxWidth: '850px', maxWidth: '850px',
height: connectionHeight, height: connectionHeight,
outline: 'none' as 'none', outline: 'none' as const,
display: 'flex' as 'flex', display: 'flex' as const,
// Mobile responsive adjustments // Mobile responsive adjustments
[theme.breakpoints.down('md')]: { [theme.breakpoints.down('md')]: {
minWidth: '95vw', minWidth: '95vw',
maxWidth: '95vw', maxWidth: '95vw',
height: '85vh', height: '85vh',
margin: '7.5vh auto 0 auto', margin: '7.5vh auto 0 auto',
flexDirection: 'column' as 'column', flexDirection: 'column' as const,
}, },
}, },
left: { left: {
borderRightStyle: 'dotted' as 'dotted', borderRightStyle: 'dotted' as const,
borderRadius: `${theme.shape.borderRadius}px 0 0 ${theme.shape.borderRadius}px`, borderRadius: `${theme.shape.borderRadius}px 0 0 ${theme.shape.borderRadius}px`,
paddingTop: theme.spacing(2), paddingTop: theme.spacing(2),
flex: 3, flex: 3,
overflow: 'hidden' as 'hidden', overflow: 'hidden' as const,
backgroundColor: theme.palette.background.default, backgroundColor: theme.palette.background.default,
color: theme.palette.text.primary, color: theme.palette.text.primary,
overflowY: 'auto' as 'auto', overflowY: 'auto' as const,
// Mobile: hide profile list to save space // Mobile: hide profile list to save space
[theme.breakpoints.down('md')]: { [theme.breakpoints.down('md')]: {
display: 'none' as 'none', display: 'none' as const,
}, },
}, },
right: { right: {
@@ -144,35 +145,31 @@ const styles = (theme: Theme) => ({
// Mobile: enable scrolling // Mobile: enable scrolling
[theme.breakpoints.down('md')]: { [theme.breakpoints.down('md')]: {
borderRadius: `${theme.shape.borderRadius}px`, borderRadius: `${theme.shape.borderRadius}px`,
overflowY: 'auto' as 'auto', overflowY: 'auto' as const,
}, },
}, },
connectionUri: { connectionUri: {
width: '27em', width: '27em',
textOverflow: 'ellipsis' as 'ellipsis', textOverflow: 'ellipsis' as const,
whiteSpace: 'nowrap' as 'nowrap', whiteSpace: 'nowrap' as const,
overflow: 'hidden' as 'hidden', overflow: 'hidden' as const,
color: theme.palette.text.secondary, color: theme.palette.text.secondary,
fontSize: '0.9em', fontSize: '0.9em',
marginLeft: theme.spacing(4), marginLeft: theme.spacing(4),
}, },
}) })
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => ({
return { visible: !state.connection.connected,
visible: !state.connection.connected, showAdvancedSettings: state.connectionManager.showAdvancedSettings,
showAdvancedSettings: state.connectionManager.showAdvancedSettings, showCertificateSettings: state.connectionManager.showCertificateSettings,
showCertificateSettings: state.connectionManager.showCertificateSettings, connection: state.connectionManager.selected
connection: state.connectionManager.selected ? state.connectionManager.connections[state.connectionManager.selected]
? state.connectionManager.connections[state.connectionManager.selected] : undefined,
: undefined, })
}
}
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: bindActionCreators(connectionManagerActions, dispatch),
actions: bindActionCreators(connectionManagerActions, dispatch), })
}
}
export default connect(mapStateToProps, mapDispatchToProps)(withStyles(styles)(ConnectionSetup) as any) export default connect(mapStateToProps, mapDispatchToProps)(withStyles(styles)(ConnectionSetup) as any)

View File

@@ -1,12 +1,12 @@
import * as React from 'react' import * as React from 'react'
import Add from '@mui/icons-material/Add' import Add from '@mui/icons-material/Add'
import { AppState } from '../../reducers'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { connectionManagerActions } from '../../actions'
import { IconButton, MenuItem, Select, SelectChangeEvent } from '@mui/material' import { IconButton, MenuItem, Select, SelectChangeEvent } from '@mui/material'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { connectionManagerActions } from '../../actions'
import { AppState } from '../../reducers'
const styles = (theme: Theme) => ({ const styles = (theme: Theme) => ({
container: { container: {
@@ -51,9 +51,8 @@ class MobileConnectionSelector extends React.PureComponent<Props, {}> {
this.props.actions.createConnection() this.props.actions.createConnection()
} }
private getConnectionDisplayName = (connection: { name?: string; host?: string }) => { private getConnectionDisplayName = (connection: { name?: string; host?: string }) =>
return connection.name || connection.host || 'Unnamed Connection' connection.name || connection.host || 'Unnamed Connection'
}
public render() { public render() {
const { classes, connections, currentConnectionId, isConnected, currentActiveConnectionId } = this.props const { classes, connections, currentConnectionId, isConnected, currentActiveConnectionId } = this.props
@@ -110,7 +109,7 @@ class MobileConnectionSelector extends React.PureComponent<Props, {}> {
} }
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => {
const connectionManager = state.connectionManager const { connectionManager } = state
const connections = const connections =
connectionManager && connectionManager.connections connectionManager && connectionManager.connections
? Object.values(connectionManager.connections).map(conn => ({ ? Object.values(connectionManager.connections).map(conn => ({
@@ -128,11 +127,9 @@ const mapStateToProps = (state: AppState) => {
} }
} }
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: bindActionCreators(connectionManagerActions, dispatch),
actions: bindActionCreators(connectionManagerActions, dispatch), })
}
}
// Using 'as any' here is consistent with other Material-UI + Redux connected components // Using 'as any' here is consistent with other Material-UI + Redux connected components
// in this codebase (see ConnectionSettings.tsx, ProfileList/index.tsx, ChartPanel/index.tsx) // in this codebase (see ConnectionSettings.tsx, ProfileList/index.tsx, ChartPanel/index.tsx)

View File

@@ -15,12 +15,10 @@ const styles = (theme: Theme) => ({
}, },
}) })
export const AddButton = withStyles(styles)((props: { classes: any; action: any }) => { export const AddButton = withStyles(styles)((props: { classes: any; action: any }) => (
return ( <span id="addProfileButton" style={{ marginRight: '12px' }}>
<span id="addProfileButton" style={{ marginRight: '12px' }}> <Fab size="small" color="secondary" aria-label="Add" className={props.classes.addButton} onClick={props.action}>
<Fab size="small" color="secondary" aria-label="Add" className={props.classes.addButton} onClick={props.action}> <Add className={props.classes.addIcon} />
<Add className={props.classes.addIcon} /> </Fab>
</Fab> </span>
</span> ))
)
})

View File

@@ -1,10 +1,10 @@
import React, { useCallback } from 'react' import React, { useCallback } from 'react'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { ListItem, Typography } from '@mui/material' import { ListItem, Typography } from '@mui/material'
import { toMqttConnection, ConnectionOptions } from '../../../model/ConnectionOptions'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { toMqttConnection, ConnectionOptions } from '../../../model/ConnectionOptions'
import { connectionActions, connectionManagerActions } from '../../../actions' import { connectionActions, connectionManagerActions } from '../../../actions'
export interface Props { export interface Props {
@@ -17,7 +17,7 @@ export interface Props {
classes: any classes: any
} }
const ConnectionItem = (props: Props) => { function ConnectionItem(props: Props) {
const connect = useCallback(() => { const connect = useCallback(() => {
const mqttOptions = toMqttConnection(props.connection) const mqttOptions = toMqttConnection(props.connection)
if (mqttOptions) { if (mqttOptions) {
@@ -28,7 +28,7 @@ const ConnectionItem = (props: Props) => {
const connection = props.connection.host && toMqttConnection(props.connection) const connection = props.connection.host && toMqttConnection(props.connection)
return ( return (
<ListItem <ListItem
button={true} button
selected={props.selected} selected={props.selected}
style={{ display: 'block' }} style={{ display: 'block' }}
onClick={() => props.actions.connectionManager.selectConnection(props.connection.id)} onClick={() => props.actions.connectionManager.selectConnection(props.connection.id)}
@@ -43,26 +43,24 @@ const ConnectionItem = (props: Props) => {
) )
} }
export const mapDispatchToProps = (dispatch: any) => { export const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { connection: bindActionCreators(connectionActions, dispatch),
connection: bindActionCreators(connectionActions, dispatch), connectionManager: bindActionCreators(connectionManagerActions, dispatch),
connectionManager: bindActionCreators(connectionManagerActions, dispatch), },
}, })
}
}
export const connectionItemStyle = (theme: Theme) => ({ export const connectionItemStyle = (theme: Theme) => ({
name: { name: {
width: '100%', width: '100%',
textOverflow: 'ellipsis' as 'ellipsis', textOverflow: 'ellipsis' as const,
whiteSpace: 'nowrap' as 'nowrap', whiteSpace: 'nowrap' as const,
overflow: 'hidden' as 'hidden', overflow: 'hidden' as const,
}, },
details: { details: {
width: '100%', width: '100%',
textOverflow: 'ellipsis' as 'ellipsis', textOverflow: 'ellipsis' as const,
whiteSpace: 'nowrap' as 'nowrap', whiteSpace: 'nowrap' as const,
overflow: 'hidden' as 'hidden', overflow: 'hidden' as const,
color: theme.palette.text.secondary, color: theme.palette.text.secondary,
fontSize: '0.7em', fontSize: '0.7em',
}, },

View File

@@ -1,18 +1,19 @@
import ConnectionItem from './ConnectionItem'
const ConnectionItemAny = ConnectionItem as any
import React from 'react' import React from 'react'
import { AddButton } from './AddButton'
import { AppState } from '../../../reducers'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { connectionManagerActions } from '../../../actions'
import { ConnectionOptions } from '../../../model/ConnectionOptions'
import { KeyCodes } from '../../../utils/KeyCodes'
import { List } from '@mui/material' import { List } from '@mui/material'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import ConnectionItem from './ConnectionItem'
import { AddButton } from './AddButton'
import { AppState } from '../../../reducers'
import { connectionManagerActions } from '../../../actions'
import { ConnectionOptions } from '../../../model/ConnectionOptions'
import { KeyCodes } from '../../../utils/KeyCodes'
import { useGlobalKeyEventHandler } from '../../../effects/useGlobalKeyEventHandler' import { useGlobalKeyEventHandler } from '../../../effects/useGlobalKeyEventHandler'
const ConnectionItemAny = ConnectionItem as any
interface Props { interface Props {
classes: any classes: any
selected?: string selected?: string
@@ -62,21 +63,17 @@ const styles = (theme: Theme) => ({
list: { list: {
marginTop: theme.spacing(1), marginTop: theme.spacing(1),
height: `calc(100% - ${theme.spacing(6)})`, height: `calc(100% - ${theme.spacing(6)})`,
overflowY: 'auto' as 'auto', overflowY: 'auto' as const,
}, },
}) })
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: bindActionCreators(connectionManagerActions, dispatch),
actions: bindActionCreators(connectionManagerActions, dispatch), })
}
}
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => ({
return { connections: state.connectionManager.connections,
connections: state.connectionManager.connections, selected: state.connectionManager.selected,
selected: state.connectionManager.selected, })
}
}
export default connect(mapStateToProps, mapDispatchToProps)(withStyles(styles)(ProfileList) as any) export default connect(mapStateToProps, mapDispatchToProps)(withStyles(styles)(ProfileList) as any)

View File

@@ -1,7 +1,5 @@
import React, { useCallback, useState } from 'react' import React, { useCallback, useState } from 'react'
import Delete from '@mui/icons-material/Delete' import Delete from '@mui/icons-material/Delete'
import { connectionManagerActions } from '../../actions'
import { ConnectionOptions } from '../../model/ConnectionOptions'
import { import {
IconButton, IconButton,
TableContainer, TableContainer,
@@ -16,6 +14,8 @@ import {
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { ConnectionOptions } from '../../model/ConnectionOptions'
import { connectionManagerActions } from '../../actions'
function Subscriptions(props: { function Subscriptions(props: {
classes: any classes: any
@@ -29,7 +29,7 @@ function Subscriptions(props: {
<Table size="small"> <Table size="small">
<TableHead> <TableHead>
<TableRow> <TableRow>
<TableCell align="left" padding="checkbox" className={classes.tableTitleCell}></TableCell> <TableCell align="left" padding="checkbox" className={classes.tableTitleCell} />
<TableCell className={classes.tableTitleCell}>Topic</TableCell> <TableCell className={classes.tableTitleCell}>Topic</TableCell>
<TableCell align="right" className={classes.tableTitleCell}> <TableCell align="right" className={classes.tableTitleCell}>
QoS QoS
@@ -38,7 +38,7 @@ function Subscriptions(props: {
</TableHead> </TableHead>
<TableBody> <TableBody>
{connection.subscriptions.map(subscription => ( {connection.subscriptions.map(subscription => (
<TableRow key={subscription.topic + '_qos_' + subscription.qos}> <TableRow key={`${subscription.topic}_qos_${subscription.qos}`}>
<TableCell align="right" className={classes.tableCell}> <TableCell align="right" className={classes.tableCell}>
<IconButton <IconButton
onClick={() => managerActions.deleteSubscription(subscription, connection.id)} onClick={() => managerActions.deleteSubscription(subscription, connection.id)}
@@ -62,11 +62,9 @@ function Subscriptions(props: {
) )
} }
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { managerActions: bindActionCreators(connectionManagerActions, dispatch),
managerActions: bindActionCreators(connectionManagerActions, dispatch), })
}
}
const styles = (theme: Theme) => ({ const styles = (theme: Theme) => ({
tableCell: { tableCell: {
@@ -80,7 +78,7 @@ const styles = (theme: Theme) => ({
}, },
topicList: { topicList: {
height: '196px', height: '196px',
overflowY: 'scroll' as 'scroll', overflowY: 'scroll' as const,
margin: `${theme.spacing(1)}px ${theme.spacing(1)}px 0 ${theme.spacing(1)}px`, margin: `${theme.spacing(1)}px ${theme.spacing(1)}px 0 ${theme.spacing(1)}px`,
backgroundColor: theme.palette.background.default, backgroundColor: theme.palette.background.default,
width: 'auto', width: 'auto',

View File

@@ -11,17 +11,13 @@ export function ToggleSwitch(props: { value: boolean; classes: any; toggle: () =
role="switch" role="switch"
aria-checked={value} aria-checked={value}
inputProps={{ inputProps={{
'aria-label': label 'aria-label': label,
}} }}
/> />
) )
return ( return (
<div className={classes.switch}> <div className={classes.switch}>
<FormControlLabel <FormControlLabel control={toggleSwitch} label={`${label} (${value ? 'On' : 'Off'})`} labelPlacement="bottom" />
control={toggleSwitch}
label={`${label} (${value ? 'On' : 'Off'})`}
labelPlacement="bottom"
/>
</div> </div>
) )
} }

View File

@@ -24,20 +24,20 @@ class Key extends React.Component<Props, {}> {
const style = (theme: Theme) => ({ const style = (theme: Theme) => ({
keyStyle: { keyStyle: {
display: 'inline-block' as 'inline-block', display: 'inline-block' as const,
width: '1em', width: '1em',
height: '1em', height: '1em',
backgroundColor: '#bbb', backgroundColor: '#bbb',
borderRadius: '10%', borderRadius: '10%',
verticalAlign: 'middle' as 'middle', verticalAlign: 'middle' as const,
textAlign: 'center' as 'center', textAlign: 'center' as const,
textShadow: '1px 1px rgba(255,255,255,0.45)', textShadow: '1px 1px rgba(255,255,255,0.45)',
boxShadow: '0.08em 0.15em 0.01em 0px rgba(100,100,100,0.75)', boxShadow: '0.08em 0.15em 0.01em 0px rgba(100,100,100,0.75)',
}, },
keyTextStyle: { keyTextStyle: {
marginTop: '0.65em', marginTop: '0.65em',
fontSize: '0.4em', fontSize: '0.4em',
fontWeight: 'bold' as 'bold', fontWeight: 'bold' as const,
}, },
}) })

View File

@@ -1,6 +1,7 @@
import * as React from 'react' import * as React from 'react'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
const cursor = require('./cursor.png') const cursor = require('./cursor.png')
interface State { interface State {
@@ -13,11 +14,18 @@ interface State {
class Demo extends React.Component<{ classes: any }, State> { class Demo extends React.Component<{ classes: any }, State> {
private timer: any private timer: any
private frameInterval = 20 private frameInterval = 20
constructor(props: any) { constructor(props: any) {
super(props) super(props)
this.state = { enabled: false, target: { x: 0, y: 0 }, position: { x: 0, y: 0 }, stepSizeX: 1, stepSizeY: 1 } this.state = {
enabled: false,
target: { x: 0, y: 0 },
position: { x: 0, y: 0 },
stepSizeX: 1,
stepSizeY: 1,
}
} }
private moveCloser(steps: number = 0) { private moveCloser(steps: number = 0) {
@@ -50,7 +58,12 @@ class Demo extends React.Component<{ classes: any }, State> {
;(window as any).demo.moveMouse = (x: number, y: number, animationTime: number) => { ;(window as any).demo.moveMouse = (x: number, y: number, animationTime: number) => {
const stepSizeX = Math.abs(this.state.position.x - x) / (animationTime / this.frameInterval) const stepSizeX = Math.abs(this.state.position.x - x) / (animationTime / this.frameInterval)
const stepSizeY = Math.abs(this.state.position.y - y) / (animationTime / this.frameInterval) const stepSizeY = Math.abs(this.state.position.y - y) / (animationTime / this.frameInterval)
this.setState({ stepSizeX, stepSizeY, enabled: true, target: { x, y } }) this.setState({
stepSizeX,
stepSizeY,
enabled: true,
target: { x, y },
})
this.moveCloser() this.moveCloser()
} }
} }
@@ -73,10 +86,10 @@ const style = (theme: Theme) => ({
cursor: { cursor: {
width: '32px', width: '32px',
height: '32px', height: '32px',
position: 'fixed' as 'fixed', position: 'fixed' as const,
zIndex: 1000000, zIndex: 1000000,
filter: theme.palette.mode === 'light' ? undefined : 'invert(100%)', filter: theme.palette.mode === 'light' ? undefined : 'invert(100%)',
pointerEvents: 'none' as 'none', pointerEvents: 'none' as const,
}, },
}) })

View File

@@ -11,6 +11,7 @@ interface State {
class Demo extends React.Component<{ classes: any }, State> { class Demo extends React.Component<{ classes: any }, State> {
private timer: any private timer: any
constructor(props: any) { constructor(props: any) {
super(props) super(props)
this.state = { location: 'bottom', keys: [] } this.state = { location: 'bottom', keys: [] }
@@ -44,7 +45,7 @@ class Demo extends React.Component<{ classes: any }, State> {
middle: -32, middle: -32,
} }
const style = { const style = {
position: 'fixed' as 'fixed', position: 'fixed' as const,
left: '5vw', left: '5vw',
zIndex: 1000000, zIndex: 1000000,
margin: '30vw auto 50vw', margin: '30vw auto 50vw',
@@ -52,7 +53,7 @@ class Demo extends React.Component<{ classes: any }, State> {
bottom: `${positions[this.state.location]}vh`, bottom: `${positions[this.state.location]}vh`,
} }
const style2 = { const style2 = {
textAlign: 'center' as 'center', textAlign: 'center' as const,
fontSize: '4em', fontSize: '4em',
color: 'white', color: 'white',
backgroundColor: 'rgba(0, 0, 0, 0.8)', backgroundColor: 'rgba(0, 0, 0, 0.8)',
@@ -67,9 +68,7 @@ class Demo extends React.Component<{ classes: any }, State> {
if (this.state.keys.length > 0) { if (this.state.keys.length > 0) {
keys = this.state.keys keys = this.state.keys
.map(key => [<Key key={key} keyboardKey={key} />]) .map(key => [<Key key={key} keyboardKey={key} />])
.reduce((prev, current) => { .reduce((prev, current) => [prev, '+' as any, current])
return [prev, '+' as any, current]
})
} }
return ( return (
@@ -86,7 +85,7 @@ class Demo extends React.Component<{ classes: any }, State> {
const style = (theme: Theme) => ({ const style = (theme: Theme) => ({
keysStyle: { keysStyle: {
fontSize: '1em', fontSize: '1em',
display: 'inline-block' as 'inline-block', display: 'inline-block' as const,
transform: 'translateY(0.3em) translateX(0.8em)', transform: 'translateY(0.3em) translateX(0.8em)',
}, },
}) })

View File

@@ -1,11 +1,12 @@
import * as React from 'react' import * as React from 'react'
import ShowText from './ShowText' import ShowText from './ShowText'
import Mouse from './Mouse' import Mouse from './Mouse'
let heapdump: any let heapdump: any
function writeHeapdump(path?: string) { function writeHeapdump(path?: string) {
if (!heapdump) { if (!heapdump) {
//<heapdump = require('heapdump') // <heapdump = require('heapdump')
} }
heapdump.writeSnapshot(path || `${Date.now()}.heapsnapshot`) heapdump.writeSnapshot(path || `${Date.now()}.heapsnapshot`)

View File

@@ -1,10 +1,10 @@
import * as React from 'react' import * as React from 'react'
import PersistentStorage from '../utils/PersistentStorage'
import SentimentDissatisfied from '@mui/icons-material/SentimentDissatisfied' import SentimentDissatisfied from '@mui/icons-material/SentimentDissatisfied'
import Warning from '@mui/icons-material/Warning' import Warning from '@mui/icons-material/Warning'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { Button, Modal, Paper, Toolbar, Typography } from '@mui/material' import { Button, Modal, Paper, Toolbar, Typography } from '@mui/material'
import PersistentStorage from '../utils/PersistentStorage'
interface State { interface State {
error?: Error error?: Error
@@ -19,6 +19,7 @@ class ErrorBoundary extends React.PureComponent<Props, State> {
public static getDerivedStateFromError(error: Error) { public static getDerivedStateFromError(error: Error) {
return { error } return { error }
} }
constructor(props: Props) { constructor(props: Props) {
super(props) super(props)
this.state = {} this.state = {}
@@ -45,7 +46,7 @@ class ErrorBoundary extends React.PureComponent<Props, State> {
const { classes } = this.props const { classes } = this.props
return ( return (
<Modal open={true} disableAutoFocus={true}> <Modal open disableAutoFocus>
<Paper className={classes.root}> <Paper className={classes.root}>
<Toolbar style={{ padding: '0' }}> <Toolbar style={{ padding: '0' }}>
<Typography className={classes.title} variant="h6" color="inherit"> <Typography className={classes.title} variant="h6" color="inherit">
@@ -101,17 +102,17 @@ const styles = (theme: Theme) => ({
title: { title: {
color: theme.palette.text.primary, color: theme.palette.text.primary,
margin: '0', margin: '0',
textAlign: 'center' as 'center', textAlign: 'center' as const,
}, },
textColor: { textColor: {
color: theme.palette.text.primary, color: theme.palette.text.primary,
userSelect: 'all' as 'all', userSelect: 'all' as const,
}, },
centered: { centered: {
textAlign: 'center' as 'center', textAlign: 'center' as const,
}, },
buttonPositioning: { buttonPositioning: {
textAlign: 'center' as 'center', textAlign: 'center' as const,
marginTop: theme.spacing(2), marginTop: theme.spacing(2),
}, },
}) })

View File

@@ -1,13 +1,13 @@
import * as React from 'react' import * as React from 'react'
import ChartPanel from '../ChartPanel'
import ReactSplitPaneImport from 'react-split-pane' import ReactSplitPaneImport from 'react-split-pane'
import { connect } from 'react-redux'
import { List } from 'immutable'
import { useResizeDetector } from 'react-resize-detector'
import ChartPanel from '../ChartPanel'
import Tree from '../Tree' import Tree from '../Tree'
import { AppState } from '../../reducers' import { AppState } from '../../reducers'
import { ChartParameters } from '../../reducers/Charts' import { ChartParameters } from '../../reducers/Charts'
import { connect } from 'react-redux'
import { List } from 'immutable'
import { Sidebar } from '../Sidebar' import { Sidebar } from '../Sidebar'
import { useResizeDetector } from 'react-resize-detector'
import MobileTabs from './MobileTabs' import MobileTabs from './MobileTabs'
import PublishTab from '../Sidebar/PublishTab' import PublishTab from '../Sidebar/PublishTab'
@@ -25,12 +25,32 @@ function ContentView(props: Props) {
// Use different defaults for mobile viewports (<=768px width) // Use different defaults for mobile viewports (<=768px width)
// Use state for mobile detection that updates on resize // Use state for mobile detection that updates on resize
const [isMobile, setIsMobile] = React.useState(() => typeof window !== 'undefined' && window.innerWidth <= 768) const [isMobile, setIsMobile] = React.useState(() => typeof window !== 'undefined' && window.innerWidth <= 768)
const [mobileTab, setMobileTab] = React.useState(0) // 0 = topics, 1 = details, 2 = publish, 3 = charts const [mobileTab, setMobileTab] = React.useState(0) // 0 = topics, 1 = details, 2 = publish (if shown), 3 = charts (or 2 if publish hidden)
const [height, setHeight] = React.useState<string | number>('100%') const [height, setHeight] = React.useState<string | number>('100%')
const [sidebarWidth, setSidebarWidth] = React.useState<string | number>(isMobile ? '100%' : '40%') const [sidebarWidth, setSidebarWidth] = React.useState<string | number>(isMobile ? '100%' : '40%')
const [detectedHeight, setDetectedHeight] = React.useState(0) const [detectedHeight, setDetectedHeight] = React.useState(0)
const [detectedSidebarWidth, setDetectedSidebarWidth] = React.useState(0) const [detectedSidebarWidth, setDetectedSidebarWidth] = React.useState(0)
// Check if publish pane should be hidden
const [hidePublishPane, setHidePublishPane] = React.useState(() =>
typeof window !== 'undefined' && (window as any).mqttExplorerUiConfig?.hidePublishPane || false
)
// Listen for ui-config updates
React.useEffect(() => {
const handleUiConfig = (event: CustomEvent) => {
const config = event.detail
if (config.hidePublishPane !== undefined) {
setHidePublishPane(config.hidePublishPane)
}
}
if (typeof window !== 'undefined') {
window.addEventListener('mqtt-ui-config', handleUiConfig as EventListener)
return () => window.removeEventListener('mqtt-ui-config', handleUiConfig as EventListener)
}
}, [])
// Update mobile state on resize // Update mobile state on resize
React.useEffect(() => { React.useEffect(() => {
const handleResize = () => { const handleResize = () => {
@@ -92,10 +112,14 @@ function ContentView(props: Props) {
// Expose tab switching functions for other components to call // Expose tab switching functions for other components to call
React.useEffect(() => { React.useEffect(() => {
if (typeof window !== 'undefined') { if (typeof window !== 'undefined') {
(window as any).switchToDetailsTab = () => setMobileTab(1) ;(window as any).switchToDetailsTab = () => setMobileTab(1)
(window as any).switchToTopicsTab = () => setMobileTab(0) ;(window as any).switchToTopicsTab = () => setMobileTab(0)
;(window as any).switchToPublishTab = () => setMobileTab(2) ;(window as any).switchToPublishTab = () => {
;(window as any).switchToChartsTab = () => setMobileTab(3) if (!hidePublishPane) {
setMobileTab(2)
}
}
;(window as any).switchToChartsTab = () => setMobileTab(hidePublishPane ? 2 : 3)
} }
return () => { return () => {
if (typeof window !== 'undefined') { if (typeof window !== 'undefined') {
@@ -107,6 +131,19 @@ function ContentView(props: Props) {
} }
}, []) }, [])
// Scroll to selected topic when returning to tree tab
React.useEffect(() => {
if (mobileTab === 0) {
// Delay to ensure DOM is rendered
setTimeout(() => {
const selectedNode = document.querySelector('.tree .selected')
if (selectedNode) {
selectedNode.scrollIntoView({ behavior: 'smooth', block: 'center' })
}
}, 100)
}
}, [mobileTab])
const mobileContainerStyle: React.CSSProperties = { const mobileContainerStyle: React.CSSProperties = {
display: 'flex', display: 'flex',
flexDirection: 'column', flexDirection: 'column',
@@ -148,32 +185,26 @@ function ContentView(props: Props) {
return ( return (
<div style={mobileContainerStyle}> <div style={mobileContainerStyle}>
<MobileTabs value={mobileTab} onChange={setMobileTab} /> <MobileTabs value={mobileTab} onChange={setMobileTab} hidePublishPane={hidePublishPane} />
<div style={tabContentStyle}> <div style={tabContentStyle}>
{/* Topics tab */} {/* Topics tab - keep mounted, toggle visibility */}
{mobileTab === 0 && ( <div style={{ ...treeContainerStyle, display: mobileTab === 0 ? 'block' : 'none' }}>
<div style={treeContainerStyle}> <Tree />
<Tree /> </div>
</div> {/* Details tab - keep mounted, toggle visibility */}
)} <div style={{ ...sidebarContainerStyle, display: mobileTab === 1 ? 'block' : 'none' }}>
{/* Details tab */} <Sidebar connectionId={props.connectionId} />
{mobileTab === 1 && ( </div>
<div style={sidebarContainerStyle}> {/* Publish tab - conditionally rendered */}
<Sidebar connectionId={props.connectionId} /> {!hidePublishPane && (
</div> <div style={{ ...sidebarContainerStyle, display: mobileTab === 2 ? 'block' : 'none' }}>
)}
{/* Publish tab */}
{mobileTab === 2 && (
<div style={sidebarContainerStyle}>
<PublishTab connectionId={props.connectionId} /> <PublishTab connectionId={props.connectionId} />
</div> </div>
)} )}
{/* Charts tab */} {/* Charts tab - adjust index based on publish visibility */}
{mobileTab === 3 && ( <div style={{ ...sidebarContainerStyle, display: mobileTab === (hidePublishPane ? 2 : 3) ? 'block' : 'none' }}>
<div style={sidebarContainerStyle}> <ChartPanel />
<ChartPanel /> </div>
</div>
)}
</div> </div>
</div> </div>
) )
@@ -192,7 +223,7 @@ function ContentView(props: Props) {
size={sidebarWidth} size={sidebarWidth}
onChange={(size: number) => setSidebarWidth(size)} onChange={(size: number) => setSidebarWidth(size)}
onDragFinished={closeSidebarCompletelyIfItSitsOnTheEdge} onDragFinished={closeSidebarCompletelyIfItSitsOnTheEdge}
allowResize={true} allowResize
style={{ height: '100%' }} style={{ height: '100%' }}
pane1Style={{ overflowX: 'hidden' }} pane1Style={{ overflowX: 'hidden' }}
resizerStyle={{ height: '100%' }} resizerStyle={{ height: '100%' }}
@@ -203,7 +234,7 @@ function ContentView(props: Props) {
split="horizontal" split="horizontal"
minSize={0} minSize={0}
size={height} size={height}
allowResize={true} allowResize
style={{ height: 'calc(100vh - 64px)' }} style={{ height: 'calc(100vh - 64px)' }}
pane1Style={{ maxHeight: '100%' }} pane1Style={{ maxHeight: '100%' }}
pane2Style={{ borderTop: '1px solid #999', display: 'flex' }} pane2Style={{ borderTop: '1px solid #999', display: 'flex' }}
@@ -212,7 +243,15 @@ function ContentView(props: Props) {
> >
<Tree /> <Tree />
{/** Passing height constraints via flex options down */} {/** Passing height constraints via flex options down */}
<div ref={heightRef} style={{ flex: 1, display: 'flex', height: '100%', width: '100%' }}> <div
ref={heightRef}
style={{
flex: 1,
display: 'flex',
height: '100%',
width: '100%',
}}
>
{/** Resize detector must not be in the scroll zone, it needs to detect actual available size */} {/** Resize detector must not be in the scroll zone, it needs to detect actual available size */}
<ChartPanel /> <ChartPanel />
</div> </div>
@@ -225,7 +264,7 @@ function ContentView(props: Props) {
minWidth: '250px', minWidth: '250px',
height: '100%', height: '100%',
overflowY: 'auto', overflowY: 'auto',
overflowX: 'hidden' overflowX: 'hidden',
}} }}
> >
<Sidebar connectionId={props.connectionId} /> <Sidebar connectionId={props.connectionId} />
@@ -237,10 +276,8 @@ function ContentView(props: Props) {
) )
} }
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => ({
return { chartPanelItems: state.charts.get('charts'),
chartPanelItems: state.charts.get('charts'), })
}
}
export default connect(mapStateToProps)(ContentView) export default connect(mapStateToProps)(ContentView)

View File

@@ -11,6 +11,7 @@ interface Props {
classes: any classes: any
value: number value: number
onChange: (value: number) => void onChange: (value: number) => void
hidePublishPane?: boolean
} }
function MobileTabs(props: Props) { function MobileTabs(props: Props) {
@@ -18,6 +19,8 @@ function MobileTabs(props: Props) {
props.onChange(newValue) props.onChange(newValue)
} }
const hidePublishPane = props.hidePublishPane || false
return ( return (
<Box className={props.classes.root} role="navigation" aria-label="Mobile navigation tabs"> <Box className={props.classes.root} role="navigation" aria-label="Mobile navigation tabs">
<Tabs <Tabs
@@ -26,7 +29,7 @@ function MobileTabs(props: Props) {
variant="fullWidth" variant="fullWidth"
indicatorColor="primary" indicatorColor="primary"
textColor="primary" textColor="primary"
aria-label="Topics, Details, Publish and Charts tabs" aria-label={hidePublishPane ? "Topics, Details and Charts tabs" : "Topics, Details, Publish and Charts tabs"}
> >
<Tab <Tab
icon={<AccountTreeIcon />} icon={<AccountTreeIcon />}
@@ -44,21 +47,23 @@ function MobileTabs(props: Props) {
id="mobile-tab-1" id="mobile-tab-1"
aria-controls="mobile-tabpanel-1" aria-controls="mobile-tabpanel-1"
/> />
<Tab {!hidePublishPane && (
icon={<SendIcon />} <Tab
label="Publish" icon={<SendIcon />}
data-testid="mobile-tab-publish" label="Publish"
aria-label="Publish messages" data-testid="mobile-tab-publish"
id="mobile-tab-2" aria-label="Publish messages"
aria-controls="mobile-tabpanel-2" id="mobile-tab-2"
/> aria-controls="mobile-tabpanel-2"
/>
)}
<Tab <Tab
icon={<ShowChartIcon />} icon={<ShowChartIcon />}
label="Charts" label={hidePublishPane ? "Charts" : "Charts"}
data-testid="mobile-tab-charts" data-testid="mobile-tab-charts"
aria-label="View charts" aria-label="View charts"
id="mobile-tab-3" id={hidePublishPane ? "mobile-tab-2" : "mobile-tab-3"}
aria-controls="mobile-tabpanel-3" aria-controls={hidePublishPane ? "mobile-tabpanel-2" : "mobile-tabpanel-3"}
/> />
</Tabs> </Tabs>
</Box> </Box>
@@ -69,7 +74,7 @@ const styles = (theme: Theme) => ({
root: { root: {
borderBottom: `1px solid ${theme.palette.divider}`, borderBottom: `1px solid ${theme.palette.divider}`,
backgroundColor: theme.palette.background.paper, backgroundColor: theme.palette.background.paper,
position: 'relative' as 'relative', position: 'relative' as const,
zIndex: 1, zIndex: 1,
minHeight: '56px', // Touch-friendly tab height minHeight: '56px', // Touch-friendly tab height
'& .MuiTab-root': { '& .MuiTab-root': {
@@ -77,7 +82,7 @@ const styles = (theme: Theme) => ({
fontSize: '16px', // Prevent iOS zoom fontSize: '16px', // Prevent iOS zoom
fontWeight: 500, fontWeight: 500,
padding: theme.spacing(1.5, 2), padding: theme.spacing(1.5, 2),
textTransform: 'none' as 'none', // Better readability textTransform: 'none' as const, // Better readability
'&:active': { '&:active': {
opacity: 0.7, // Touch feedback opacity: 0.7, // Touch feedback
}, },

View File

@@ -30,8 +30,8 @@ class Notification extends React.PureComponent<Props, {}> {
public render() { public render() {
const snackbarAnchor = { const snackbarAnchor = {
vertical: 'bottom' as 'bottom', vertical: 'bottom' as const,
horizontal: 'left' as 'left', horizontal: 'left' as const,
} }
return ( return (

View File

@@ -1,19 +1,19 @@
import * as React from 'react' import * as React from 'react'
import * as q from '../../../../backend/src/Model'
import CustomIconButton from '../helper/CustomIconButton'
import Pause from '@mui/icons-material/PauseCircleFilled' import Pause from '@mui/icons-material/PauseCircleFilled'
import Resume from '@mui/icons-material/PlayArrow' import Resume from '@mui/icons-material/PlayArrow'
import { AppState } from '../../reducers'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { treeActions } from '../../actions'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import * as q from '../../../../backend/src/Model'
import CustomIconButton from '../helper/CustomIconButton'
import { treeActions } from '../../actions'
import { AppState } from '../../reducers'
const styles = (theme: Theme) => ({ const styles = (theme: Theme) => ({
icon: { icon: {
color: theme.palette.primary.contrastText, color: theme.palette.primary.contrastText,
verticalAlign: 'middle' as 'middle', verticalAlign: 'middle' as const,
}, },
bufferStats: { bufferStats: {
minWidth: '8em', minWidth: '8em',
@@ -31,6 +31,7 @@ interface Props {
class PauseButton extends React.PureComponent<Props, { changes: number }> { class PauseButton extends React.PureComponent<Props, { changes: number }> {
private timer?: any private timer?: any
constructor(props: Props) { constructor(props: Props) {
super(props) super(props)
this.state = { changes: 0 } this.state = { changes: 0 }
@@ -88,19 +89,15 @@ class PauseButton extends React.PureComponent<Props, { changes: number }> {
} }
} }
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => ({
return { paused: state.tree.get('paused'),
paused: state.tree.get('paused'), tree: state.tree.get('tree'),
tree: state.tree.get('tree'), })
}
}
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { tree: bindActionCreators(treeActions, dispatch),
tree: bindActionCreators(treeActions, dispatch), },
}, })
}
}
export default connect(mapStateToProps, mapDispatchToProps)(withStyles(styles)(PauseButton) as any) export default connect(mapStateToProps, mapDispatchToProps)(withStyles(styles)(PauseButton) as any)

View File

@@ -1,13 +1,13 @@
import React, { useCallback, useState, useRef } from 'react' import React, { useCallback, useState, useRef } from 'react'
import ClearAdornment from '../helper/ClearAdornment'
import Search from '@mui/icons-material/Search' import Search from '@mui/icons-material/Search'
import { AppState } from '../../reducers'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { InputBase } from '@mui/material' import { InputBase } from '@mui/material'
import { settingsActions } from '../../actions'
import { alpha as fade, Theme } from '@mui/material/styles' import { alpha as fade, Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { settingsActions } from '../../actions'
import { AppState } from '../../reducers'
import ClearAdornment from '../helper/ClearAdornment'
import { useGlobalKeyEventHandler } from '../../effects/useGlobalKeyEventHandler' import { useGlobalKeyEventHandler } from '../../effects/useGlobalKeyEventHandler'
import { KeyCodes } from '../../utils/KeyCodes' import { KeyCodes } from '../../utils/KeyCodes'
@@ -28,7 +28,7 @@ function SearchBar(props: {
// On mobile, switch to Topics tab when search is focused // On mobile, switch to Topics tab when search is focused
if (typeof window !== 'undefined' && window.innerWidth <= 768) { if (typeof window !== 'undefined' && window.innerWidth <= 768) {
if ((window as any).switchToTopicsTab) { if ((window as any).switchToTopicsTab) {
(window as any).switchToTopicsTab() ;(window as any).switchToTopicsTab()
} }
} }
}, []) }, [])
@@ -90,24 +90,20 @@ function SearchBar(props: {
) )
} }
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => ({
return { topicFilter: state.settings.get('topicFilter'),
topicFilter: state.settings.get('topicFilter'), hasConnection: Boolean(state.connection.connectionId),
hasConnection: Boolean(state.connection.connectionId), })
}
}
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { settings: bindActionCreators(settingsActions, dispatch),
settings: bindActionCreators(settingsActions, dispatch), },
}, })
}
}
const styles = (theme: Theme) => ({ const styles = (theme: Theme) => ({
search: { search: {
position: 'relative' as 'relative', position: 'relative' as const,
borderRadius: theme.shape.borderRadius, borderRadius: theme.shape.borderRadius,
backgroundColor: fade(theme.palette.common.white, 0.15), backgroundColor: fade(theme.palette.common.white, 0.15),
'&:hover': { '&:hover': {
@@ -122,21 +118,21 @@ const styles = (theme: Theme) => ({
maxWidth: '30%', maxWidth: '30%',
marginLeft: theme.spacing(4), marginLeft: theme.spacing(4),
width: 'auto' as 'auto', width: 'auto' as const,
}, },
[theme.breakpoints.up(750)]: { [theme.breakpoints.up(750)]: {
marginLeft: theme.spacing(4), marginLeft: theme.spacing(4),
width: 'auto' as 'auto', width: 'auto' as const,
}, },
}, },
searchIcon: { searchIcon: {
width: theme.spacing(6), width: theme.spacing(6),
height: '100%', height: '100%',
position: 'absolute' as 'absolute', position: 'absolute' as const,
pointerEvents: 'none' as 'none', pointerEvents: 'none' as const,
display: 'flex' as 'flex', display: 'flex' as const,
alignItems: 'center' as 'center', alignItems: 'center' as const,
justifyContent: 'center' as 'center', justifyContent: 'center' as const,
}, },
inputRoot: { inputRoot: {
color: `${theme.palette.common.white} !important`, // Ensure white text color with high specificity color: `${theme.palette.common.white} !important`, // Ensure white text color with high specificity

View File

@@ -1,35 +1,36 @@
import * as React from 'react' import * as React from 'react'
import CloudOff from '@mui/icons-material/CloudOff' import CloudOff from '@mui/icons-material/CloudOff'
import Logout from '@mui/icons-material/Logout' import Logout from '@mui/icons-material/Logout'
import ConnectionHealthIndicator from '../helper/ConnectionHealthIndicator'
const ConnectionHealthIndicatorAny = ConnectionHealthIndicator as any
import Menu from '@mui/icons-material/Menu' import Menu from '@mui/icons-material/Menu'
import PauseButton from './PauseButton'
import SearchBar from './SearchBar'
import { AppBar, Button, IconButton, Toolbar, Typography } from '@mui/material' import { AppBar, Button, IconButton, Toolbar, Typography } from '@mui/material'
import { AppState } from '../../reducers'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { connectionActions, globalActions, settingsActions } from '../../actions'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { connectionActions, globalActions, settingsActions } from '../../actions'
import { AppState } from '../../reducers'
import SearchBar from './SearchBar'
import PauseButton from './PauseButton'
import ConnectionHealthIndicator from '../helper/ConnectionHealthIndicator'
import { isBrowserMode } from '../../utils/browserMode' import { isBrowserMode } from '../../utils/browserMode'
import { useAuth } from '../../contexts/AuthContext' import { useAuth } from '../../contexts/AuthContext'
const ConnectionHealthIndicatorAny = ConnectionHealthIndicator as any
const styles = (theme: Theme) => ({ const styles = (theme: Theme) => ({
title: { title: {
display: 'none' as 'none', display: 'none' as const,
[theme.breakpoints.up(750)]: { [theme.breakpoints.up(750)]: {
display: 'block' as 'block', display: 'block' as const,
}, },
[theme.breakpoints.up('md')]: { [theme.breakpoints.up('md')]: {
display: 'block' as 'block', display: 'block' as const,
}, },
whiteSpace: 'nowrap' as 'nowrap', whiteSpace: 'nowrap' as const,
}, },
disconnectIcon: { disconnectIcon: {
[theme.breakpoints.down('xs')]: { [theme.breakpoints.down('xs')]: {
display: 'none' as 'none', display: 'none' as const,
}, },
marginRight: '8px', marginRight: '8px',
paddingLeft: '8px', paddingLeft: '8px',
@@ -42,14 +43,14 @@ const styles = (theme: Theme) => ({
margin: 'auto 8px auto auto', margin: 'auto 8px auto auto',
// Hide on mobile (<=768px) // Hide on mobile (<=768px)
[theme.breakpoints.down('md')]: { [theme.breakpoints.down('md')]: {
display: 'none' as 'none', display: 'none' as const,
}, },
}, },
logout: { logout: {
margin: 'auto 0 auto 8px', margin: 'auto 0 auto 8px',
// Hide on mobile (<=768px) // Hide on mobile (<=768px)
[theme.breakpoints.down('md')]: { [theme.breakpoints.down('md')]: {
display: 'none' as 'none', display: 'none' as const,
}, },
}, },
disconnectLabel: { disconnectLabel: {
@@ -117,7 +118,7 @@ class TitleBar extends React.PureComponent<Props, {}> {
Disconnect <CloudOff className={classes.disconnectIcon} /> Disconnect <CloudOff className={classes.disconnectIcon} />
</Button> </Button>
<LogoutButton classes={classes} onLogout={this.handleLogout} /> <LogoutButton classes={classes} onLogout={this.handleLogout} />
<ConnectionHealthIndicatorAny withBackground={true} /> <ConnectionHealthIndicatorAny withBackground />
</Toolbar> </Toolbar>
</AppBar> </AppBar>
) )
@@ -133,30 +134,22 @@ function LogoutButton({ classes, onLogout }: { classes: any; onLogout: () => voi
} }
return ( return (
<Button <Button className={classes.logout} sx={{ color: 'primary.contrastText' }} onClick={onLogout}>
className={classes.logout}
sx={{ color: 'primary.contrastText' }}
onClick={onLogout}
>
Logout <Logout className={classes.disconnectIcon} /> Logout <Logout className={classes.disconnectIcon} />
</Button> </Button>
) )
} }
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => ({
return { topicFilter: state.settings.get('topicFilter'),
topicFilter: state.settings.get('topicFilter'), })
}
}
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { settings: bindActionCreators(settingsActions, dispatch),
settings: bindActionCreators(settingsActions, dispatch), global: bindActionCreators(globalActions, dispatch),
global: bindActionCreators(globalActions, dispatch), connection: bindActionCreators(connectionActions, dispatch),
connection: bindActionCreators(connectionActions, dispatch), },
}, })
}
}
export default connect(mapStateToProps, mapDispatchToProps)(withStyles(styles)(TitleBar)) export default connect(mapStateToProps, mapDispatchToProps)(withStyles(styles)(TitleBar))

View File

@@ -27,10 +27,7 @@ describe('LoginDialog Security Tests', () => {
const mockLogin = () => {} const mockLogin = () => {}
const errorMessage = 'Invalid credentials' const errorMessage = 'Invalid credentials'
renderWithProviders( renderWithProviders(<LoginDialog open onLogin={mockLogin} error={errorMessage} />, { withTheme: true })
<LoginDialog open={true} onLogin={mockLogin} error={errorMessage} />,
{ withTheme: true }
)
// Verify error is visible to user // Verify error is visible to user
const errorElement = getByText(errorMessage) const errorElement = getByText(errorMessage)
@@ -41,10 +38,7 @@ describe('LoginDialog Security Tests', () => {
const mockLogin = () => {} const mockLogin = () => {}
const errorMessage = 'Too many failed authentication attempts. Please wait 30 seconds before trying again.' const errorMessage = 'Too many failed authentication attempts. Please wait 30 seconds before trying again.'
renderWithProviders( renderWithProviders(<LoginDialog open onLogin={mockLogin} error={errorMessage} />, { withTheme: true })
<LoginDialog open={true} onLogin={mockLogin} error={errorMessage} />,
{ withTheme: true }
)
// Verify rate limiting error is visible to user // Verify rate limiting error is visible to user
expect(getByText('Too many failed authentication attempts')).to.exist expect(getByText('Too many failed authentication attempts')).to.exist
@@ -54,10 +48,7 @@ describe('LoginDialog Security Tests', () => {
const mockLogin = () => {} const mockLogin = () => {}
const errorMessage = 'Please enter your username and password.' const errorMessage = 'Please enter your username and password.'
renderWithProviders( renderWithProviders(<LoginDialog open onLogin={mockLogin} error={errorMessage} />, { withTheme: true })
<LoginDialog open={true} onLogin={mockLogin} error={errorMessage} />,
{ withTheme: true }
)
// Verify auth required message is visible to user // Verify auth required message is visible to user
expect(getByText('Please enter your username and password.')).to.exist expect(getByText('Please enter your username and password.')).to.exist
@@ -67,10 +58,7 @@ describe('LoginDialog Security Tests', () => {
const mockLogin = () => {} const mockLogin = () => {}
const errorMessage = 'Authentication failed. Please try again.' const errorMessage = 'Authentication failed. Please try again.'
renderWithProviders( renderWithProviders(<LoginDialog open onLogin={mockLogin} error={errorMessage} />, { withTheme: true })
<LoginDialog open={true} onLogin={mockLogin} error={errorMessage} />,
{ withTheme: true }
)
// Verify generic error is visible to user // Verify generic error is visible to user
expect(getByText('Authentication failed. Please try again.')).to.exist expect(getByText('Authentication failed. Please try again.')).to.exist
@@ -82,10 +70,9 @@ describe('LoginDialog Security Tests', () => {
const mockLogin = () => {} const mockLogin = () => {}
const waitTime = 30 const waitTime = 30
renderWithProviders( renderWithProviders(<LoginDialog open onLogin={mockLogin} waitTimeSeconds={waitTime} />, {
<LoginDialog open={true} onLogin={mockLogin} waitTimeSeconds={waitTime} />, withTheme: true,
{ withTheme: true } })
)
// Verify button is disabled to prevent further attempts // Verify button is disabled to prevent further attempts
const buttons = Array.from(document.querySelectorAll('button')) const buttons = Array.from(document.querySelectorAll('button'))
@@ -98,10 +85,9 @@ describe('LoginDialog Security Tests', () => {
const mockLogin = () => {} const mockLogin = () => {}
const waitTime = 30 const waitTime = 30
renderWithProviders( renderWithProviders(<LoginDialog open onLogin={mockLogin} waitTimeSeconds={waitTime} />, {
<LoginDialog open={true} onLogin={mockLogin} waitTimeSeconds={waitTime} />, withTheme: true,
{ withTheme: true } })
)
// Verify inputs are disabled to prevent modification during lockout // Verify inputs are disabled to prevent modification during lockout
const usernameInput = getByTestId('username-input')?.querySelector('input') const usernameInput = getByTestId('username-input')?.querySelector('input')
@@ -115,10 +101,9 @@ describe('LoginDialog Security Tests', () => {
const mockLogin = () => {} const mockLogin = () => {}
const waitTime = 30 const waitTime = 30
renderWithProviders( renderWithProviders(<LoginDialog open onLogin={mockLogin} waitTimeSeconds={waitTime} />, {
<LoginDialog open={true} onLogin={mockLogin} waitTimeSeconds={waitTime} />, withTheme: true,
{ withTheme: true } })
)
// Verify countdown is visible to inform user of lockout duration // Verify countdown is visible to inform user of lockout duration
const countdownElement = getByText('Please wait') const countdownElement = getByText('Please wait')
@@ -131,10 +116,9 @@ describe('LoginDialog Security Tests', () => {
const errorMessage = 'Too many failed authentication attempts. Please wait 30 seconds before trying again.' const errorMessage = 'Too many failed authentication attempts. Please wait 30 seconds before trying again.'
const waitTime = 30 const waitTime = 30
renderWithProviders( renderWithProviders(<LoginDialog open onLogin={mockLogin} error={errorMessage} waitTimeSeconds={waitTime} />, {
<LoginDialog open={true} onLogin={mockLogin} error={errorMessage} waitTimeSeconds={waitTime} />, withTheme: true,
{ withTheme: true } })
)
// Verify both error and countdown are visible // Verify both error and countdown are visible
expect(getByText(errorMessage)).to.exist expect(getByText(errorMessage)).to.exist
@@ -146,10 +130,7 @@ describe('LoginDialog Security Tests', () => {
it('should require both username and password fields to be present', () => { it('should require both username and password fields to be present', () => {
const mockLogin = () => {} const mockLogin = () => {}
renderWithProviders( renderWithProviders(<LoginDialog open onLogin={mockLogin} />, { withTheme: true })
<LoginDialog open={true} onLogin={mockLogin} />,
{ withTheme: true }
)
// Verify both credential fields exist and are required // Verify both credential fields exist and are required
const usernameInput = getByTestId('username-input') const usernameInput = getByTestId('username-input')
@@ -162,10 +143,7 @@ describe('LoginDialog Security Tests', () => {
it('should require password field to be masked', () => { it('should require password field to be masked', () => {
const mockLogin = () => {} const mockLogin = () => {}
renderWithProviders( renderWithProviders(<LoginDialog open onLogin={mockLogin} />, { withTheme: true })
<LoginDialog open={true} onLogin={mockLogin} />,
{ withTheme: true }
)
// Verify password is masked (type="password") for security // Verify password is masked (type="password") for security
const passwordInput = getByTestId('password-input')?.querySelector('input') const passwordInput = getByTestId('password-input')?.querySelector('input')
@@ -179,10 +157,7 @@ describe('LoginDialog Security Tests', () => {
// Error doesn't distinguish between invalid username vs invalid password // Error doesn't distinguish between invalid username vs invalid password
const errorMessage = 'Invalid credentials' const errorMessage = 'Invalid credentials'
renderWithProviders( renderWithProviders(<LoginDialog open onLogin={mockLogin} error={errorMessage} />, { withTheme: true })
<LoginDialog open={true} onLogin={mockLogin} error={errorMessage} />,
{ withTheme: true }
)
// Verify error doesn't leak whether username or password was wrong // Verify error doesn't leak whether username or password was wrong
const errorElement = getByText(errorMessage) const errorElement = getByText(errorMessage)
@@ -195,10 +170,7 @@ describe('LoginDialog Security Tests', () => {
const mockLogin = () => {} const mockLogin = () => {}
const errorMessage = 'Invalid credentials' const errorMessage = 'Invalid credentials'
renderWithProviders( renderWithProviders(<LoginDialog open onLogin={mockLogin} error={errorMessage} />, { withTheme: true })
<LoginDialog open={true} onLogin={mockLogin} error={errorMessage} />,
{ withTheme: true }
)
// Verify error doesn't contain sensitive data // Verify error doesn't contain sensitive data
const errorElement = getByText(errorMessage) const errorElement = getByText(errorMessage)

View File

@@ -57,7 +57,15 @@ export function LoginDialog(props: LoginDialogProps) {
const isDisabled = countdown !== undefined && countdown > 0 const isDisabled = countdown !== undefined && countdown > 0
return ( return (
<Dialog open={props.open} disableEscapeKeyDown onClose={(event, reason) => { if (reason !== 'backdropClick') { /* Allow closing only via escape if needed */ } }}> <Dialog
open={props.open}
disableEscapeKeyDown
onClose={(event, reason) => {
if (reason !== 'backdropClick') {
/* Allow closing only via escape if needed */
}
}}
>
<DialogTitle>Login to MQTT Explorer</DialogTitle> <DialogTitle>Login to MQTT Explorer</DialogTitle>
<DialogContent> <DialogContent>
{props.error && ( {props.error && (

View File

@@ -1,9 +1,9 @@
import * as React from 'react' import * as React from 'react'
import { TextField, MenuItem, Tooltip } from '@mui/material' import { TextField, MenuItem, Tooltip } from '@mui/material'
import { QoS } from '../../../backend/src/DataSource/MqttSource' import { QoS } from 'mqtt-explorer-backend/src/DataSource/MqttSource'
export function QosSelect(props: { selected: QoS; onChange: (value: QoS) => void; label?: string }) { export function QosSelect(props: { selected: QoS; onChange: (value: QoS) => void; label?: string }) {
const tooltipStyle = { textAlign: 'center' as 'center', width: '100%' } const tooltipStyle = { textAlign: 'center' as const, width: '100%' }
const itemStyle = { padding: '0' } const itemStyle = { padding: '0' }
const onChangeQos = React.useCallback( const onChangeQos = React.useCallback(
@@ -19,7 +19,7 @@ export function QosSelect(props: { selected: QoS; onChange: (value: QoS) => void
return ( return (
<TextField <TextField
select={true} select
label={props.label} label={props.label}
value={props.selected} value={props.selected}
margin="normal" margin="normal"

View File

@@ -1,9 +1,17 @@
import * as React from 'react' import * as React from 'react'
import { InputLabel, Switch, Theme, Tooltip } from '@mui/material' import { InputLabel, Switch, Theme, Tooltip } from '@mui/material'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
const sha1 = require('sha1') const sha1 = require('sha1')
function BooleanSwitch(props: { title: string; value: boolean; tooltip: string; action: () => void; classes: any; 'data-testid'?: string }) { function BooleanSwitch(props: {
title: string
value: boolean
tooltip: string
action: () => void
classes: any
'data-testid'?: string
}) {
const { tooltip, value, action, title, classes } = props const { tooltip, value, action, title, classes } = props
const clickHandler = (e: React.MouseEvent) => { const clickHandler = (e: React.MouseEvent) => {

View File

@@ -1,14 +1,15 @@
import * as q from '../../../../backend/src/Model'
import React, { useMemo } from 'react' import React, { useMemo } from 'react'
import { AppState } from '../../reducers'
import { Base64Message } from '../../../../backend/src/Model/Base64Message'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { TopicViewModel } from '../../model/TopicViewModel'
import { Typography } from '@mui/material' import { Typography } from '@mui/material'
import * as q from '../../../../backend/src/Model'
import { Base64Message } from '../../../../backend/src/Model/Base64Message'
import { TopicViewModel } from '../../model/TopicViewModel'
import { AppState } from '../../reducers'
import { usePollingToFetchTreeNode } from '../helper/usePollingToFetchTreeNode' import { usePollingToFetchTreeNode } from '../helper/usePollingToFetchTreeNode'
import { useUpdateComponentWhenNodeUpdates } from '../helper/useUpdateComponentWhenNodeUpdates' import { useUpdateComponentWhenNodeUpdates } from '../helper/useUpdateComponentWhenNodeUpdates'
const abbreviate = require('number-abbreviate') const abbreviate = require('number-abbreviate')
interface Stats { interface Stats {
@@ -37,7 +38,7 @@ function BrokerStatistics(props: Props) {
useUpdateComponentWhenNodeUpdates(sysTopic) useUpdateComponentWhenNodeUpdates(sysTopic)
return useMemo(() => { return useMemo(() => {
if (!Boolean(sysTopic)) { if (!sysTopic) {
return null return null
} }
@@ -96,11 +97,9 @@ function BrokerStatistics(props: Props) {
}, [sysTopic && sysTopic.lastUpdate, props.classes]) }, [sysTopic && sysTopic.lastUpdate, props.classes])
} }
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => ({
return { tree: state.connection.tree,
tree: state.connection.tree, })
}
}
export default withStyles(styles)(connect(mapStateToProps)(BrokerStatistics)) export default withStyles(styles)(connect(mapStateToProps)(BrokerStatistics))

View File

@@ -1,21 +1,12 @@
import * as React from 'react' import * as React from 'react'
import BooleanSwitch from './BooleanSwitch'
import BrokerStatistics from './BrokerStatistics'
import ChevronRight from '@mui/icons-material/ChevronRight' import ChevronRight from '@mui/icons-material/ChevronRight'
import CloudOff from '@mui/icons-material/CloudOff' import CloudOff from '@mui/icons-material/CloudOff'
import Logout from '@mui/icons-material/Logout' import Logout from '@mui/icons-material/Logout'
import TimeLocale from './TimeLocale'
import { AppState } from '../../reducers'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { globalActions, settingsActions, connectionActions } from '../../actions'
import { shell } from 'electron' import { shell } from 'electron'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { TopicOrder } from '../../reducers/Settings'
import { isBrowserMode } from '../../utils/browserMode'
import { useAuth } from '../../contexts/AuthContext'
import { import {
Button, Button,
Divider, Divider,
@@ -29,6 +20,15 @@ import {
Typography, Typography,
Tooltip, Tooltip,
} from '@mui/material' } from '@mui/material'
import TimeLocale from './TimeLocale'
import { AppState } from '../../reducers'
import { globalActions, settingsActions, connectionActions } from '../../actions'
import { TopicOrder } from '../../reducers/Settings'
import { isBrowserMode } from '../../utils/browserMode'
import { useAuth } from '../../contexts/AuthContext'
import BrokerStatistics from './BrokerStatistics'
import BooleanSwitch from './BooleanSwitch'
export const autoExpandLimitSet = [ export const autoExpandLimitSet = [
{ {
@@ -61,7 +61,7 @@ const styles = (theme: Theme) => ({
drawer: { drawer: {
backgroundColor: theme.palette.background.default, backgroundColor: theme.palette.background.default,
flexShrink: 0, flexShrink: 0,
userSelect: 'none' as 'none', userSelect: 'none' as const,
}, },
paper: { paper: {
width: '300px', width: '300px',
@@ -78,16 +78,16 @@ const styles = (theme: Theme) => ({
author: { author: {
margin: 'auto 8px 8px auto', margin: 'auto 8px 8px auto',
color: theme.palette.text.secondary, color: theme.palette.text.secondary,
cursor: 'pointer' as 'pointer', cursor: 'pointer' as const,
}, },
mobileButtons: { mobileButtons: {
padding: theme.spacing(1), padding: theme.spacing(1),
display: 'flex', display: 'flex',
flexDirection: 'column' as 'column', flexDirection: 'column' as const,
gap: theme.spacing(1), gap: theme.spacing(1),
// Only show on mobile // Only show on mobile
[theme.breakpoints.up('md')]: { [theme.breakpoints.up('md')]: {
display: 'none' as 'none', display: 'none' as const,
}, },
}, },
mobileButton: { mobileButton: {
@@ -205,7 +205,7 @@ class Settings extends React.PureComponent<Props, {}> {
value={topicOrder} value={topicOrder}
onChange={this.onChangeSorting} onChange={this.onChangeSorting}
input={<Input name="node-order" id="node-order-label-placeholder" />} input={<Input name="node-order" id="node-order-label-placeholder" />}
displayEmpty={true} displayEmpty
name="node-order" name="node-order"
className={classes.input} className={classes.input}
style={{ flex: '1' }} style={{ flex: '1' }}
@@ -304,25 +304,21 @@ function MobileActionButtons({ classes, actions }: { classes: any; actions: any
) )
} }
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => ({
return { autoExpandLimit: state.settings.get('autoExpandLimit'),
autoExpandLimit: state.settings.get('autoExpandLimit'), topicOrder: state.settings.get('topicOrder'),
topicOrder: state.settings.get('topicOrder'), visible: state.globalState.get('settingsVisible'),
visible: state.globalState.get('settingsVisible'), highlightTopicUpdates: state.settings.get('highlightTopicUpdates'),
highlightTopicUpdates: state.settings.get('highlightTopicUpdates'), selectTopicWithMouseOver: state.settings.get('selectTopicWithMouseOver'),
selectTopicWithMouseOver: state.settings.get('selectTopicWithMouseOver'), theme: state.settings.get('theme'),
theme: state.settings.get('theme'), })
}
}
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { settings: bindActionCreators(settingsActions, dispatch),
settings: bindActionCreators(settingsActions, dispatch), global: bindActionCreators(globalActions, dispatch),
global: bindActionCreators(globalActions, dispatch), connection: bindActionCreators(connectionActions, dispatch),
connection: bindActionCreators(connectionActions, dispatch), },
}, })
}
}
export default withStyles(styles)(connect(mapStateToProps, mapDispatchToProps)(Settings)) export default withStyles(styles)(connect(mapStateToProps, mapDispatchToProps)(Settings))

View File

@@ -1,11 +1,11 @@
import * as React from 'react' import * as React from 'react'
import DateFormatter from '../helper/DateFormatter'
import { AppState } from '../../reducers'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { Input, InputLabel, MenuItem, Select, Theme } from '@mui/material' import { Input, InputLabel, MenuItem, Select, Theme } from '@mui/material'
import { settingsActions } from '../../actions'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { settingsActions } from '../../actions'
import { AppState } from '../../reducers'
import DateFormatter from '../helper/DateFormatter'
function importAll(r: any) { function importAll(r: any) {
r.keys().forEach(r) r.keys().forEach(r)
@@ -63,19 +63,15 @@ function TimeLocaleSettings(props: Props) {
) )
} }
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => ({
return { timeLocale: state.settings.get('timeLocale'),
timeLocale: state.settings.get('timeLocale'), })
}
}
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { settings: bindActionCreators(settingsActions, dispatch),
settings: bindActionCreators(settingsActions, dispatch), },
}, })
}
}
const styles = (theme: Theme) => ({ const styles = (theme: Theme) => ({
input: { input: {

View File

@@ -15,14 +15,9 @@ import {
Collapse, Collapse,
Alert, Alert,
Button, Button,
Dialog, Card,
DialogTitle, CardContent,
DialogContent, CardActions,
DialogActions,
Select,
MenuItem,
FormControl,
InputLabel,
} from '@mui/material' } from '@mui/material'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
@@ -30,12 +25,16 @@ import SendIcon from '@mui/icons-material/Send'
import SmartToyIcon from '@mui/icons-material/SmartToy' import SmartToyIcon from '@mui/icons-material/SmartToy'
import ExpandMoreIcon from '@mui/icons-material/ExpandMore' import ExpandMoreIcon from '@mui/icons-material/ExpandMore'
import ExpandLessIcon from '@mui/icons-material/ExpandLess' import ExpandLessIcon from '@mui/icons-material/ExpandLess'
import SettingsIcon from '@mui/icons-material/Settings'
import ClearIcon from '@mui/icons-material/Clear' import ClearIcon from '@mui/icons-material/Clear'
import { getLLMService, LLMMessage, LLMProvider } from '../../services/llmService' import PublishIcon from '@mui/icons-material/Publish'
import BugReportIcon from '@mui/icons-material/BugReport'
import { Base64Message } from '../../../../backend/src/Model/Base64Message'
import { getLLMService, LLMMessage, MessageProposal, QuestionProposal } from '../../services/llmService'
import { makePublishEvent, rendererEvents } from '../../eventBus'
interface Props { interface Props {
node?: any node?: any
connectionId?: string
classes: any classes: any
} }
@@ -43,25 +42,24 @@ interface ChatMessage {
role: 'user' | 'assistant' | 'system' role: 'user' | 'assistant' | 'system'
content: string content: string
timestamp: Date timestamp: Date
proposals?: MessageProposal[]
questionProposals?: QuestionProposal[]
debugInfo?: any // API debug information
} }
function AIAssistant(props: Props) { function AIAssistant(props: Props) {
const { node, classes } = props const { node, connectionId, classes } = props
const [expanded, setExpanded] = useState(false) const [expanded, setExpanded] = useState(false)
const [messages, setMessages] = useState<ChatMessage[]>([]) const [messages, setMessages] = useState<ChatMessage[]>([])
const [inputValue, setInputValue] = useState('') const [inputValue, setInputValue] = useState('')
const [loading, setLoading] = useState(false) const [loading, setLoading] = useState(false)
const [error, setError] = useState<string | null>(null) const [error, setError] = useState<string | null>(null)
const [configDialogOpen, setConfigDialogOpen] = useState(false) const [suggestedQuestions, setSuggestedQuestions] = useState<string[]>([])
const [apiKey, setApiKey] = useState('') const [loadingSuggestions, setLoadingSuggestions] = useState(false)
const [provider, setProvider] = useState<LLMProvider>('openai') const [showDebug, setShowDebug] = useState(false)
const messagesEndRef = useRef<HTMLDivElement>(null) const messagesEndRef = useRef<HTMLDivElement>(null)
const llmService = getLLMService() const llmService = getLLMService()
const previousNodePathRef = useRef<string>('')
useEffect(() => {
// Initialize provider from service
setProvider(llmService.getProvider())
}, [])
const scrollToBottom = () => { const scrollToBottom = () => {
messagesEndRef.current?.scrollIntoView({ behavior: 'smooth' }) messagesEndRef.current?.scrollIntoView({ behavior: 'smooth' })
@@ -71,15 +69,40 @@ function AIAssistant(props: Props) {
scrollToBottom() scrollToBottom()
}, [messages]) }, [messages])
// Auto-generate questions when node changes or chat is expanded
// Clear chat when node changes
useEffect(() => {
const nodePath = node?.path?.()
if (expanded && node && nodePath && nodePath !== previousNodePathRef.current && llmService.hasApiKey()) {
previousNodePathRef.current = nodePath
// Clear chat messages and error when switching to a new topic
setMessages([])
setError(null)
setLoadingSuggestions(true)
llmService
.generateSuggestedQuestions(node)
.then(questions => {
setSuggestedQuestions(questions)
})
.catch(err => {
console.error('Failed to generate suggested questions:', err)
})
.finally(() => {
setLoadingSuggestions(false)
})
}
}, [expanded, node, llmService])
const handleSendMessage = useCallback( const handleSendMessage = useCallback(
async (messageText?: string) => { async (messageText?: string) => {
const text = messageText || inputValue.trim() const text = messageText || inputValue.trim()
if (!text) return if (!text) return
// Check if API key is configured // Check if backend LLM service is available
if (!llmService.hasApiKey()) { if (!llmService.hasApiKey()) {
setError(`Please configure your ${provider === 'gemini' ? 'Gemini' : 'OpenAI'} API key first`) setError('LLM service not configured on server. Please contact your administrator.')
setConfigDialogOpen(true)
return return
} }
@@ -93,25 +116,33 @@ function AIAssistant(props: Props) {
content: text, content: text,
timestamp: new Date(), timestamp: new Date(),
} }
setMessages((prev) => [...prev, userMessage]) setMessages(prev => [...prev, userMessage])
try { try {
// Generate topic context if available // Generate topic context if available
const topicContext = node ? llmService.generateTopicContext(node) : undefined const topicContext = node ? llmService.generateTopicContext(node) : undefined
// Send to LLM // Send to LLM - now returns { response, debugInfo }
const response = await llmService.sendMessage(text, topicContext) const llmResponse = await llmService.sendMessage(text, topicContext)
// Add assistant response to UI // Parse response for proposals and questions
const parsed = llmService.parseResponse(llmResponse.response)
// Add assistant response to UI with proposals, questions, and debug info
const assistantMessage: ChatMessage = { const assistantMessage: ChatMessage = {
role: 'assistant', role: 'assistant',
content: response, content: parsed.text,
timestamp: new Date(), timestamp: new Date(),
proposals: parsed.proposals,
questionProposals: parsed.questions,
debugInfo: llmResponse.debugInfo, // Store debug info
} }
setMessages((prev) => [...prev, assistantMessage]) setMessages(prev => [...prev, assistantMessage])
} catch (err: unknown) { } catch (err: unknown) {
const error = err as { message?: string } const error = err as { message?: string }
setError(error.message || 'Failed to get response') console.error('AI Assistant error:', err)
console.error('Error details:', error)
setError(error.message || 'Failed to get response from AI assistant')
} finally { } finally {
setLoading(false) setLoading(false)
} }
@@ -136,24 +167,47 @@ function AIAssistant(props: Props) {
setError(null) setError(null)
} }
const handleSaveApiKey = () => { const handlePublishProposal = useCallback(
if (apiKey.trim()) { (proposal: MessageProposal) => {
llmService.saveApiKey(apiKey.trim()) if (!connectionId) {
llmService.saveProvider(provider) setError('No active connection to publish message')
setConfigDialogOpen(false) return
setApiKey('') }
setError(null)
// Reset the service to use new config try {
window.location.reload() const publishEvent = makePublishEvent(connectionId)
} const mqttMessage = {
} topic: proposal.topic,
payload: Base64Message.fromString(proposal.payload),
retain: false,
qos: proposal.qos,
}
rendererEvents.emit(publishEvent, mqttMessage)
// Show success feedback
setMessages(prev => [
...prev,
{
role: 'assistant',
content: `✓ Published to ${proposal.topic}`,
timestamp: new Date(),
},
])
} catch (err) {
setError(`Failed to publish message: ${err}`)
}
},
[connectionId]
)
const suggestions = node ? llmService.getQuickSuggestions(node) : [] const suggestions = node ? llmService.getQuickSuggestions(node) : []
const allSuggestions = [...suggestions, ...suggestedQuestions]
// Check if API key is available (from localStorage or environment) // Check if backend LLM service is available
const hasApiKey = llmService.hasApiKey() const hasApiKey = llmService.hasApiKey()
// Don't render the component at all if no API key is available // Hide component completely if backend doesn't have LLM configured (new requirement)
if (!hasApiKey) { if (!hasApiKey) {
return null return null
} }
@@ -161,8 +215,8 @@ function AIAssistant(props: Props) {
return ( return (
<Box className={classes.root}> <Box className={classes.root}>
{/* Header */} {/* Header */}
<Box className={classes.header} onClick={() => setExpanded(!expanded)}> <Box className={classes.header}>
<Box className={classes.headerLeft}> <Box className={classes.headerLeft} onClick={() => setExpanded(!expanded)} style={{ flex: 1, cursor: 'pointer' }}>
<SmartToyIcon className={classes.icon} /> <SmartToyIcon className={classes.icon} />
<Typography variant="subtitle2" className={classes.title}> <Typography variant="subtitle2" className={classes.title}>
AI Assistant AI Assistant
@@ -170,17 +224,22 @@ function AIAssistant(props: Props) {
<Chip label="Beta" size="small" color="primary" className={classes.betaChip} /> <Chip label="Beta" size="small" color="primary" className={classes.betaChip} />
</Box> </Box>
<Box className={classes.headerRight}> <Box className={classes.headerRight}>
<IconButton {expanded && messages.length > 0 && (
size="small" <IconButton
onClick={(e) => { size="small"
e.stopPropagation() onClick={(e) => {
setConfigDialogOpen(true) e.stopPropagation()
}} setShowDebug(!showDebug)
className={classes.iconButton} }}
> title="Toggle debug view"
<SettingsIcon fontSize="small" /> className={classes.iconButton}
</IconButton> >
{expanded ? <ExpandLessIcon /> : <ExpandMoreIcon />} <BugReportIcon fontSize="small" style={{ color: showDebug ? '#f50057' : 'inherit' }} />
</IconButton>
)}
<Box onClick={() => setExpanded(!expanded)} style={{ cursor: 'pointer', display: 'flex', alignItems: 'center' }}>
{expanded ? <ExpandLessIcon /> : <ExpandMoreIcon />}
</Box>
</Box> </Box>
</Box> </Box>
@@ -194,20 +253,21 @@ function AIAssistant(props: Props) {
</Alert> </Alert>
)} )}
{/* Quick Suggestions */} {/* Quick Suggestions - Always shown when available */}
{messages.length === 0 && suggestions.length > 0 && ( {hasApiKey && allSuggestions.length > 0 && (
<Box className={classes.suggestions}> <Box className={classes.suggestions}>
<Typography variant="caption" color="textSecondary" className={classes.suggestionsTitle}> <Typography variant="caption" color="textSecondary" className={classes.suggestionsTitle}>
Quick questions: {loadingSuggestions ? 'Generating questions...' : 'Suggested questions:'}
</Typography> </Typography>
<Box className={classes.suggestionChips}> <Box className={classes.suggestionChips}>
{suggestions.slice(0, 4).map((suggestion, idx) => ( {allSuggestions.slice(0, 6).map((suggestion, idx) => (
<Chip <Chip
key={idx} key={idx}
label={suggestion} label={suggestion}
size="small" size="small"
onClick={() => handleSuggestionClick(suggestion)} onClick={() => handleSuggestionClick(suggestion)}
className={classes.suggestionChip} className={classes.suggestionChip}
disabled={loadingSuggestions}
/> />
))} ))}
</Box> </Box>
@@ -226,16 +286,81 @@ function AIAssistant(props: Props) {
)} )}
{messages.map((msg, idx) => ( {messages.map((msg, idx) => (
<Box <Box key={idx}>
key={idx} <Box className={msg.role === 'user' ? classes.userMessage : classes.assistantMessage}>
className={msg.role === 'user' ? classes.userMessage : classes.assistantMessage} <Typography variant="body2" className={classes.messageText}>
> {msg.content}
<Typography variant="body2" className={classes.messageText}> </Typography>
{msg.content} <Typography variant="caption" color="textSecondary" className={classes.messageTime}>
</Typography> {msg.timestamp.toLocaleTimeString()}
<Typography variant="caption" color="textSecondary" className={classes.messageTime}> </Typography>
{msg.timestamp.toLocaleTimeString()} </Box>
</Typography>
{/* Render proposals if any */}
{msg.proposals && msg.proposals.length > 0 && (
<Box className={classes.proposalsContainer}>
{msg.proposals.map((proposal, pIdx) => (
<Card key={pIdx} className={classes.proposalCard} variant="outlined">
<CardContent className={classes.proposalContent}>
<Typography variant="caption" color="primary" fontWeight="bold">
Proposed Action
</Typography>
<Typography variant="body2" gutterBottom>
{proposal.description}
</Typography>
<Box className={classes.proposalDetails}>
<Typography variant="caption" color="textSecondary">
Topic: <code>{proposal.topic}</code>
</Typography>
<Typography variant="caption" color="textSecondary">
Payload: <code>{proposal.payload}</code>
</Typography>
</Box>
</CardContent>
<CardActions className={classes.proposalActions}>
<Button
size="small"
variant="contained"
color="primary"
startIcon={<PublishIcon />}
onClick={() => handlePublishProposal(proposal)}
disabled={!connectionId}
>
Send Message
</Button>
</CardActions>
</Card>
))}
</Box>
)}
{/* Render question proposals if any */}
{msg.questionProposals && msg.questionProposals.length > 0 && (
<Box className={classes.questionProposalsContainer}>
<Typography variant="caption" color="textSecondary" gutterBottom>
Follow-up questions:
</Typography>
<Box className={classes.suggestionChips}>
{msg.questionProposals.map((qProposal, qIdx) => (
<Chip
key={qIdx}
label={qProposal.question}
size="small"
color="secondary"
onClick={() => handleSuggestionClick(qProposal.question)}
className={classes.questionProposalChip}
icon={
qProposal.category ? (
<Typography variant="caption" component="span">
{qProposal.category}:
</Typography>
) : undefined
}
/>
))}
</Box>
</Box>
)}
</Box> </Box>
))} ))}
@@ -251,6 +376,68 @@ function AIAssistant(props: Props) {
<div ref={messagesEndRef} /> <div ref={messagesEndRef} />
</Box> </Box>
{/* Debug View - Enhanced with API Traffic */}
{showDebug && messages.length > 0 && (
<Paper className={classes.debugContainer} variant="outlined">
<Typography variant="caption" fontWeight="bold" color="textSecondary" gutterBottom>
Debug: Complete API Traffic
</Typography>
<Box className={classes.debugContent}>
<pre className={classes.debugPre}>
{JSON.stringify(
{
systemMessage: {
role: 'system',
content: llmService.getSystemMessage(),
note: 'This is the system prompt that provides context to the LLM',
},
messages: messages.map((msg, idx) => ({
index: idx,
role: msg.role,
content: msg.content.substring(0, 200) + (msg.content.length > 200 ? '...' : ''),
fullContent: msg.content,
hasTopicContext: msg.role === 'user' && msg.content.startsWith('Context:'),
contentLength: msg.content.length,
timestamp: msg.timestamp.toISOString(),
proposals: msg.proposals?.length || 0,
questionProposals: msg.questionProposals?.length || 0,
...(msg.debugInfo && {
apiDebug: {
provider: msg.debugInfo.provider,
model: msg.debugInfo.model,
timing: msg.debugInfo.timing,
request: {
url: msg.debugInfo.request?.url,
body: msg.debugInfo.request?.body,
},
response: {
id: msg.debugInfo.response?.id,
model: msg.debugInfo.response?.model,
created: msg.debugInfo.response?.created,
choices: msg.debugInfo.response?.choices,
usage: msg.debugInfo.response?.usage,
system_fingerprint: msg.debugInfo.response?.system_fingerprint,
},
},
}),
})),
summary: {
totalMessages: messages.length,
messagesWithDebugInfo: messages.filter(m => m.debugInfo).length,
lastApiCall: messages
.filter(m => m.debugInfo)
.pop()
?.debugInfo?.timing?.timestamp,
},
},
null,
2
)}
</pre>
</Box>
</Paper>
)}
{/* Input */} {/* Input */}
<Box className={classes.inputContainer}> <Box className={classes.inputContainer}>
{messages.length > 0 && ( {messages.length > 0 && (
@@ -263,7 +450,7 @@ function AIAssistant(props: Props) {
size="small" size="small"
placeholder="Ask about this topic..." placeholder="Ask about this topic..."
value={inputValue} value={inputValue}
onChange={(e) => setInputValue(e.target.value)} onChange={e => setInputValue(e.target.value)}
onKeyPress={handleKeyPress} onKeyPress={handleKeyPress}
disabled={loading} disabled={loading}
className={classes.input} className={classes.input}
@@ -281,60 +468,6 @@ function AIAssistant(props: Props) {
</Box> </Box>
</Box> </Box>
</Collapse> </Collapse>
{/* Configuration Dialog */}
<Dialog open={configDialogOpen} onClose={() => setConfigDialogOpen(false)} maxWidth="sm" fullWidth>
<DialogTitle>AI Assistant Configuration</DialogTitle>
<DialogContent>
<FormControl fullWidth margin="normal">
<InputLabel>AI Provider</InputLabel>
<Select
value={provider}
label="AI Provider"
onChange={(e) => setProvider(e.target.value as LLMProvider)}
>
<MenuItem value="openai">OpenAI (GPT-3.5 Turbo)</MenuItem>
<MenuItem value="gemini">Google Gemini (Flash)</MenuItem>
</Select>
</FormControl>
<Typography variant="body2" color="textSecondary" paragraph sx={{ mt: 2 }}>
{provider === 'openai' ? (
<>
Get your OpenAI API key from{' '}
<a href="https://platform.openai.com/api-keys" target="_blank" rel="noopener noreferrer">
OpenAI's platform
</a>
.
</>
) : (
<>
Get your Gemini API key from{' '}
<a href="https://aistudio.google.com/app/apikey" target="_blank" rel="noopener noreferrer">
Google AI Studio
</a>
.
</>
)}
</Typography>
<TextField
fullWidth
label={`${provider === 'openai' ? 'OpenAI' : 'Gemini'} API Key`}
type="password"
value={apiKey}
onChange={(e) => setApiKey(e.target.value)}
placeholder={provider === 'openai' ? 'sk-...' : 'AIza...'}
margin="normal"
helperText="Your API key is stored locally and never sent to our servers"
/>
</DialogContent>
<DialogActions>
<Button onClick={() => setConfigDialogOpen(false)}>Cancel</Button>
<Button onClick={handleSaveApiKey} variant="contained" disabled={!apiKey.trim()}>
Save
</Button>
</DialogActions>
</Dialog>
</Box> </Box>
) )
} }
@@ -383,7 +516,7 @@ const styles = (theme: Theme) => ({
content: { content: {
padding: theme.spacing(2), padding: theme.spacing(2),
display: 'flex', display: 'flex',
flexDirection: 'column' as 'column', flexDirection: 'column' as const,
gap: theme.spacing(1.5), gap: theme.spacing(1.5),
}, },
alert: { alert: {
@@ -398,7 +531,7 @@ const styles = (theme: Theme) => ({
}, },
suggestionChips: { suggestionChips: {
display: 'flex', display: 'flex',
flexWrap: 'wrap' as 'wrap', flexWrap: 'wrap' as const,
gap: theme.spacing(0.5), gap: theme.spacing(0.5),
}, },
suggestionChip: { suggestionChip: {
@@ -410,14 +543,14 @@ const styles = (theme: Theme) => ({
}, },
messages: { messages: {
maxHeight: '300px', maxHeight: '300px',
overflowY: 'auto' as 'auto', overflowY: 'auto' as const,
display: 'flex', display: 'flex',
flexDirection: 'column' as 'column', flexDirection: 'column' as const,
gap: theme.spacing(1), gap: theme.spacing(1),
}, },
emptyState: { emptyState: {
display: 'flex', display: 'flex',
flexDirection: 'column' as 'column', flexDirection: 'column' as const,
alignItems: 'center', alignItems: 'center',
justifyContent: 'center', justifyContent: 'center',
padding: theme.spacing(4), padding: theme.spacing(4),
@@ -445,8 +578,8 @@ const styles = (theme: Theme) => ({
borderBottomLeftRadius: theme.spacing(0.5), borderBottomLeftRadius: theme.spacing(0.5),
}, },
messageText: { messageText: {
whiteSpace: 'pre-wrap' as 'pre-wrap', whiteSpace: 'pre-wrap' as const,
wordBreak: 'break-word' as 'break-word', wordBreak: 'break-word' as const,
}, },
messageTime: { messageTime: {
display: 'block', display: 'block',
@@ -472,6 +605,70 @@ const styles = (theme: Theme) => ({
sendButton: { sendButton: {
padding: theme.spacing(1), padding: theme.spacing(1),
}, },
proposalsContainer: {
marginTop: theme.spacing(1),
marginLeft: theme.spacing(6),
display: 'flex',
flexDirection: 'column' as const,
gap: theme.spacing(1),
},
proposalCard: {
backgroundColor: theme.palette.mode === 'dark' ? 'rgba(144, 202, 249, 0.08)' : 'rgba(25, 118, 210, 0.04)',
borderColor: theme.palette.primary.main,
},
proposalContent: {
paddingBottom: theme.spacing(1),
'&:last-child': {
paddingBottom: theme.spacing(1),
},
},
proposalDetails: {
marginTop: theme.spacing(1),
display: 'flex',
flexDirection: 'column' as const,
gap: theme.spacing(0.5),
'& code': {
backgroundColor: theme.palette.action.hover,
padding: theme.spacing(0.25, 0.5),
borderRadius: theme.shape.borderRadius,
fontSize: '0.85em',
},
},
proposalActions: {
padding: theme.spacing(1, 2),
paddingTop: 0,
},
questionProposalsContainer: {
marginTop: theme.spacing(1),
marginLeft: theme.spacing(6),
display: 'flex',
flexDirection: 'column' as const,
gap: theme.spacing(0.5),
},
questionProposalChip: {
cursor: 'pointer',
'&:hover': {
backgroundColor: theme.palette.secondary.dark,
},
},
debugContainer: {
marginTop: theme.spacing(1),
padding: theme.spacing(1.5),
backgroundColor: theme.palette.mode === 'dark' ? 'rgba(0, 0, 0, 0.2)' : 'rgba(0, 0, 0, 0.03)',
maxHeight: '200px',
overflow: 'auto',
},
debugContent: {
marginTop: theme.spacing(0.5),
},
debugPre: {
margin: 0,
fontSize: '0.75rem',
fontFamily: 'monospace',
whiteSpace: 'pre-wrap' as const,
wordBreak: 'break-word' as const,
color: theme.palette.text.secondary,
},
}) })
export default withStyles(styles)(AIAssistant) export default withStyles(styles)(AIAssistant)

View File

@@ -1,12 +1,12 @@
import * as q from '../../../../../backend/src/Model'
import * as React from 'react' import * as React from 'react'
import ShowChart from '@mui/icons-material/ShowChart' import ShowChart from '@mui/icons-material/ShowChart'
import TopicPlot from '../../TopicPlot'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { chartActions } from '../../../actions'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { Fade, Paper, Popper, Tooltip } from '@mui/material' import { Fade, Paper, Popper, Tooltip } from '@mui/material'
import { JsonPropertyLocation } from '../../../../../backend/src/JsonAstParser' import { JsonPropertyLocation } from '../../../../../backend/src/JsonAstParser'
import * as q from '../../../../../backend/src/Model'
import { chartActions } from '../../../actions'
import TopicPlot from '../../TopicPlot'
interface Props { interface Props {
treeNode: q.TreeNode<any> treeNode: q.TreeNode<any>
@@ -79,12 +79,10 @@ function ChartPreview(props: Props) {
) )
} }
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: {
actions: { chart: bindActionCreators(chartActions, dispatch),
chart: bindActionCreators(chartActions, dispatch), },
}, })
}
}
export default connect(undefined, mapDispatchToProps)(ChartPreview) export default connect(undefined, mapDispatchToProps)(ChartPreview)

View File

@@ -22,11 +22,13 @@ function changeAmount(props: Props) {
<span> <span>
Comparing with <b>{props.nameOfCompareMessage}</b> message:&nbsp; Comparing with <b>{props.nameOfCompareMessage}</b> message:&nbsp;
<span className={props.classes.additions}> <span className={props.classes.additions}>
+ {additions} line{additions === 1 ? '' : 's'} + {additions} line
{additions === 1 ? '' : 's'}
</span> </span>
,{' '} ,{' '}
<span className={props.classes.deletions}> <span className={props.classes.deletions}>
- {deletions} line{deletions === 1 ? '' : 's'} - {deletions} line
{deletions === 1 ? '' : 's'}
</span> </span>
</span> </span>
</span> </span>

View File

@@ -1,13 +1,13 @@
import * as diff from 'diff' import * as diff from 'diff'
import * as q from '../../../../../backend/src/Model'
import * as React from 'react' import * as React from 'react'
import Add from '@mui/icons-material/Add' import Add from '@mui/icons-material/Add'
import ChartPreview from './ChartPreview'
import Remove from '@mui/icons-material/Remove' import Remove from '@mui/icons-material/Remove'
import { JsonPropertyLocation } from '../../../../../backend/src/JsonAstParser' import { JsonPropertyLocation } from '../../../../../backend/src/JsonAstParser'
import { lineChangeStyle, trimNewlineRight } from './util'
import { Theme } from '@mui/material' import { Theme } from '@mui/material'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import * as q from '../../../../../backend/src/Model'
import { lineChangeStyle, trimNewlineRight } from './util'
import ChartPreview from './ChartPreview'
interface Props { interface Props {
changes: Array<diff.Change> changes: Array<diff.Change>
@@ -40,7 +40,7 @@ const style = (theme: Theme) => {
}, },
}, },
gutterLine: { gutterLine: {
textAlign: 'right' as 'right', textAlign: 'right' as const,
paddingRight: theme.spacing(0.5), paddingRight: theme.spacing(0.5),
height: '16px', height: '16px',
width: '100%', width: '100%',
@@ -52,7 +52,7 @@ function tokensForLine(change: diff.Change, line: number, props: Props) {
const { classes, literalPositions } = props const { classes, literalPositions } = props
const literal = literalPositions[line] const literal = literalPositions[line]
const chartPreview = Boolean(literal) ? ( const chartPreview = literal ? (
<ChartPreview <ChartPreview
key="chartPreview" key="chartPreview"
treeNode={props.treeNode} treeNode={props.treeNode}
@@ -63,25 +63,25 @@ function tokensForLine(change: diff.Change, line: number, props: Props) {
if (change.added) { if (change.added) {
return [chartPreview, <Add key="add" className={classes.icon} />] return [chartPreview, <Add key="add" className={classes.icon} />]
} else if (change.removed) {
return [<Remove key="remove" className={classes.icon} />]
} else {
return [
chartPreview,
<div
key="placeholder"
style={{ width: '12px', display: 'inline-block' }}
dangerouslySetInnerHTML={{ __html: '&nbsp;' }}
/>,
]
} }
if (change.removed) {
return [<Remove key="remove" className={classes.icon} />]
}
return [
chartPreview,
<div
key="placeholder"
style={{ width: '12px', display: 'inline-block' }}
dangerouslySetInnerHTML={{ __html: '&nbsp;' }}
/>,
]
} }
function Gutters(props: Props) { function Gutters(props: Props) {
let currentLine = -1 let currentLine = -1
const gutters = props.changes const gutters = props.changes
.map((change, key) => { .map((change, key) =>
return trimNewlineRight(change.value) trimNewlineRight(change.value)
.split('\n') .split('\n')
.map((_, idx) => { .map((_, idx) => {
currentLine = !change.removed ? currentLine + 1 : currentLine currentLine = !change.removed ? currentLine + 1 : currentLine
@@ -91,7 +91,7 @@ function Gutters(props: Props) {
</div> </div>
) )
}) })
}) )
.reduce((a, b) => a.concat(b), []) .reduce((a, b) => a.concat(b), [])
return ( return (

View File

@@ -1,15 +1,16 @@
import * as diff from 'diff' import * as diff from 'diff'
import * as Prism from 'prismjs' import * as Prism from 'prismjs'
import * as q from '../../../../../backend/src/Model'
import * as React from 'react' import * as React from 'react'
import DOMPurify from 'dompurify'
import { JsonPropertyLocation, literalsMappedByLines } from '../../../../../backend/src/JsonAstParser'
import { Typography } from '@mui/material'
import { withStyles } from '@mui/styles'
import * as q from '../../../../../backend/src/Model'
import DiffCount from './DiffCount' import DiffCount from './DiffCount'
import Gutters from './Gutters' import Gutters from './Gutters'
import { isPlottable, lineChangeStyle, trimNewlineRight } from './util' import { isPlottable, lineChangeStyle, trimNewlineRight } from './util'
import { JsonPropertyLocation, literalsMappedByLines } from '../../../../../backend/src/JsonAstParser'
import { selectTextWithCtrlA } from '../../../utils/handleTextSelectWithCtrlA' import { selectTextWithCtrlA } from '../../../utils/handleTextSelectWithCtrlA'
import { style } from './style' import { style } from './style'
import { Typography } from '@mui/material'
import { withStyles } from '@mui/styles'
import 'prismjs/components/prism-json' import 'prismjs/components/prism-json'
interface Props { interface Props {
@@ -59,13 +60,11 @@ class CodeDiff extends React.PureComponent<Props, State> {
const changedLines = change.count || 0 const changedLines = change.count || 0
if (hasStyledCode && this.props.language === 'json') { if (hasStyledCode && this.props.language === 'json') {
const currentLines = styledLines.slice(lineNumber, lineNumber + changedLines) const currentLines = styledLines.slice(lineNumber, lineNumber + changedLines)
const lines = currentLines.map((html: string, idx: number) => { const lines = currentLines.map((html: string, idx: number) => (
return ( <div key={`${key}-${idx}`} style={lineChangeStyle(change)} className={this.props.classes.line}>
<div key={`${key}-${idx}`} style={lineChangeStyle(change)} className={this.props.classes.line}> <span dangerouslySetInnerHTML={{ __html: DOMPurify.sanitize(html) }} />
<span dangerouslySetInnerHTML={{ __html: html }} /> </div>
</div> ))
)
})
lineNumber += changedLines lineNumber += changedLines
return [<div key={key}>{lines}</div>] return [<div key={key}>{lines}</div>]
@@ -73,13 +72,11 @@ class CodeDiff extends React.PureComponent<Props, State> {
return trimNewlineRight(change.value) return trimNewlineRight(change.value)
.split('\n') .split('\n')
.map((line, idx) => { .map((line, idx) => (
return ( <div key={`${key}-${idx}`} style={lineChangeStyle(change)} className={this.props.classes.line}>
<div key={`${key}-${idx}`} style={lineChangeStyle(change)} className={this.props.classes.line}> <span>{line}</span>
<span>{line}</span> </div>
</div> ))
)
})
}) })
.reduce((a, b) => a.concat(b), []) .reduce((a, b) => a.concat(b), [])
} }

View File

@@ -1,11 +1,11 @@
import { CodeBlockColors, CodeBlockColorsBraceMonokai } from '../CodeBlockColors'
import { Theme } from '@mui/material' import { Theme } from '@mui/material'
import { CodeBlockColors, CodeBlockColorsBraceMonokai } from '../CodeBlockColors'
export const style = (theme: Theme) => { export const style = (theme: Theme) => {
const codeBlockColors = theme.palette.mode === 'light' ? CodeBlockColors : CodeBlockColorsBraceMonokai const codeBlockColors = theme.palette.mode === 'light' ? CodeBlockColors : CodeBlockColorsBraceMonokai
const codeBaseStyle = { const codeBaseStyle = {
font: "12px/normal 'Monaco', 'Menlo', 'Ubuntu Mono', 'Consolas', 'source-code-pro', monospace", font: "12px/normal 'Monaco', 'Menlo', 'Ubuntu Mono', 'Consolas', 'source-code-pro', monospace",
display: 'inline-grid' as 'inline-grid', display: 'inline-grid' as const,
margin: '0', margin: '0',
padding: '1px 0 0 0', padding: '1px 0 0 0',
} }
@@ -17,7 +17,7 @@ export const style = (theme: Theme) => {
backgroundColor: codeBlockColors.gutters, backgroundColor: codeBlockColors.gutters,
}, },
line: { line: {
lineHeight: 'normal' as 'normal', lineHeight: 'normal' as const,
paddingLeft: '4px', paddingLeft: '4px',
width: '100%', width: '100%',
height: '16px', height: '16px',
@@ -32,7 +32,7 @@ export const style = (theme: Theme) => {
...codeBaseStyle, ...codeBaseStyle,
width: '33px', width: '33px',
backgroundColor: codeBlockColors.gutters, backgroundColor: codeBlockColors.gutters,
userSelect: 'none' as 'none', userSelect: 'none' as const,
}, },
codeBlock: { codeBlock: {
...codeBaseStyle, ...codeBaseStyle,

View File

@@ -56,7 +56,7 @@ export function toPlottableValue(value: any): number | undefined {
return value.toLowerCase() === 'on' ? 1 : 0 return value.toLowerCase() === 'on' ? 1 : 0
} }
if (/^[0-9]*,[0-9]+$/.test(value)) { if (/^[0-9]*,[0-9]+$/.test(value)) {
let parsedFloat = parseFloat(value.replace(',', '.')) const parsedFloat = parseFloat(value.replace(',', '.'))
if (!isNaN(parsedFloat)) { if (!isNaN(parsedFloat)) {
return parsedFloat return parsedFloat
} }

View File

@@ -1,11 +1,14 @@
import * as q from '../../../../backend/src/Model'
import React, { useCallback } from 'react' import React, { useCallback } from 'react'
import { Box, Typography, IconButton, Chip, Tooltip, Button } from '@mui/material' import { Box, Typography, IconButton, Chip, Tooltip, Button } from '@mui/material'
import { Theme } from '@mui/material/styles' import { Theme } from '@mui/material/styles'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { AppState } from '../../reducers'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import DeleteIcon from '@mui/icons-material/Delete'
import DeleteSweepIcon from '@mui/icons-material/DeleteSweep'
import Info from '@mui/icons-material/Info'
import * as q from '../../../../backend/src/Model'
import { AppState } from '../../reducers'
import { sidebarActions, globalActions } from '../../actions' import { sidebarActions, globalActions } from '../../actions'
import Copy from '../helper/Copy' import Copy from '../helper/Copy'
import Save from '../helper/Save' import Save from '../helper/Save'
@@ -15,9 +18,6 @@ import MessageHistory from './ValueRenderer/MessageHistory'
import ActionButtons from './ValueRenderer/ActionButtons' import ActionButtons from './ValueRenderer/ActionButtons'
import DeleteSelectedTopicButton from './ValueRenderer/DeleteSelectedTopicButton' import DeleteSelectedTopicButton from './ValueRenderer/DeleteSelectedTopicButton'
import { useDecoder } from '../hooks/useDecoder' import { useDecoder } from '../hooks/useDecoder'
import DeleteIcon from '@mui/icons-material/Delete'
import DeleteSweepIcon from '@mui/icons-material/DeleteSweep'
import Info from '@mui/icons-material/Info'
import SimpleBreadcrumb from './SimpleBreadcrumb' import SimpleBreadcrumb from './SimpleBreadcrumb'
import AIAssistant from './AIAssistant' import AIAssistant from './AIAssistant'
@@ -25,6 +25,7 @@ interface Props {
node?: q.TreeNode<any> node?: q.TreeNode<any>
classes: any classes: any
compareMessage?: q.Message compareMessage?: q.Message
connectionId?: string
sidebarActions: typeof sidebarActions sidebarActions: typeof sidebarActions
globalActions: typeof globalActions globalActions: typeof globalActions
} }
@@ -33,9 +34,10 @@ function DetailsTab(props: Props) {
const { node, compareMessage, classes } = props const { node, compareMessage, classes } = props
const decodeMessage = useDecoder(node) const decodeMessage = useDecoder(node)
const getDecodedValue = useCallback(() => { const getDecodedValue = useCallback(
return node?.message && decodeMessage(node.message)?.message?.toUnicodeString() () => node?.message && decodeMessage(node.message)?.message?.toUnicodeString(),
}, [node, decodeMessage]) [node, decodeMessage]
)
const getData = () => { const getData = () => {
if (node?.message && node.message.payload) { if (node?.message && node.message.payload) {
@@ -129,12 +131,7 @@ function DetailsTab(props: Props) {
{node.message?.retain && ( {node.message?.retain && (
<Chip label="Retained" size="small" variant="outlined" color="primary" className={classes.chip} /> <Chip label="Retained" size="small" variant="outlined" color="primary" className={classes.chip} />
)} )}
<Chip <Chip label={`QoS ${node.message?.qos ?? 0}`} size="small" variant="outlined" className={classes.chip} />
label={`QoS ${node.message?.qos ?? 0}`}
size="small"
variant="outlined"
className={classes.chip}
/>
</Box> </Box>
</Box> </Box>
@@ -198,7 +195,7 @@ function DetailsTab(props: Props) {
)} )}
{/* AI Assistant - Always available when a node is selected */} {/* AI Assistant - Always available when a node is selected */}
{node && <AIAssistant node={node} />} {node && <AIAssistant node={node} connectionId={props.connectionId} />}
{/* About Section - always visible at bottom */} {/* About Section - always visible at bottom */}
<Box className={classes.aboutSection}> <Box className={classes.aboutSection}>
@@ -219,7 +216,7 @@ function DetailsTab(props: Props) {
const styles = (theme: Theme) => ({ const styles = (theme: Theme) => ({
root: { root: {
display: 'flex', display: 'flex',
flexDirection: 'column' as 'column', flexDirection: 'column' as const,
gap: theme.spacing(3), gap: theme.spacing(3),
[theme.breakpoints.down('sm')]: { [theme.breakpoints.down('sm')]: {
gap: theme.spacing(2), gap: theme.spacing(2),
@@ -227,7 +224,7 @@ const styles = (theme: Theme) => ({
}, },
emptyState: { emptyState: {
display: 'flex', display: 'flex',
flexDirection: 'column' as 'column', flexDirection: 'column' as const,
alignItems: 'center', alignItems: 'center',
justifyContent: 'center', justifyContent: 'center',
minHeight: '200px', minHeight: '200px',
@@ -276,7 +273,7 @@ const styles = (theme: Theme) => ({
}, },
statItem: { statItem: {
display: 'flex', display: 'flex',
flexDirection: 'column' as 'column', flexDirection: 'column' as const,
alignItems: 'center', alignItems: 'center',
padding: theme.spacing(1.5, 1), padding: theme.spacing(1.5, 1),
backgroundColor: theme.palette.action.hover, backgroundColor: theme.palette.action.hover,
@@ -286,7 +283,7 @@ const styles = (theme: Theme) => ({
statLabel: { statLabel: {
fontSize: '0.75rem', fontSize: '0.75rem',
fontWeight: 500, fontWeight: 500,
textTransform: 'uppercase' as 'uppercase', textTransform: 'uppercase' as const,
letterSpacing: '0.5px', letterSpacing: '0.5px',
}, },
statValue: { statValue: {
@@ -297,7 +294,7 @@ const styles = (theme: Theme) => ({
// Value section // Value section
valueSection: { valueSection: {
display: 'flex', display: 'flex',
flexDirection: 'column' as 'column', flexDirection: 'column' as const,
gap: theme.spacing(2), gap: theme.spacing(2),
}, },
metadataBar: { metadataBar: {
@@ -305,7 +302,7 @@ const styles = (theme: Theme) => ({
justifyContent: 'space-between', justifyContent: 'space-between',
alignItems: 'center', alignItems: 'center',
gap: theme.spacing(1), gap: theme.spacing(1),
flexWrap: 'wrap' as 'wrap', flexWrap: 'wrap' as const,
padding: theme.spacing(1), padding: theme.spacing(1),
backgroundColor: theme.palette.action.hover, backgroundColor: theme.palette.action.hover,
borderRadius: theme.shape.borderRadius, borderRadius: theme.shape.borderRadius,
@@ -314,7 +311,7 @@ const styles = (theme: Theme) => ({
display: 'flex', display: 'flex',
gap: theme.spacing(1), gap: theme.spacing(1),
alignItems: 'center', alignItems: 'center',
flexWrap: 'wrap' as 'wrap', flexWrap: 'wrap' as const,
}, },
metadataRight: { metadataRight: {
display: 'flex', display: 'flex',
@@ -328,13 +325,13 @@ const styles = (theme: Theme) => ({
justifyContent: 'space-between', justifyContent: 'space-between',
alignItems: 'center', alignItems: 'center',
gap: theme.spacing(1), gap: theme.spacing(1),
flexWrap: 'wrap' as 'wrap', flexWrap: 'wrap' as const,
}, },
valueTitle: { valueTitle: {
fontWeight: 600, fontWeight: 600,
color: theme.palette.text.primary, color: theme.palette.text.primary,
fontSize: '0.875rem', fontSize: '0.875rem',
textTransform: 'uppercase' as 'uppercase', textTransform: 'uppercase' as const,
letterSpacing: '0.5px', letterSpacing: '0.5px',
flexShrink: 0, flexShrink: 0,
}, },
@@ -356,17 +353,13 @@ const styles = (theme: Theme) => ({
}, },
}) })
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => ({
return { compareMessage: state.sidebar.get('compareMessage'),
compareMessage: state.sidebar.get('compareMessage'), })
}
}
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { sidebarActions: bindActionCreators(sidebarActions, dispatch),
sidebarActions: bindActionCreators(sidebarActions, dispatch), globalActions: bindActionCreators(globalActions, dispatch),
globalActions: bindActionCreators(globalActions, dispatch), })
}
}
export default connect(mapStateToProps, mapDispatchToProps)(withStyles(styles)(DetailsTab)) export default connect(mapStateToProps, mapDispatchToProps)(withStyles(styles)(DetailsTab))

View File

@@ -1,8 +1,8 @@
import React, { useCallback, useState, useEffect, memo } from 'react' import React, { useCallback, useState, useEffect, memo } from 'react'
import { Badge, Typography } from '@mui/material' import { Badge, Typography } from '@mui/material'
import { selectTextWithCtrlA } from '../../utils/handleTextSelectWithCtrlA'
import { Theme, emphasize } from '@mui/material/styles' import { Theme, emphasize } from '@mui/material/styles'
import { withStyles } from '@mui/styles' import { withStyles } from '@mui/styles'
import { selectTextWithCtrlA } from '../../utils/handleTextSelectWithCtrlA'
interface HistoryItem { interface HistoryItem {
key: string key: string
@@ -81,7 +81,7 @@ function HistoryDrawer(props: Props) {
borderBottom: expanded ? `1px solid ${emphasize(props.theme.palette.background.default, 0.2)}` : undefined, borderBottom: expanded ? `1px solid ${emphasize(props.theme.palette.background.default, 0.2)}` : undefined,
}} }}
> >
<Typography component={'span'} onClick={toggle} style={{ cursor: 'pointer', display: 'flex' }}> <Typography component="span" onClick={toggle} style={{ cursor: 'pointer', display: 'flex' }}>
<span style={{ flexGrow: 1 }}> <span style={{ flexGrow: 1 }}>
<Badge <Badge
classes={{ badge: props.classes.badge }} classes={{ badge: props.classes.badge }}

View File

@@ -1,8 +1,8 @@
import React, { memo } from 'react' import React, { memo } from 'react'
import { Message } from '../../../../backend/src/Model'
import { Tooltip } from '@mui/material' import { Tooltip } from '@mui/material'
import { Message } from '../../../../backend/src/Model'
export const MessageId = memo(function MessageId(props: { message: Message; addComma?: boolean }) { export const MessageId = memo((props: { message: Message; addComma?: boolean }) => {
const { message, addComma } = props const { message, addComma } = props
if (!message.messageId) { if (!message.messageId) {

View File

@@ -1,7 +1,7 @@
import * as q from '../../../../backend/src/Model'
import * as React from 'react' import * as React from 'react'
import { TopicViewModel } from '../../model/TopicViewModel'
import { Typography } from '@mui/material' import { Typography } from '@mui/material'
import * as q from '../../../../backend/src/Model'
import { TopicViewModel } from '../../model/TopicViewModel'
interface Props { interface Props {
node?: q.TreeNode<TopicViewModel> node?: q.TreeNode<TopicViewModel>
@@ -21,7 +21,10 @@ class NodeStats extends React.Component<Props, {}> {
return ( return (
<div> <div>
<Typography>Messages: #{node.messages}</Typography> <Typography>Messages: #{node.messages}</Typography>
<Typography>Subtopics: {node.childTopicCount()}</Typography> <Typography>
Subtopics:
{node.childTopicCount()}
</Typography>
<Typography>Messages Subtopics: #{node.leafMessageCount()}</Typography> <Typography>Messages Subtopics: #{node.leafMessageCount()}</Typography>
</div> </div>
) )

View File

@@ -12,14 +12,14 @@ const styles = (theme: Theme) => ({
}, },
}) })
const Panel = (props: { function Panel(props: {
classes: any classes: any
children: [React.ReactElement, React.ReactElement] children: [React.ReactElement, React.ReactElement]
disabled?: boolean disabled?: boolean
detailsHidden?: boolean detailsHidden?: boolean
}) => { }) {
return ( return (
<Accordion defaultExpanded={true} disabled={props.disabled}> <Accordion defaultExpanded disabled={props.disabled}>
<AccordionSummary expandIcon={<ExpandMore />} className={props.classes.summary}> <AccordionSummary expandIcon={<ExpandMore />} className={props.classes.summary}>
<Typography className={props.classes.heading}>{props.children[0]}</Typography> <Typography className={props.classes.heading}>{props.children[0]}</Typography>
</AccordionSummary> </AccordionSummary>

View File

@@ -9,7 +9,6 @@ import 'ace-builds/src-noconflict/snippets/json'
import 'ace-builds/src-noconflict/snippets/xml' import 'ace-builds/src-noconflict/snippets/xml'
import 'ace-builds/src-noconflict/mode-text' import 'ace-builds/src-noconflict/mode-text'
import 'ace-builds/src-noconflict/theme-monokai' import 'ace-builds/src-noconflict/theme-monokai'
import 'react-ace'
function Editor(props: { function Editor(props: {
editorMode: string editorMode: string
@@ -32,11 +31,11 @@ function Editor(props: {
name="UNIQUE_ID_OF_DIV" name="UNIQUE_ID_OF_DIV"
width="100%" width="100%"
height="200px" height="200px"
enableSnippets={true} enableSnippets
enableBasicAutocompletion={true} enableBasicAutocompletion
enableLiveAutocompletion={true} enableLiveAutocompletion
showPrintMargin={false} showPrintMargin={false}
showGutter={true} showGutter
value={props.value} value={props.value}
onChange={props.onChange} onChange={props.onChange}
setOptions={editorOptions} setOptions={editorOptions}

View File

@@ -14,7 +14,7 @@ export function EditorModeSelect(props: Props) {
value={props.value} value={props.value}
onFocus={props.focusEditor} onFocus={props.focusEditor}
onChange={props.onChange} onChange={props.onChange}
row={true} row
> >
<FormControlLabel <FormControlLabel
value="text" value="text"

View File

@@ -1,19 +1,19 @@
import Editor from './Editor'
import { AttachFileOutlined, FormatAlignLeft } from '@mui/icons-material' import { AttachFileOutlined, FormatAlignLeft } from '@mui/icons-material'
import Message from './Model/Message'
import Navigation from '@mui/icons-material/Navigation' import Navigation from '@mui/icons-material/Navigation'
import PublishHistory from './PublishHistory'
import React, { useCallback, useMemo, useState, useRef, memo } from 'react' import React, { useCallback, useMemo, useState, useRef, memo } from 'react'
import RetainSwitch from './RetainSwitch'
import TopicInput from './TopicInput'
import { AppState } from '../../../reducers'
import { bindActionCreators } from 'redux' import { bindActionCreators } from 'redux'
import { Button, Fab, Tooltip } from '@mui/material' import { Button, Fab, Tooltip } from '@mui/material'
import { connect } from 'react-redux' import { connect } from 'react-redux'
import { default as AceEditor } from 'react-ace'
import Editor from './Editor'
import Message from './Model/Message'
import PublishHistory from './PublishHistory'
import RetainSwitch from './RetainSwitch'
import TopicInput from './TopicInput'
import { AppState } from '../../../reducers'
import { EditorModeSelect } from './EditorModeSelect' import { EditorModeSelect } from './EditorModeSelect'
import { globalActions, publishActions } from '../../../actions' import { globalActions, publishActions } from '../../../actions'
import { KeyCodes } from '../../../utils/KeyCodes' import { KeyCodes } from '../../../utils/KeyCodes'
import { default as AceEditor } from 'react-ace'
interface Props { interface Props {
connectionId?: string connectionId?: string
@@ -56,7 +56,7 @@ function Publish(props: Props) {
props.actions.publish(props.connectionId) props.actions.publish(props.connectionId)
const topic = props.topic || '' const topic = props.topic || ''
const payload = props.payload const { payload } = props
if (props.connectionId && topic) { if (props.connectionId && topic) {
amendToHistory(topic, payload) amendToHistory(topic, payload)
} }
@@ -101,87 +101,85 @@ function Publish(props: Props) {
) )
} }
const EditorMode = memo(function EditorMode(props: { const EditorMode = memo(
payload?: string (props: {
editorMode: string payload?: string
focusEditor: () => void editorMode: string
actions: typeof publishActions focusEditor: () => void
globalActions: typeof globalActions actions: typeof publishActions
publish: () => void globalActions: typeof globalActions
}) { publish: () => void
const updatePayload = props.actions.setPayload }) => {
const updatePayload = props.actions.setPayload
const updateMode = useCallback((e: React.ChangeEvent<{}>, value: string) => { const updateMode = useCallback((e: React.ChangeEvent<{}>, value: string) => {
props.actions.setEditorMode(value) props.actions.setEditorMode(value)
}, []) }, [])
const openFile = useCallback(() => { const openFile = useCallback(() => {
props.actions.openFile() props.actions.openFile()
}, []) }, [])
const formatJson = useCallback(() => { const formatJson = useCallback(() => {
if (props.payload) { if (props.payload) {
try { try {
const str = JSON.stringify(JSON.parse(props.payload), undefined, ' ') const str = JSON.stringify(JSON.parse(props.payload), undefined, ' ')
updatePayload(str) updatePayload(str)
} catch (error) { } catch (error) {
props.globalActions.showError(`Format error: ${(error as Error)?.message}`) props.globalActions.showError(`Format error: ${(error as Error)?.message}`)
}
} }
} }, [props.payload])
}, [props.payload])
return ( return (
<div style={{ marginTop: '16px' }}> <div style={{ marginTop: '16px' }}>
<div style={{ width: '100%', lineHeight: '64px', textAlign: 'center' }}> <div style={{ width: '100%', lineHeight: '64px', textAlign: 'center' }}>
<EditorModeSelect value={props.editorMode} onChange={updateMode} focusEditor={props.focusEditor} /> <EditorModeSelect value={props.editorMode} onChange={updateMode} focusEditor={props.focusEditor} />
<FormatJsonButton editorMode={props.editorMode} focusEditor={props.focusEditor} formatJson={formatJson} /> <FormatJsonButton editorMode={props.editorMode} focusEditor={props.focusEditor} formatJson={formatJson} />
<OpenFileButton editorMode={props.editorMode} openFile={openFile} /> <OpenFileButton editorMode={props.editorMode} openFile={openFile} />
<div style={{ float: 'right' }}> <div style={{ float: 'right' }}>
<PublishButton publish={props.publish} focusEditor={props.focusEditor} /> <PublishButton publish={props.publish} focusEditor={props.focusEditor} />
</div>
</div> </div>
</div> </div>
</div> )
)
})
const FormatJsonButton = React.memo(function FormatJsonButton(props: {
editorMode: string
focusEditor: () => void
formatJson: () => void
}) {
if (props.editorMode !== 'json') {
return null
} }
)
return ( const FormatJsonButton = React.memo(
<Tooltip title="Format JSON"> (props: { editorMode: string; focusEditor: () => void; formatJson: () => void }) => {
<Fab if (props.editorMode !== 'json') {
style={{ width: '36px', height: '36px', margin: '0 8px' }} return null
onClick={props.formatJson} }
onFocus={props.focusEditor}
id="sidebar-publish-format-json"
>
<FormatAlignLeft style={{ fontSize: '20px' }} />
</Fab>
</Tooltip>
)
})
const OpenFileButton = React.memo(function OpenFileButton(props: { editorMode: string; openFile: () => void }) { return (
return ( <Tooltip title="Format JSON">
<Tooltip title="Open file"> <Fab
<Fab style={{ width: '36px', height: '36px', margin: '0 8px' }}
style={{ width: '36px', height: '36px', margin: '0 8px' }} onClick={props.formatJson}
onClick={props.openFile} onFocus={props.focusEditor}
id="sidebar-publish-open-file" id="sidebar-publish-format-json"
> >
<AttachFileOutlined style={{ fontSize: '20px' }} /> <FormatAlignLeft style={{ fontSize: '20px' }} />
</Fab> </Fab>
</Tooltip> </Tooltip>
) )
}) }
)
const PublishButton = memo(function PublishButton(props: { publish: () => void; focusEditor: () => void }) { const OpenFileButton = React.memo((props: { editorMode: string; openFile: () => void }) => (
<Tooltip title="Open file">
<Fab
style={{ width: '36px', height: '36px', margin: '0 8px' }}
onClick={props.openFile}
id="sidebar-publish-open-file"
>
<AttachFileOutlined style={{ fontSize: '20px' }} />
</Fab>
</Tooltip>
))
const PublishButton = memo((props: { publish: () => void; focusEditor: () => void }) => {
const handleClickPublish = useCallback( const handleClickPublish = useCallback(
(e: React.MouseEvent) => { (e: React.MouseEvent) => {
e.stopPropagation() e.stopPropagation()
@@ -204,20 +202,16 @@ const PublishButton = memo(function PublishButton(props: { publish: () => void;
) )
}) })
const mapDispatchToProps = (dispatch: any) => { const mapDispatchToProps = (dispatch: any) => ({
return { actions: bindActionCreators(publishActions, dispatch),
actions: bindActionCreators(publishActions, dispatch), globalActions: bindActionCreators(globalActions, dispatch),
globalActions: bindActionCreators(globalActions, dispatch), })
}
}
const mapStateToProps = (state: AppState) => { const mapStateToProps = (state: AppState) => ({
return { topic: state.publish.manualTopic,
topic: state.publish.manualTopic, payload: state.publish.payload,
payload: state.publish.payload, editorMode: state.publish.editorMode,
editorMode: state.publish.editorMode, retain: state.publish.retain,
retain: state.publish.retain, })
}
}
export default connect(mapStateToProps, mapDispatchToProps)(Publish) export default connect(mapStateToProps, mapDispatchToProps)(Publish)

Some files were not shown because too many files have changed in this diff Show More